From 58dc3e93d375a36c3c8c82fbbb7dc6322a475869 Mon Sep 17 00:00:00 2001
From: flow <flowlnlnln@gmail.com>
Date: Fri, 1 Jul 2022 11:59:34 -0300
Subject: [PATCH] fix: clean up execWithTask in Progress Dialog

This prevents weird problems, such as dialogs being non-modal when they
should be!

Signed-off-by: flow <flowlnlnln@gmail.com>
---
 launcher/ui/dialogs/ModUpdateDialog.cpp |  2 --
 launcher/ui/dialogs/ProgressDialog.cpp  | 34 +++++++++++--------------
 2 files changed, 15 insertions(+), 21 deletions(-)

diff --git a/launcher/ui/dialogs/ModUpdateDialog.cpp b/launcher/ui/dialogs/ModUpdateDialog.cpp
index 4f83eeb9..c280c8da 100644
--- a/launcher/ui/dialogs/ModUpdateDialog.cpp
+++ b/launcher/ui/dialogs/ModUpdateDialog.cpp
@@ -108,10 +108,8 @@ void ModUpdateDialog::checkCandidates()
     });
 
     // Check for updates
-    // FIXME: SOMEHOW THIS IS NOT MODAL???????
     ProgressDialog progress_dialog(m_parent);
     progress_dialog.setSkipButton(true, tr("Abort"));
-    progress_dialog.setVisible(true);
     progress_dialog.setWindowTitle(tr("Checking for updates..."));
     auto ret = progress_dialog.execWithTask(&check_task);
 
diff --git a/launcher/ui/dialogs/ProgressDialog.cpp b/launcher/ui/dialogs/ProgressDialog.cpp
index e5226016..a79bc837 100644
--- a/launcher/ui/dialogs/ProgressDialog.cpp
+++ b/launcher/ui/dialogs/ProgressDialog.cpp
@@ -62,24 +62,24 @@ void ProgressDialog::updateSize()
 int ProgressDialog::execWithTask(Task* task)
 {
     this->task = task;
-    QDialog::DialogCode result;
 
     if (!task) {
-        qDebug() << "Programmer error: progress dialog created with null task.";
-        return Accepted;
+        qDebug() << "Programmer error: Progress dialog created with null task.";
+        return QDialog::DialogCode::Accepted;
     }
 
+    QDialog::DialogCode result;
     if (handleImmediateResult(result)) {
         return result;
     }
 
     // Connect signals.
-    connect(task, SIGNAL(started()), SLOT(onTaskStarted()));
-    connect(task, SIGNAL(failed(QString)), SLOT(onTaskFailed(QString)));
-    connect(task, SIGNAL(succeeded()), SLOT(onTaskSucceeded()));
-    connect(task, SIGNAL(status(QString)), SLOT(changeStatus(const QString&)));
-    connect(task, SIGNAL(stepStatus(QString)), SLOT(changeStatus(const QString&)));
-    connect(task, SIGNAL(progress(qint64, qint64)), SLOT(changeProgress(qint64, qint64)));
+    connect(task, &Task::started, this, &ProgressDialog::onTaskStarted);
+    connect(task, &Task::failed, this, &ProgressDialog::onTaskFailed);
+    connect(task, &Task::succeeded, this, &ProgressDialog::onTaskSucceeded);
+    connect(task, &Task::status, this, &ProgressDialog::changeStatus);
+    connect(task, &Task::stepStatus, this, &ProgressDialog::changeStatus);
+    connect(task, &Task::progress, this, &ProgressDialog::changeProgress);
 
     connect(task, &Task::aborted, [this] { onTaskFailed(tr("Aborted by user")); });
 
@@ -89,19 +89,15 @@ int ProgressDialog::execWithTask(Task* task)
         ui->globalProgressBar->setHidden(true);
     }
 
-    // if this didn't connect to an already running task, invoke start
+    // It's a good idea to start the task after we entered the dialog's event loop :^)
     if (!task->isRunning()) {
-        task->start();
-    }
-    if (task->isRunning()) {
-        changeProgress(task->getProgress(), task->getTotalProgress());
-        changeStatus(task->getStatus());
-        return QDialog::exec();
-    } else if (handleImmediateResult(result)) {
-        return result;
+        QMetaObject::invokeMethod(task, &Task::start, Qt::QueuedConnection);
     } else {
-        return QDialog::Rejected;
+        changeStatus(task->getStatus());
+        changeProgress(task->getProgress(), task->getTotalProgress());
     }
+
+    return QDialog::exec();
 }
 
 // TODO: only provide the unique_ptr overloads