0xf8/pollymc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: memory leak when getting mods from the mods folder

Browse Source 
friendly reminder to always delete your news.

Signed-off-by: flow <flowlnlnln@gmail.com>
This commit is contained in:
flow 2022-09-16 19:22:37 -03:00
parent 1ca2be0039
commit 9e35230467
No known key found for this signature in database
GPG Key ID: 8D0F221F0A59F469
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
launcher/minecraft/mod/tasks/ModFolderLoadTask.cpp
View File

@ -57,6 +57,8 @@ void ModFolderLoadTask::executeTask()
if (mod->enabled()) { if (mod->enabled()) {
if (m_result->mods.contains(mod->internal_id())) { if (m_result->mods.contains(mod->internal_id())) {
m_result->mods[mod->internal_id()]->setStatus(ModStatus::Installed); m_result->mods[mod->internal_id()]->setStatus(ModStatus::Installed);
// Delete the object we just created, since a valid one is already in the mods list.
delete mod;
} }
else { else {
m_result->mods[mod->internal_id()] = mod; m_result->mods[mod->internal_id()] = mod;