0xf8/pollymc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: add changelog to mod providers

Browse Source 
The Modrinth changelog is fairly straight-forward, as it's given to us
directly with the API call we already did. Flame, on the other hand,
requires us to do another call to get the changelog, so it can introduce
quite a heavy performance impact. This way, we make it optional to get
such changelog.

Signed-off-by: flow <flowlnlnln@gmail.com>
This commit is contained in:
flow 2022-06-03 20:45:44 -03:00
parent 844b245776
commit c3f6c3dd82
No known key found for this signature in database
GPG Key ID: 8D0F221F0A59F469
4 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
launcher/modplatform/ModIndex.h
View File

@ -62,6 +62,7 @@ struct IndexedVersion {
QString hash_type; QString hash_type;
QString hash; QString hash;
bool is_preferred = true; bool is_preferred = true;
QString changelog;
}; };
struct ExtraPackData { struct ExtraPackData {

7
launcher/modplatform/flame/FlameModIndex.cpp
View File

@ -7,6 +7,7 @@
#include "net/NetJob.h" #include "net/NetJob.h"
static ModPlatform::ProviderCapabilities ProviderCaps; static ModPlatform::ProviderCapabilities ProviderCaps;
static FlameAPI api;
void FlameMod::loadIndexedPack(ModPlatform::IndexedPack& pack, QJsonObject& obj) void FlameMod::loadIndexedPack(ModPlatform::IndexedPack& pack, QJsonObject& obj)
{ {
@ -91,7 +92,7 @@ void FlameMod::loadIndexedPackVersions(ModPlatform::IndexedPack& pack,
pack.versionsLoaded = true; pack.versionsLoaded = true;
} }
auto FlameMod::loadIndexedPackVersion(QJsonObject& obj) -> ModPlatform::IndexedVersion auto FlameMod::loadIndexedPackVersion(QJsonObject& obj, bool load_changelog) -> ModPlatform::IndexedVersion
{ {
auto versionArray = Json::requireArray(obj, "gameVersions"); auto versionArray = Json::requireArray(obj, "gameVersions");
if (versionArray.isEmpty()) { if (versionArray.isEmpty()) {
@ -124,5 +125,9 @@ auto FlameMod::loadIndexedPackVersion(QJsonObject& obj) -> ModPlatform::IndexedV
break; break;
} }
} }
if(load_changelog)
file.changelog = api.getModFileChangelog(file.addonId.toInt(), file.fileId.toInt());
return file; return file;
} }

2
launcher/modplatform/flame/FlameModIndex.h
View File

@ -17,6 +17,6 @@ void loadIndexedPackVersions(ModPlatform::IndexedPack& pack,
QJsonArray& arr, QJsonArray& arr,
const shared_qobject_ptr<QNetworkAccessManager>& network, const shared_qobject_ptr<QNetworkAccessManager>& network,
BaseInstance* inst); BaseInstance* inst);
auto loadIndexedPackVersion(QJsonObject& obj) -> ModPlatform::IndexedVersion; auto loadIndexedPackVersion(QJsonObject& obj, bool load_changelog = false) -> ModPlatform::IndexedVersion;
} // namespace FlameMod } // namespace FlameMod

1
launcher/modplatform/modrinth/ModrinthPackIndex.cpp
View File

@ -130,6 +130,7 @@ auto Modrinth::loadIndexedPackVersion(QJsonObject &obj, QString preferred_hash_t
file.loaders.append(loader.toString()); file.loaders.append(loader.toString());
} }
file.version = Json::requireString(obj, "name"); file.version = Json::requireString(obj, "name");
file.changelog = Json::requireString(obj, "changelog");
auto files = Json::requireArray(obj, "files"); auto files = Json::requireArray(obj, "files");
int i = 0; int i = 0;