0xf8/pollymc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Fixed memory leak

Browse Source 
Signed-off-by: timoreo <contact@timoreo.fr>
This commit is contained in:
timoreo 2022-09-26 11:50:55 +02:00
parent 9ff364b0d3
commit dd6f670dec
No known key found for this signature in database
GPG Key ID: 121A72C3512BA288
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
launcher/modplatform/modrinth/ModrinthInstanceCreationTask.cpp
View File

@ -238,11 +238,12 @@ bool ModrinthCreationTask::createInstance()
if (!file.downloads.empty()) { if (!file.downloads.empty()) {
// FIXME: This really needs to be put into a ConcurrentTask of // FIXME: This really needs to be put into a ConcurrentTask of
// MultipleOptionsTask's , once those exist :) // MultipleOptionsTask's , once those exist :)
connect(dl.get(), &NetAction::failed, [this, &file, path, dl] { auto param = dl.toWeakRef();
auto dl = Net::Download::makeFile(file.downloads.dequeue(), path); connect(dl.get(), &NetAction::failed, [this, &file, path, param] {
dl->addValidator(new Net::ChecksumValidator(file.hashAlgorithm, file.hash)); auto ndl = Net::Download::makeFile(file.downloads.dequeue(), path);
m_files_job->addNetAction(dl); ndl->addValidator(new Net::ChecksumValidator(file.hashAlgorithm, file.hash));
dl->succeeded(); m_files_job->addNetAction(ndl);
if (auto shared = param.lock()) shared->succeeded();
}); });
} }
} }