Fork of PollyMC to add custom login support
Go to file
Jamie Mansfield 8e6400e8d8
NOISSUE Fix edgecase where new searches won't be processed
This resolves an issue with the modpacks.ch search functionality, in
which a search issued while one is currently in progress won't be made
and the UI won't allow for the search to be made after.

Reproduction Steps:
1. Open the FTB pane in the Add Instance Dialog
2. Perform a search while MMC is still performing the initial search

The search won't be performed, the existing search will have been
aborted, and you are unable to try the search again (without trying a
different search in the meantime).

This was caused by 2 things:
1. A search cannot be re-attempted, and this logic doesn't consider
   failures.
2. The failure slot wasn't called when the NetJob was aborted, so
   the search would never be performed - but the term would be
   stored as if it had (trigering point 1).

I have resolved this by doing 2 things:
1. If the failure slot is called, set a searchState of Failed. Allow
   search re-attempts in this case.
2. If there is a present NetJob, abort and reset it. The immediately
   continue with the search.
2021-03-26 20:03:57 +00:00
.github/ISSUE_TEMPLATE NOISSUE add github issue forms 2021-03-19 00:24:52 +01:00
api NOISSUE fix build - missing includes in RWStorage.h 2021-03-26 01:48:37 +01:00
application NOISSUE Fix edgecase where new searches won't be processed 2021-03-26 20:03:57 +00:00
buildconfig GH-405 ATLauncher Support 2021-02-07 23:30:24 +01:00
cmake
libraries Merge pull request #3311 from AbigailBuccaneer/develop 2021-02-09 23:12:32 +01:00
.gitattributes
.gitignore
.gitmodules
BUILD.md Fix #3638 2021-03-08 09:24:37 -05:00
changelog.md NOISSUE remove text about future plans 2021-03-22 02:17:01 +01:00
CMakeLists.txt Merge pull request #3538 from Scotsguy/develop 2021-02-07 02:23:31 +01:00
COPYING.md Merge pull request #3538 from Scotsguy/develop 2021-02-07 02:23:31 +01:00
README.md NOISSUE Swap discord invite with vanity url 2021-02-09 22:00:20 +01:00

MultiMC logo

MultiMC 5

MultiMC is a custom launcher for Minecraft that allows you to easily manage multiple installations of Minecraft at once. It also allows you to easily install and remove mods by simply dragging and dropping. Here are the current features of MultiMC.

Development

The project uses C++ and Qt5 as the language and base framework. This might seem odd in the Minecraft community, but allows using 25MB of RAM, where other tools use an excessive amount of resources for no reason.

We can do more, with less, on worse hardware and leave more resources for the game while keeping the launcher running and providing extra features.

If you want to contribute, either talk to us on Discord, IRC(esper.net/#MultiMC) or pick up some item from the github issues workflowy - there is always plenty of ideas around.

Building

If you want to build MultiMC yourself, check BUILD.md for build instructions.

Code formatting

Just follow the existing formatting.

In general:

  • Indent with 4 space unless it's in a submodule
  • Keep lists (of arguments, parameters, initializators...) as lists, not paragraphs.
  • Prefer readability over dogma.

Translations

Translations can be done on crowdin.

Forking/Redistributing

We keep MultiMC open source because we think it's important to be able to see the source code for a project like this, and we do so using the Apache license.

Part of the reason for using the Apache license is we don't want people using the "MultiMC" name when redistributing the project. This means people must take the time to go through the source code and remove all references to "MultiMC", including but not limited to the project icon and the title of windows, (no MultiMC-fork in the title).

Apache covers reasonable use for the name - a mention of the project's origins in the About dialog and the license is acceptable. However, it should be abundantly clear that the project is a fork without implying that you have our blessing.

License

Copyright © 2013-2021 MultiMC Contributors

Licensed under the Apache License, Version 2.0 (the "License"); you may not use this program except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0.

Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.

Build status

Linux (Intel32)

Build: Deploy:

Linux (AMD64)

Build: Deploy:

macOS (AMD64)

Build: Deploy:

Windows (Intel32)

Build: Deploy: