From 189ad2693a9d79e63187b6dba82c81f61f7bdd22 Mon Sep 17 00:00:00 2001 From: RichardG867 Date: Sat, 28 Mar 2020 18:50:47 -0300 Subject: [PATCH] W83781D hardware monitoring improvements --- src/hwm.c | 2 +- src/hwm.h | 4 +- src/hwm_w83781d.c | 158 +++++++++++++++++++++++-------------- src/machine/m_at_socket8.c | 2 +- 4 files changed, 101 insertions(+), 65 deletions(-) diff --git a/src/hwm.c b/src/hwm.c index 1ebd6de00..7c953b1ab 100644 --- a/src/hwm.c +++ b/src/hwm.c @@ -6,7 +6,7 @@ * * This file is part of the 86Box distribution. * - * Common functions for hardware monitor chips. + * Common functions for hardware monitoring chips. * * * diff --git a/src/hwm.h b/src/hwm.h index 475b4719c..f4cace10d 100644 --- a/src/hwm.h +++ b/src/hwm.h @@ -6,7 +6,7 @@ * * This file is part of the 86Box distribution. * - * Definitions for the hardware monitor chips. + * Definitions for hardware monitoring chips. * * * @@ -22,7 +22,7 @@ typedef struct _hwm_values_ { uint16_t fans[4]; - uint8_t temperatures[4]; + uint8_t temperatures[4]; uint16_t voltages[8]; } hwm_values_t; diff --git a/src/hwm_w83781d.c b/src/hwm_w83781d.c index 0ff148a6e..3d3c62c78 100644 --- a/src/hwm_w83781d.c +++ b/src/hwm_w83781d.c @@ -26,19 +26,21 @@ #define W83781D_SMBUS 0x10000 -#define W83781D_AS99127F 0x20000 -#define W83781D_VENDOR_ID ((dev->local & W83781D_AS99127F) ? 0x12C3 : 0x5CA3) +#define W83781D_AS99127F_REV1 0x20000 +#define W83781D_AS99127F_REV2 0x40000 +#define W83781D_AS99127F 0x60000 /* special mask covering both _REV1 and _REV2 */ +#define W83781D_VENDOR_ID ((dev->local & W83781D_AS99127F_REV1) ? 0x12C3 : 0x5CA3) #define CLAMP(a, min, max) (((a) < (min)) ? (min) : (((a) > (max)) ? (max) : (a))) #define W83781D_RPM_TO_REG(r, d) CLAMP(1350000 / (r * d), 1, 255) -#define W83781D_TEMP_TO_REG(t) ((t) * 8) << 5 +#define W83781D_TEMP_TO_REG(t) ((t) << 8) typedef struct { uint32_t local; hwm_values_t* values; - uint8_t regs[64]; + uint8_t regs[256]; uint8_t regs_bank1[6]; uint8_t regs_bank2[6]; uint8_t addr_register; @@ -151,27 +153,27 @@ w83781d_smbus_read_word_cmd(uint8_t addr, uint8_t cmd, void *priv) bank = 3; switch (cmd & 0x3) { - case 0x0: + case 0x0: /* temperature */ rethi = w83781d_read(dev, 0x50, bank); retlo = w83781d_read(dev, 0x51, bank); break; - case 0x1: + case 0x1: /* configuration */ rethi = retlo = w83781d_read(dev, 0x52, bank); break; - case 0x2: + case 0x2: /* Thyst */ rethi = w83781d_read(dev, 0x53, bank); retlo = w83781d_read(dev, 0x54, bank); break; - case 0x3: + case 0x3: /* Tos */ rethi = w83781d_read(dev, 0x55, bank); retlo = w83781d_read(dev, 0x56, bank); break; } - - return (retlo << 8) | rethi; /* byte-swapped for some reason */ + } else { + rethi = retlo = w83781d_read(dev, cmd, bank); } - return w83781d_read(dev, cmd, bank); + return (retlo << 8) | rethi; /* byte-swapped for some reason */ } @@ -190,12 +192,14 @@ w83781d_read(w83781d_t *dev, uint8_t reg, uint8_t bank) /* regular registers */ if (reg == 0x4F) /* special case for two-byte vendor ID register */ ret = dev->hbacs ? (W83781D_VENDOR_ID >> 8) : (W83781D_VENDOR_ID & 0xFF); - else if (reg >= 0x60) /* read auto-increment value RAM registers from their non-auto-increment locations */ + else if (reg >= 0x60 && reg <= 0x7F) /* read auto-increment value RAM registers from their non-auto-increment locations */ ret = dev->regs[reg - 0x40]; else - ret = dev->regs[reg - 0x20]; + ret = dev->regs[reg]; } + pclog("w83781d_read(%02x, %d) = %02x\n", reg, bank, ret); + return ret; } @@ -256,18 +260,18 @@ w83781d_smbus_write_word_cmd(uint8_t addr, uint8_t cmd, uint16_t val, void *priv bank = 3; switch (cmd & 0x3) { - case 0x0: + case 0x0: /* temperature */ w83781d_write(dev, 0x50, valhi, bank); w83781d_write(dev, 0x51, vallo, bank); break; - case 0x1: + case 0x1: /* configuration */ w83781d_write(dev, 0x52, vallo, bank); break; - case 0x2: + case 0x2: /* Thyst */ w83781d_write(dev, 0x53, valhi, bank); w83781d_write(dev, 0x54, vallo, bank); break; - case 0x3: + case 0x3: /* Tos */ w83781d_write(dev, 0x55, valhi, bank); w83781d_write(dev, 0x56, vallo, bank); break; @@ -310,55 +314,57 @@ w83781d_write(w83781d_t *dev, uint8_t reg, uint8_t val, uint8_t bank) return 0; } - if (reg >= 0x60) /* write auto-increment value RAM registers to their non-auto-increment locations */ + if (reg >= 0x60 && reg <= 0x7F) /* write auto-increment value RAM registers to their non-auto-increment locations */ dev->regs[reg - 0x40] = val; else - dev->regs[reg - 0x20] = val; + dev->regs[reg] = val; switch (reg) { case 0x40: if (val >> 7) { - /* INITIALIZATION bit set: reset all registers except main SMBus address */ + /* INITIALIZATION bit resets all registers except main SMBus address */ w83781d_reset(dev, 1); } break; case 0x47: /* update FAN1/FAN2 values to match the new divisor */ - dev->regs[0x08] = W83781D_RPM_TO_REG(dev->values->fans[0], 1 << ((dev->regs[0x27] >> 4) & 0x3)); - dev->regs[0x09] = W83781D_RPM_TO_REG(dev->values->fans[1], 1 << ((dev->regs[0x27] >> 6) & 0x3)); + dev->regs[0x28] = W83781D_RPM_TO_REG(dev->values->fans[0], 1 << ((dev->regs[0x47] >> 4) & 0x3)); + dev->regs[0x29] = W83781D_RPM_TO_REG(dev->values->fans[1], 1 << ((dev->regs[0x47] >> 6) & 0x3)); break; case 0x48: + /* set main SMBus address */ if (dev->local & W83781D_SMBUS) { - dev->smbus_addr_main = (dev->regs[0x28] & 0x7F); + dev->smbus_addr_main = (dev->regs[0x48] & 0x7F); remap = 1; } break; case 0x4A: + /* set TEMP2 and TEMP3 SMBus addresses */ if (dev->local & W83781D_SMBUS) { - /* DIS_T2 and DIS_T3 bits can disable those interfaces */ - if ((dev->regs[0x2A] >> 3) & 0x1) + /* DIS_T2 and DIS_T3 bits disable those interfaces */ + if ((dev->regs[0x4A] >> 3) & 0x1) dev->smbus_addr_temp2 = 0x00; else - dev->smbus_addr_temp2 = 0x48 + (dev->regs[0x2A] & 0x7); - if (dev->regs[0x2A] >> 7) + dev->smbus_addr_temp2 = 0x48 + (dev->regs[0x4A] & 0x7); + if (dev->regs[0x4A] >> 7) dev->smbus_addr_temp3 = 0x00; else - dev->smbus_addr_temp3 = 0x48 + ((dev->regs[0x2A] >> 4) & 0x7); + dev->smbus_addr_temp3 = 0x48 + ((dev->regs[0x4A] >> 4) & 0x7); remap = 1; } break; case 0x4B: /* update FAN3 value to match the new divisor */ - dev->regs[0x0A] = W83781D_RPM_TO_REG(dev->values->fans[2], 1 << ((dev->regs[0x2B] >> 6) & 0x3)); + dev->regs[0x2A] = W83781D_RPM_TO_REG(dev->values->fans[2], 1 << ((dev->regs[0x4B] >> 6) & 0x3)); break; case 0x4E: - dev->hbacs = (dev->regs[0x2E] & 0x80); + dev->hbacs = (dev->regs[0x4E] & 0x80); /* FIXME: Winbond's datasheet does not specify how BANKSEL[0:2] work */ - if (dev->regs[0x2E] & 0x1) + if (dev->regs[0x4E] & 0x1) dev->active_bank = 0; - else if (dev->regs[0x2E] & 0x2) + else if (dev->regs[0x4E] & 0x2) dev->active_bank = 1; - else if (dev->regs[0x2E] & 0x4) + else if (dev->regs[0x4E] & 0x4) dev->active_bank = 2; break; } @@ -373,41 +379,56 @@ w83781d_write(w83781d_t *dev, uint8_t reg, uint8_t val, uint8_t bank) static void w83781d_reset(w83781d_t *dev, uint8_t initialization) { - memset(dev->regs, 0, 64); + memset(dev->regs, 0, 256); memset(dev->regs_bank1, 0, 6); memset(dev->regs_bank2, 0, 6); - /* WARNING: Array elements are register - 0x20. */ uint8_t i; for (i = 0; i <= 6; i++) - dev->regs[i] = (dev->values->voltages[i] / 16); - dev->regs[0x07] = dev->values->temperatures[0]; + dev->regs[0x20 + i] = (dev->values->voltages[i] >> 4); + dev->regs[0x27] = dev->values->temperatures[0]; for (i = 0; i <= 2; i++) - dev->regs[0x08 + i] = W83781D_RPM_TO_REG(dev->values->fans[i], 2); - dev->regs[0x20] = 0x01; - dev->regs[0x26] = 0x40; - dev->regs[0x27] = 0x50; + dev->regs[0x28 + i] = W83781D_RPM_TO_REG(dev->values->fans[i], 2); + dev->regs[0x40] = 0x01; + dev->regs[0x46] = 0x40; + dev->regs[0x47] = 0x50; if (dev->local & W83781D_SMBUS) { if (!initialization) /* don't reset main SMBus address if the reset was triggered by the INITIALIZATION bit */ dev->smbus_addr_main = 0x2D; - dev->regs[0x28] = dev->smbus_addr_main; - dev->regs[0x2A] = 0x01; - dev->smbus_addr_temp2 = 0x48 + (dev->regs[0x2A] & 0x7); - dev->smbus_addr_temp3 = 0x48 + ((dev->regs[0x2A] >> 4) & 0x7); + dev->regs[0x48] = dev->smbus_addr_main; + dev->regs[0x4A] = 0x01; + dev->smbus_addr_temp2 = 0x48 + (dev->regs[0x4A] & 0x7); + dev->smbus_addr_temp3 = 0x48 + ((dev->regs[0x4A] >> 4) & 0x7); } else { - dev->regs[0x28] = 0x00; - dev->regs[0x2A] = 0x88; + dev->regs[0x48] = 0x00; + dev->regs[0x4A] = 0x88; dev->smbus_addr_temp2 = dev->smbus_addr_temp3 = 0x00; } - dev->regs[0x29] = 0x02; - dev->regs[0x2B] = 0x44; - dev->regs[0x2C] = 0x01; - dev->regs[0x2D] = 0x15; - dev->regs[0x2E] = 0x80; - dev->hbacs = (dev->regs[0x2E] & 0x80); - dev->regs[0x2F] = W83781D_VENDOR_ID >> 8; - dev->regs[0x37] = 0x80; - dev->regs[0x38] = (dev->local & W83781D_AS99127F) ? 0x31 : 0x10; + dev->regs[0x49] = 0x02; + dev->regs[0x4B] = 0x44; + dev->regs[0x4C] = 0x01; + dev->regs[0x4D] = 0x15; + dev->regs[0x4E] = 0x80; + dev->hbacs = (dev->regs[0x4E] & 0x80); + dev->regs[0x4F] = W83781D_VENDOR_ID >> 8; + dev->regs[0x57] = 0x80; + dev->regs[0x58] = (dev->local & W83781D_AS99127F) ? 0x31 : 0x10; + + /* + * Initialize proprietary registers on the AS99127F. The BIOS accesses + * these through read_byte_cmd on the TEMP2 address, hanging on POST code + * C1 if they're set to 0. There's no documentation on what these do nor + * dumps from real systems available, the values are pure guesswork. + */ + if (dev->local & W83781D_AS99127F) { + dev->regs[0x80] = 0x01; + dev->regs[0x81] = 0x01; + dev->regs[0x82] = 0x01; + dev->regs[0x83] = 0x01; + dev->regs[0x84] = 0x01; + dev->regs[0x88] = 0x01; + dev->regs[0x89] = 0x01; + } /* WARNING: Array elements are register - 0x50. */ uint16_t temp; @@ -457,6 +478,9 @@ w83781d_init(const device_t *info) } +/* + * Standard Winbond W83781D (or ASUS AS97127F) on ISA and SMBus. + */ const device_t w83781d_device = { "Winbond W83781D Hardware Monitor", DEVICE_ISA, @@ -468,14 +492,26 @@ const device_t w83781d_device = { /* - * ASUS rebadged version of the W83781D. - * Some claim it's SMBus-only, yet the BIOS clearly reads most values over ISA, - * except TEMP3 (CPU Temperature) which is read over SMBus. + * ASUS AS99127F is a customized W83781D with no ISA interface (SMBus only), + * added proprietary registers and different chip/vendor IDs. */ const device_t as99127f_device = { - "ASUS AS99127F Hardware Monitor", + "ASUS AS99127F Rev. 1 Hardware Monitor", DEVICE_ISA, - 0x295 | W83781D_SMBUS | W83781D_AS99127F, + W83781D_SMBUS | W83781D_AS99127F_REV1, + w83781d_init, w83781d_close, NULL, + NULL, NULL, NULL, + NULL +}; + + +/* + * Rev. 2 changes the vendor ID back to Winbond's. + */ +const device_t as99127f_rev2_device = { + "ASUS AS99127F Rev. 2 Hardware Monitor", + DEVICE_AT, + W83781D_SMBUS | W83781D_AS99127F_REV2, w83781d_init, w83781d_close, NULL, NULL, NULL, NULL, NULL diff --git a/src/machine/m_at_socket8.c b/src/machine/m_at_socket8.c index 32a4ec981..a40d6d180 100644 --- a/src/machine/m_at_socket8.c +++ b/src/machine/m_at_socket8.c @@ -197,7 +197,7 @@ machine_at_p2bls_init(const machine_t *model) machine_hwm.voltages[0] = 2800; /* set higher VCORE (2.8V) for Klamath */ #endif hwm_set_values(machine_hwm); - device_add(&as99127f_device); + device_add(&w83781d_device); return ret; }