80486DX2-66/86Box-fork
1
0
Fork 0
Code Issues Pull Requests Activity

Mark plat_vidapi() argument as const and remove the NULL

Browse Source 
* plat_vidapi() accepts char pointer, which never gets modifed
later on. Mark it as const.

* In src/config.c, va_name is initialized as NULL, however,
plat_vidapi_name() never returns a NULL pointer, nor it was
initialized under a condition branch. Removing NULL, might
save one instruction, which requires zeroing the register
before setting its initial value.
This commit is contained in:
rilysh
2024-07-21 12:49:06 +05:30
parent 92e8fe09a4
commit 189be035d2
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/config.c
View File

@@ -1720,7 +1720,7 @@ save_general(void)
char temp[512]; char temp[512];
char buffer[512] = { 0 }; char buffer[512] = { 0 };
const char *va_name = NULL; const char *va_name;
ini_section_set_int(cat, "vid_resize", vid_resize); ini_section_set_int(cat, "vid_resize", vid_resize);
if (vid_resize == 0) if (vid_resize == 0)

2
src/include/86box/plat.h
View File

@@ -153,7 +153,7 @@ extern uint32_t plat_get_ticks(void);
extern void plat_delay_ms(uint32_t count); extern void plat_delay_ms(uint32_t count);
extern void plat_pause(int p); extern void plat_pause(int p);
extern void plat_mouse_capture(int on); extern void plat_mouse_capture(int on);
extern int plat_vidapi(char *name); extern int plat_vidapi(const char *name);
extern char *plat_vidapi_name(int api); extern char *plat_vidapi_name(int api);
extern void plat_resize(int x, int y, int monitor_index); extern void plat_resize(int x, int y, int monitor_index);
extern void plat_resize_request(int x, int y, int monitor_index); extern void plat_resize_request(int x, int y, int monitor_index);

2
src/qt/qt.c
View File

@@ -38,7 +38,7 @@ qt_nvr_save(void)
char icon_set[256] = ""; /* name of the iconset to be used */ char icon_set[256] = ""; /* name of the iconset to be used */
int int
plat_vidapi(char *api) plat_vidapi(const char *api)
{ {
if (!strcasecmp(api, "default") || !strcasecmp(api, "system")) { if (!strcasecmp(api, "default") || !strcasecmp(api, "system")) {
return 0; return 0;

2
src/unix/unix_sdl.c
View File

@@ -392,7 +392,7 @@ sdl_reload(void)
} }
int int
plat_vidapi(char *api) plat_vidapi(UNUSED(const char *api))
{ {
return 0; return 0;
} }