80486DX2-66/86Box-fork
1
0
Fork 0
Code Issues Pull Requests Activity

VISO: Fix file descriptor leak on directory traversal

Browse Source
This commit is contained in:
RichardG867
2022-11-21 15:52:23 -03:00
parent dadc6ee2a7
commit 1ec5765f3f
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/cdrom/cdrom_image_viso.c
View File

@@ -859,7 +859,7 @@ viso_init(const char *dirname, int *error)
/* Iterate through this directory's children again, making the entries. */ /* Iterate through this directory's children again, making the entries. */
if (dirp) { if (dirp) {
rewinddir(dirp); rewinddir(dirp);
while ((readdir_entry = readdir(dirp))) { while ((readdir_entry = readdir(dirp))) {
/* Ignore . and .. pseudo-directories. */ /* Ignore . and .. pseudo-directories. */
if ((readdir_entry->d_name[0] == '.') && ((readdir_entry->d_name[1] == '\0') || (*((uint16_t *) &readdir_entry->d_name[1]) == '.'))) if ((readdir_entry->d_name[0] == '.') && ((readdir_entry->d_name[1] == '\0') || (*((uint16_t *) &readdir_entry->d_name[1]) == '.')))
@@ -931,6 +931,7 @@ viso_init(const char *dirname, int *error)
cdrom_image_viso_log("[%08X] %s => [%-12s] %s\n", entry, dir->path, entry->name_short, entry->basename); cdrom_image_viso_log("[%08X] %s => [%-12s] %s\n", entry, dir->path, entry->name_short, entry->basename);
} }
closedir(dirp);
} else { } else {
cdrom_image_viso_log("VISO: Failed to enumerate [%s], will be empty\n", dir->path); cdrom_image_viso_log("VISO: Failed to enumerate [%s], will be empty\n", dir->path);
} }