From 2fd5fe86cd5e35ac089c79d4eb7ff49e682906b1 Mon Sep 17 00:00:00 2001 From: OBattler Date: Thu, 28 Mar 2024 18:12:30 +0100 Subject: [PATCH] SiS 55xx: Add sanity check to the PCI to ISA bridge close code, fixes #4304. --- src/chipset/sis_5513_p2i.c | 3 ++- src/chipset/sis_5581.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/chipset/sis_5513_p2i.c b/src/chipset/sis_5513_p2i.c index d0c423a8e..ef9a6746d 100644 --- a/src/chipset/sis_5513_p2i.c +++ b/src/chipset/sis_5513_p2i.c @@ -1197,7 +1197,8 @@ sis_5513_pci_to_isa_close(void *priv) sis_5513_pci_to_isa_t *dev = (sis_5513_pci_to_isa_t *) priv; FILE *fp = NULL; - fp = nvr_fopen(dev->fn, "wb"); + if (dev->fn != NULL) + fp = nvr_fopen(dev->fn, "wb"); if (fp != NULL) { (void) fwrite(dev->apc_regs, 256, 1, fp); diff --git a/src/chipset/sis_5581.c b/src/chipset/sis_5581.c index 98b37897c..e2308c2d9 100644 --- a/src/chipset/sis_5581.c +++ b/src/chipset/sis_5581.c @@ -43,7 +43,6 @@ #include <86box/sis_55xx.h> #include <86box/chipset.h> -#define ENABLE_SIS_5581_LOG 1 #ifdef ENABLE_SIS_5581_LOG int sis_5581_do_log = ENABLE_SIS_5581_LOG;