80486DX2-66/86Box-fork
1
0
Fork 0
Code Issues Pull Requests Activity

Fix null pointers in qt_settingsports.cpp

Browse Source
This commit is contained in:
Jasmine Iwanek
2024-06-29 18:57:52 -04:00
committed by GitHub
parent 970242e24a
commit 597735ded6
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/qt/qt_settingsports.cpp
View File

@@ -59,13 +59,16 @@ SettingsPorts::SettingsPorts(QWidget *parent)
cbox->setCurrentIndex(selectedRow); cbox->setCurrentIndex(selectedRow);
auto *checkBox = findChild<QCheckBox *>(QString("checkBoxParallel%1").arg(i + 1)); auto *checkBox = findChild<QCheckBox *>(QString("checkBoxParallel%1").arg(i + 1));
checkBox->setChecked(lpt_ports[i].enabled > 0); if (checkBox != NULL)
cbox->setEnabled(lpt_ports[i].enabled > 0); checkBox->setChecked(lpt_ports[i].enabled > 0);
if (cBox != NULL)
cbox->setEnabled(lpt_ports[i].enabled > 0);
} }
for (int i = 0; i < SERIAL_MAX; i++) { for (int i = 0; i < SERIAL_MAX; i++) {
auto *checkBox = findChild<QCheckBox *>(QString("checkBoxSerial%1").arg(i + 1)); auto *checkBox = findChild<QCheckBox *>(QString("checkBoxSerial%1").arg(i + 1));
checkBox->setChecked(com_ports[i].enabled > 0); if (checkBox != NULL)
checkBox->setChecked(com_ports[i].enabled > 0);
} }
ui->checkBoxSerialPassThru1->setChecked(serial_passthrough_enabled[0]); ui->checkBoxSerialPassThru1->setChecked(serial_passthrough_enabled[0]);
@@ -89,13 +92,16 @@ SettingsPorts::save()
for (int i = 0; i < PARALLEL_MAX; i++) { for (int i = 0; i < PARALLEL_MAX; i++) {
auto *cbox = findChild<QComboBox *>(QString("comboBoxLpt%1").arg(i + 1)); auto *cbox = findChild<QComboBox *>(QString("comboBoxLpt%1").arg(i + 1));
auto *checkBox = findChild<QCheckBox *>(QString("checkBoxParallel%1").arg(i + 1)); auto *checkBox = findChild<QCheckBox *>(QString("checkBoxParallel%1").arg(i + 1));
lpt_ports[i].device = cbox->currentData().toInt(); if (cBox != NULL)
lpt_ports[i].enabled = checkBox->isChecked() ? 1 : 0; lpt_ports[i].device = cbox->currentData().toInt();
if (checkBox != NULL)
lpt_ports[i].enabled = checkBox->isChecked() ? 1 : 0;
} }
for (int i = 0; i < SERIAL_MAX; i++) { for (int i = 0; i < SERIAL_MAX; i++) {
auto *checkBox = findChild<QCheckBox *>(QString("checkBoxSerial%1").arg(i + 1)); auto *checkBox = findChild<QCheckBox *>(QString("checkBoxSerial%1").arg(i + 1));
com_ports[i].enabled = checkBox->isChecked() ? 1 : 0; if (checkBox != NULL)
com_ports[i].enabled = checkBox->isChecked() ? 1 : 0;
} }
serial_passthrough_enabled[0] = ui->checkBoxSerialPassThru1->isChecked(); serial_passthrough_enabled[0] = ui->checkBoxSerialPassThru1->isChecked();