From 499a74121e7ffc0b186ebf18a53d2d64130314f6 Mon Sep 17 00:00:00 2001 From: OBattler Date: Wed, 5 Jan 2022 19:28:39 +0100 Subject: [PATCH 1/2] Fixed the configuration file section the MIDI input device is obtained from. --- src/sound/midi_rtmidi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sound/midi_rtmidi.cpp b/src/sound/midi_rtmidi.cpp index e150159e4..3354568f6 100644 --- a/src/sound/midi_rtmidi.cpp +++ b/src/sound/midi_rtmidi.cpp @@ -166,7 +166,7 @@ rtmidi_input_init(const device_t *info) return nullptr; } - midi_in_id = config_get_int((char*)SYSTEM_MIDI_NAME, (char*)"midi_input", 0); + midi_in_id = config_get_int((char*)MIDI_INPUT_NAME, (char*)"midi_input", 0); try { midiin->openPort(midi_in_id); From d8f45bcaef370508a3d7ee6af2e6d4e03ce91d1e Mon Sep 17 00:00:00 2001 From: OBattler Date: Wed, 5 Jan 2022 23:58:07 +0100 Subject: [PATCH 2/2] Explicitly tell RTMIDI to not ignore any midi in message types. --- src/sound/midi_rtmidi.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/sound/midi_rtmidi.cpp b/src/sound/midi_rtmidi.cpp index 3354568f6..50246cac8 100644 --- a/src/sound/midi_rtmidi.cpp +++ b/src/sound/midi_rtmidi.cpp @@ -183,7 +183,10 @@ rtmidi_input_init(const device_t *info) } } - midiin->setCallback(rtmidi_input_callback); + midiin->setCallback(&rtmidi_input_callback); + + // Don't ignore sysex, timing, or active sensing messages. + midiin->ignoreTypes(false, false, false); midi_in_init(dev, &midi_in);