80486DX2-66/86Box-fork
1
0
Fork 0
Code Issues Pull Requests Activity

Fixed another potential overrun in win/win_settings.c.

Browse Source
This commit is contained in:
OBattler
2020-01-14 23:07:10 +01:00
parent a2f8162500
commit 93695b15b3
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/win/win_settings.c
View File

@@ -3467,7 +3467,7 @@ win_settings_floppy_drives_recalc_list(HWND hwndList)
{ {
LVITEM lvI; LVITEM lvI;
int i = 0; int i = 0;
char s[256]; char s[256], t;
WCHAR szText[256]; WCHAR szText[256];
lvI.mask = LVIF_TEXT | LVIF_IMAGE | LVIF_STATE; lvI.mask = LVIF_TEXT | LVIF_IMAGE | LVIF_STATE;
@@ -3476,7 +3476,11 @@ win_settings_floppy_drives_recalc_list(HWND hwndList)
for (i = 0; i < 4; i++) { for (i = 0; i < 4; i++) {
lvI.iSubItem = 0; lvI.iSubItem = 0;
if (temp_fdd_types[i] > 0) { if (temp_fdd_types[i] > 0) {
strcpy(s, fdd_getname(temp_fdd_types[i])); t = fdd_getname(temp_fdd_types[i]);
if (strlen(t) <= 256)
strcpy(s, t);
else
strncpy(s, t, 256);
mbstowcs(szText, s, strlen(s) + 1); mbstowcs(szText, s, strlen(s) + 1);
lvI.pszText = szText; lvI.pszText = szText;
} else } else