From b7ae66b3931c5646789a21fa2fb9607c8f2921ee Mon Sep 17 00:00:00 2001
From: Jasmine Iwanek <jasmine@iwanek.co.uk>
Date: Thu, 5 Oct 2023 13:00:37 -0400
Subject: [PATCH] Avoid more magic numbers

---
 src/cdrom/cdrom_mitsumi.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/src/cdrom/cdrom_mitsumi.c b/src/cdrom/cdrom_mitsumi.c
index f1b292f42..d270ab0f3 100644
--- a/src/cdrom/cdrom_mitsumi.c
+++ b/src/cdrom/cdrom_mitsumi.c
@@ -33,6 +33,10 @@
 #include <86box/plat.h>
 #include <86box/sound.h>
 
+#define MCD_DEFAULT_IOPORT 0x310
+#define MCD_DEFAULT_IRQ    5
+#define MCD_DEFAULT_DMA    5
+
 #define RAW_SECTOR_SIZE    2352
 #define COOKED_SECTOR_SIZE 2048
 
@@ -244,6 +248,8 @@ mitsumi_cdrom_in(uint16_t port, void *priv)
                 ret |= FLAG_NOSTAT;
             pclog("Read port 1: ret = %02x\n", ret | FLAG_UNK);
             return ret | FLAG_UNK;
+        case 2:
+            break;
         default:
             break;
     }
@@ -419,6 +425,8 @@ mitsumi_cdrom_out(uint16_t port, uint8_t val, void *priv)
         case 1:
             mitsumi_cdrom_reset(dev);
             break;
+        case 2:
+            break;
         default:
             break;
     }
@@ -432,10 +440,10 @@ mitsumi_cdrom_init(UNUSED(const device_t *info))
     dev = malloc(sizeof(mcd_t));
     memset(dev, 0x00, sizeof(mcd_t));
 
-    dev->irq = 5;
-    dev->dma = 5;
+    dev->irq = MCD_DEFAULT_IRQ;
+    dev->dma = MCD_DEFAULT_DMA;
 
-    io_sethandler(0x310, 2,
+    io_sethandler(MCD_DEFAULT_IOPORT, 3,
                   mitsumi_cdrom_in, NULL, NULL, mitsumi_cdrom_out, NULL, NULL, dev);
 
     mitsumi_cdrom_reset(dev);