From b80f43a9700dceea93c706225b60ebe789ccc914 Mon Sep 17 00:00:00 2001
From: Jasmine Iwanek <jasmine@iwanek.co.uk>
Date: Mon, 31 Jul 2023 17:30:17 -0400
Subject: [PATCH] sonarlint vid_sc1502x_ramdac.c

---
 src/video/vid_sc1502x_ramdac.c | 27 ++++++++++++++++++++-------
 1 file changed, 20 insertions(+), 7 deletions(-)

diff --git a/src/video/vid_sc1502x_ramdac.c b/src/video/vid_sc1502x_ramdac.c
index 3a3b3a863..babc2fc4b 100644
--- a/src/video/vid_sc1502x_ramdac.c
+++ b/src/video/vid_sc1502x_ramdac.c
@@ -29,17 +29,17 @@
 #include <86box/timer.h>
 #include <86box/video.h>
 #include <86box/vid_svga.h>
+#include <86box/plat_unused.h>
 
-typedef struct
-{
+typedef struct sc1502x_ramdac_t {
     int     state;
     uint8_t ctrl;
 } sc1502x_ramdac_t;
 
 void
-sc1502x_ramdac_out(uint16_t addr, uint8_t val, void *p, svga_t *svga)
+sc1502x_ramdac_out(uint16_t addr, uint8_t val, void *priv, svga_t *svga)
 {
-    sc1502x_ramdac_t *ramdac = (sc1502x_ramdac_t *) p;
+    sc1502x_ramdac_t *ramdac = (sc1502x_ramdac_t *) priv;
     int               oldbpp = 0;
 
     switch (addr) {
@@ -63,6 +63,9 @@ sc1502x_ramdac_out(uint16_t addr, uint8_t val, void *p, svga_t *svga)
                             case 0x20:
                                 svga->bpp = 24;
                                 break;
+
+                            default:
+                                break;
                         }
                         break;
                     case 4:
@@ -81,13 +84,17 @@ sc1502x_ramdac_out(uint16_t addr, uint8_t val, void *p, svga_t *svga)
                                 case 0x20:
                                     svga->bpp = 24;
                                     break;
+
+                                default:
+                                    break;
                             }
-                            break;
                         } else {
                             svga->bpp = 16;
-                            break;
                         }
                         break;
+
+                    default:
+                        break;
                 }
                 if (oldbpp != svga->bpp)
                     svga_recalctimings(svga);
@@ -100,6 +107,9 @@ sc1502x_ramdac_out(uint16_t addr, uint8_t val, void *p, svga_t *svga)
         case 0x3C9:
             ramdac->state = 0;
             break;
+
+        default:
+            break;
     }
 
     svga_out(addr, val, svga);
@@ -125,13 +135,16 @@ sc1502x_ramdac_in(uint16_t addr, void *p, svga_t *svga)
         case 0x3C9:
             ramdac->state = 0;
             break;
+
+        default:
+            break;
     }
 
     return temp;
 }
 
 static void *
-sc1502x_ramdac_init(const device_t *info)
+sc1502x_ramdac_init(UNUSED(const device_t *info))
 {
     sc1502x_ramdac_t *ramdac = (sc1502x_ramdac_t *) malloc(sizeof(sc1502x_ramdac_t));
     memset(ramdac, 0, sizeof(sc1502x_ramdac_t));