removed useless variables in NoteGroup
fixed the playstate countdown probably starting regardless of whether or not you actually wanted the game to skip the countdown
Even LESS Botplay Lag is no longer turned on by default (i think? idk maybe it's always been off by default but i just made sure)
Completely got rid of Emitter
added rewritten note recycling, but i wasnt really satisfied with it because of memory leaks. but i didn't want to get rid of it again so i just decided to make it an option
it's also adapted in the chart testing, so there
Note Splashes shouldn't be stuck on frame 1 any more if the config file doesn't have a Red animation int and you set the note color style to something other than "Normal"
TGT v4 and Dave Engine Score and Time Bar Styles now work properly
Attempted to make general performance a bit faster
Like, come on. Everyone cares about render mode, troll mode, and trying to load huge charts. I rewrote playstate because there were so much shit in it.
Jordan did fix my issue btw
Basically, if you played a slow song like Tutorial the notes would disappear for a bit every time a note would spawn unless you enabled "Use Wrong Note Sorting", this commit fixes that
Moved sustain notes down a bit
Added back OS Engine shaders
Removed Rainbow Notes as an option and instead made it one of the note color options
Added a bit of indentation to hopefully make things a little easier to read
This is a huge cleanup and breaking change!
@JordanSantiagoYT You can finish troll mode if you want because I did finish it mosty, but I didn't test it so it probably has some bugs that need fixed.
Also, I did rewrite the random botplay text stuff.
This ALSO removes stuff like gold ratings, marvelous judgement, and rainbow notes since they're all unnecessary in the engine anyway.
It also removes double note ghost stuff, the show notes option, colored notes, hardcoded noteskins, hardcoded hud's, and note rows as well.
I did keep shit gives miss, opponent nps, botplay txt fade, progressive audio loading, menu music type, and smooth health. (I did remove the smooth health type because it's basically potential bloat)
I also made it so that you only die when you have no health and missed. (Because I like that)
Also you don't need to change gameplay settings in the pause screen, that's removed aswell.
I did clean up client preferences because it was so messy that I had to remove options that are TOTALLY unneeded.
And then I removed most asset bloat.
New hey sound from https://www.youtube.com/watch?v=G5ZkOBybmIk
Also good news, lossless frame capturing for render mode now works!!! I had to fix some stuff in ``Screenshot.hx``!
And it introduces a new option: "Note Hit Offset Bug". You want to go back to the old days of psych engine spam songs where you lag horribly and the notes can't handle it due to how many popups are spawned? Enable this option!
Wow the gitVersion is old
using super awesome coding powers, THE NOTES ARE NOW HIT INSTANTANEOUSLY.
there's little performance improvement but it's a BIG visual improvement as notes won't lag behind or get stuck for a bit unlike before!
special thanks to codename engine
