From 1ecbaae622308b6dead1367790900fc49407da35 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Rapinat?= <romjerome@yahoo.fr>
Date: Mon, 2 Feb 2009 14:27:40 +0000
Subject: [PATCH] pylint and coherency on Repository references

svn: r11799
---
 src/plugins/quickview/References.py |  7 +--
 src/plugins/quickview/Reporef.py    | 75 +++++++++++++++++------------
 2 files changed, 47 insertions(+), 35 deletions(-)

diff --git a/src/plugins/quickview/References.py b/src/plugins/quickview/References.py
index 92b62d5f5..be67e92e7 100644
--- a/src/plugins/quickview/References.py
+++ b/src/plugins/quickview/References.py
@@ -24,7 +24,7 @@ Display references for any object
 """
 from ReportBase import (CATEGORY_QR_SOURCE, CATEGORY_QR_PERSON, 
                         CATEGORY_QR_FAMILY, CATEGORY_QR_EVENT, 
-                        CATEGORY_QR_PLACE, CATEGORY_QR_REPOSITORY)
+                        CATEGORY_QR_PLACE)
 
 from Simple import SimpleAccess, SimpleDoc, SimpleTable
 from gettext import gettext as _
@@ -32,7 +32,7 @@ from gen.plug import PluginManager
 
 # mention so that will be translated for below
 [_('Person'), _('Family'), _('Event'), _('Source'), 
- _('Place'), _('Repository')]
+ _('Place')]
 
 def get_ref(db, objclass, handle):
     """
@@ -48,8 +48,6 @@ def get_ref(db, objclass, handle):
         ref = db.get_source_from_handle(handle)
     elif objclass == 'Place':
         ref = db.get_place_from_handle(handle)
-    elif objclass == 'Repository':
-        ref = db.get_repository_from_handle(handle)
     else:
         ref = objclass
     return ref
@@ -91,7 +89,6 @@ refitems = [(CATEGORY_QR_PERSON, 'person', _("Person")),
             (CATEGORY_QR_EVENT, 'event', _("Event")), 
             (CATEGORY_QR_SOURCE, 'source', _("Source")), 
             (CATEGORY_QR_PLACE, 'place', _("Place")), 
-            (CATEGORY_QR_REPOSITORY, 'repository', _("Repository")), 
             ]
 pmgr = PluginManager.get_instance()
 
diff --git a/src/plugins/quickview/Reporef.py b/src/plugins/quickview/Reporef.py
index d7ace4aed..8b498221f 100755
--- a/src/plugins/quickview/Reporef.py
+++ b/src/plugins/quickview/Reporef.py
@@ -1,3 +1,5 @@
+#!/usr/bin/python
+# -*- coding: utf-8 -*-
 #
 # Gramps - a GTK+/GNOME based genealogy program
 #
@@ -19,58 +21,71 @@
 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 #
 
+# -------------------------------------------------------------------------
+#
+# gramps modules
+#
+# -------------------------------------------------------------------------
+
 """
 Display RepoRef for sources related to active repository
 """
 
-#-------------------------------------------------------------------------
-#
-# gramps modules
-#
-#-------------------------------------------------------------------------
-
-from Simple import SimpleAccess, SimpleDoc, SimpleTable
+from Simple import SimpleDoc
 from gettext import gettext as _
 from gen.plug import PluginManager
 from ReportBase import CATEGORY_QR_REPOSITORY
 import gen.lib
 
+
 def run(database, document, repo):
 
-    sa = SimpleAccess(database)
     sdoc = SimpleDoc(document)
+
     # First we find repository and add its text
-    sdoc.title("%s\n" % repo.get_name())
-    # Go over all the sources that refer to this repository                  
+
+    sdoc.title('%s\n' % repo.get_name())
+
+    # Go over all the sources that refer to this repository
+
     repo_handle = repo.handle
-    source_list = [item[1] for item in database.find_backlink_handles(repo_handle,['Source'])]
-    
-    for source_handle in source_list :
+    source_list = [item[1] for item in
+                   database.find_backlink_handles(repo_handle, ['Source'
+                   ])]
+
+    for source_handle in source_list:
         src = database.get_source_from_handle(source_handle)
-        # Get the list of references from this source to our repo
+
+        # Get the list of references from this source to our repo
         # (can be more than one, technically)
+
         for reporef in src.get_reporef_list():
             if reporef.ref == repo_handle:
-                # Determine the text for this source
-                mt = str(reporef.get_media_type())
-                cn = reporef.get_call_number()
-                sdoc.paragraph("%s, %s" % (mt, cn))
-                sdoc.paragraph("%s\n" % src.get_title())    
-            else:
-                continue 
 
-#------------------------------------------------------------------------
+                # Determine the text for this source
+
+                media = str(reporef.get_media_type())
+                call = reporef.get_call_number()
+                sdoc.paragraph('%s, %s' % (media, call))
+                sdoc.paragraph('%s\n' % src.get_title())
+            else:
+                continue
+
+
+# ------------------------------------------------------------------------
 #
 #
 #
-#------------------------------------------------------------------------
+# ------------------------------------------------------------------------
+
 pmgr = PluginManager.get_instance()
-         
+
 pmgr.register_quick_report(
-    name = 'RepoRef', 
-    category = CATEGORY_QR_REPOSITORY, 
-    run_func = run, 
-    translated_name = _("RepoRef"), 
-    status = _("Beta"), 
-    description= _("Display RepoRef for sources related to active repository"), 
+    name='RepoRef',
+    category=CATEGORY_QR_REPOSITORY,
+    run_func=run,
+    translated_name=_('RepoRef'),
+    status=_('Beta'),
+    description=_('Display RepoRef for sources related to active repository'
+                  ),
     )