Cyclone-Team/gramps
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use defaultdict type where possible for minor performance gain and source code simplification

Browse Source 
svn: r14011
This commit is contained in:
Gerald Britton
2010-01-09 19:54:32 +00:00
parent 4c7365dbcf
commit 2b12f3df07
7 changed files with 32 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/plugins/lib/libgedcom.py
View File

@ -93,6 +93,7 @@ import time
import codecs
from gettext import gettext as _
from xml.parsers.expat import ParserCreate
from collections import defaultdict
#------------------------------------------------------------------------
#
@ -5477,21 +5478,10 @@ class GedcomStageOne(object):
"""
return value and value[0] == '@'
@staticmethod
def __add_to_list(table, key, value):
"""
Add the value to the table entry associated with key. If the entry
does not exist, it is added.
"""
if key in table:
table[key].append(value)
else:
table[key] = [value]
def __init__(self, ifile):
self.ifile = ifile
self.famc = {}
self.fams = {}
self.famc = defaultdict(list)
self.fams = defaultdict(list)
self.enc = ""
self.pcnt = 0
self.lcnt = 0
@ -5551,9 +5541,9 @@ class GedcomStageOne(object):
self.pcnt += 1
elif key in ("HUSB", "HUSBAND", "WIFE") and \
self.__is_xref_value(value):
self.__add_to_list(self.fams, value[1:-1], current_family_id)
self.fams[value[1:-1]].append(current_family_id)
elif key in ("CHIL", "CHILD") and self.__is_xref_value(value):
self.__add_to_list(self.famc, value[1:-1], current_family_id)
self.famc[value[1:-1]].append(current_family_id)
elif key == 'CHAR' and not self.enc:
assert(isinstance(value, basestring))
self.enc = value