From 4bbae0e46a96b687b31825d510ad60be883a189b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre=20B=C3=A9lissent?= <pierre.belissent@gmail.com>
Date: Wed, 19 Aug 2015 20:24:40 +0200
Subject: [PATCH] Fix for "Environment variables in mediapath"

---
 gramps/gen/utils/file.py           |  1 +
 gramps/gen/utils/test/file_test.py | 26 ++++++++++++++++++++++++--
 2 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/gramps/gen/utils/file.py b/gramps/gen/utils/file.py
index f2ecb64ac..feb4b6c28 100644
--- a/gramps/gen/utils/file.py
+++ b/gramps/gen/utils/file.py
@@ -152,6 +152,7 @@ def expanded_vars_path(path):
     $GRAMPSHOME is set and restored afterwards,
     because undefined $GRAMPSHOME has a special meaning (see const.py).
     """
+    grampshome_added = False
     if not 'GRAMPSHOME' in os.environ:
         os.environ['GRAMPSHOME'] = USER_HOME
         grampshome_added = True
diff --git a/gramps/gen/utils/test/file_test.py b/gramps/gen/utils/test/file_test.py
index d6812b675..071938c2e 100644
--- a/gramps/gen/utils/test/file_test.py
+++ b/gramps/gen/utils/test/file_test.py
@@ -49,6 +49,7 @@ from gramps.version import VERSION
 class FileTest(unittest.TestCase):
 
     def test_mediapath(self):
+
         # Create database
         dbstate = DbState()
         db = dbstate.make_database("bsddb")
@@ -56,23 +57,44 @@ class FileTest(unittest.TestCase):
         db.write_version(path)
         db.load(path)
         dbstate.change_database(db)
+
         # Test without db.mediapath set
         self.assertEqual(media_path(db), os.path.normcase(os.path.normpath(os.path.abspath(USER_HOME))))
         self.assertTrue(os.path.exists(media_path(db)))
+
         # Test with absolute db.mediapath
         db.set_mediapath(os.path.abspath(USER_HOME) + "/test_abs")
         self.assertEqual(media_path(db), os.path.normcase(os.path.normpath(os.path.abspath(USER_HOME + "/test_abs"))))
+
         # Test with relative db.mediapath
         db.set_mediapath("test_rel")
         self.assertEqual(media_path(db), os.path.normcase(os.path.normpath(os.path.abspath(TEMP_DIR + "/utils_file_test/test_rel"))))
+
         # Test with environment variable
-        db.set_mediapath("$GRAMPSHOME/test_var")
-        self.assertEqual(media_path(db), os.path.normcase(os.path.normpath(os.path.abspath(USER_HOME + "/test_var"))))
         db.set_mediapath("/test/$GRAMPS_VERSION/test_var")
         self.assertEqual(media_path(db), os.path.normcase(os.path.normpath(os.path.abspath("/test/" + VERSION + "/test_var"))))
         db.set_mediapath("${GRAMPS_USER_PLUGINS}/test_var")
         self.assertEqual(media_path(db), os.path.normcase(os.path.normpath(os.path.abspath(USER_PLUGINS + "/test_var"))))
 
+        # Test with $GRAMPSHOME environment variable not set
+        grampshome = None
+        if 'GRAMPSHOME' in os.environ:
+            grampshome = os.environ['GRAMPSHOME']
+            del os.environ['GRAMPSHOME']
+        db.set_mediapath("$GRAMPSHOME/test_var")
+        self.assertEqual(media_path(db), os.path.normcase(os.path.normpath(os.path.abspath(USER_HOME + "/test_var"))))
+
+        # Test with $GRAMPSHOME environment variable set
+        os.environ['GRAMPSHOME'] = "/this/is/a/test"
+        db.set_mediapath("$GRAMPSHOME/test_var")
+        self.assertEqual(media_path(db), os.path.normcase(os.path.normpath(os.path.abspath("/this/is/a/test/test_var"))))
+
+        # Restore $GRAMPSHOME
+        if grampshome:
+            os.environ['GRAMPSHOME'] = grampshome
+        else:
+            del os.environ['GRAMPSHOME']
+
 
 #-------------------------------------------------------------------------
 #