8950 : Narrated: html elements emitted in different order with python 3 and date warning on windows

gramps/plugins/lib/libhtml.py

@@ -284,7 +284,7 @@ class Html(list):
 #       Keywords we don't recognize are saved for later
 #       addition to the opening tag as attributes.
 #
-        for keyw, arg in keywargs.items():
+        for keyw, arg in sorted(keywargs.items()):
             if (keyw in ['indent', 'close', 'inline'] and
                arg in [True, False, None]):
                 setattr(self, keyw, arg)

gramps/plugins/webreport/narrativeweb.py

@@ -3213,7 +3213,6 @@ class FamilyPages(BasePage):
 
         # add clearline for proper styling
         # add footer section
-        if ldatec == 0: date = None
         footer = self.write_footer(ldatec)
         body += (fullclear, footer)
 
@@ -3781,7 +3780,6 @@ class EventPages(BasePage):
 
         # add clearline for proper styling
         # add footer section
-        if ldatec == 0: ldatec = None
         footer = self.write_footer(ldatec)
         body += (fullclear, footer)
 
@@ -4048,7 +4046,7 @@ class SurnameListPage(BasePage):
 
         # send page out for processing
         # and close the file
-        self.XHTMLWriter(surnamelistpage, of, sio, None) # None => current date modification
+        self.XHTMLWriter(surnamelistpage, of, sio, 0) # 0 => current date modification
 
     def surname_link(self, fname, name, opt_val = None, up = False):
         url = self.report.build_url_fname_html(fname, "srn", up)
@@ -4063,7 +4061,7 @@ class IntroductionPage(BasePage):
     def __init__(self, report, title):
         self.dbase_ = report.database
         BasePage.__init__(self, report, title)
-        ldatec = None
+        ldatec = 0
 
         of, sio = self.report.create_file(report.intro_fname)
         intropage, head, body = self.write_header(_('Introduction'))
@@ -4100,7 +4098,7 @@ class HomePage(BasePage):
     def __init__(self, report, title):
         self.dbase_ = report.database
         BasePage.__init__(self, report, title)
-        ldatec = None
+        ldatec = 0
 
         of, sio = self.report.create_file("index")
         homepage, head, body = self.write_header(_('Home'))
@@ -4266,7 +4264,7 @@ class SourcePages(BasePage):
 
         # send page out for processing
         # and close the file
-        self.XHTMLWriter(sourcelistpage, of, sio, None)
+        self.XHTMLWriter(sourcelistpage, of, sio, 0)
 
     def SourcePage(self, report, title, source_handle):
         """
@@ -4292,7 +4290,7 @@ class SourcePages(BasePage):
         sourcepage, head, body = self.write_header("%s - %s" % (_('Sources'),
                                                    self.page_title))
 
-        ldatec = None
+        ldatec = 0
         # begin source detail division
         with Html("div", class_ = "content", id = "SourceDetail") as sourcedetail:
             body += sourcedetail
@@ -4495,7 +4493,6 @@ class MediaPages(BasePage):
 
         # add footer section
         # add clearline for proper styling
-        if ldatec == 0: ldatec = None
         footer = self.write_footer(ldatec)
         body += (fullclear, footer)
 
@@ -4950,7 +4947,7 @@ class ThumbnailPreviewPage(BasePage):
 
         # send page out for processing
         # and close the file
-        self.XHTMLWriter(thumbnailpage, of, sio, None)
+        self.XHTMLWriter(thumbnailpage, of, sio, 0)
 
 
     def thumbnail_link(self, name, index):
@@ -5101,7 +5098,7 @@ class DownloadPage(BasePage):
 
             # send page out for processing
             # and close the file
-            self.XHTMLWriter(downloadpage, of, sio, None)
+            self.XHTMLWriter(downloadpage, of, sio, 0)
 
 
 class ContactPage(BasePage):
@@ -5168,7 +5165,7 @@ class ContactPage(BasePage):
 
         # send page out for porcessing
         # and close the file
-        self.XHTMLWriter(contactpage, of, sio, None)
+        self.XHTMLWriter(contactpage, of, sio, 0)
 
 #################################################
 #
@@ -5412,7 +5409,6 @@ class PersonPages(BasePage):
 
         # create clear line for proper styling
         # create footer section
-        if date == 0: date = None
         footer = self.write_footer(date)
         body += (fullclear, footer)
 
@@ -5857,7 +5853,7 @@ class PersonPages(BasePage):
 
         # send page out for processing
         # and close the file
-        self.XHTMLWriter(familymappage, of, sio, None)
+        self.XHTMLWriter(familymappage, of, sio, 0)
 
     def __display_family_map(self, person, place_lat_long):
         """
@@ -6681,7 +6677,6 @@ class RepositoryPages(BasePage):
 
         # add clearline for proper styling
         # add footer section
-        if ldatec == 0: ldatec = None
         footer = self.write_footer(ldatec)
         body += (fullclear, footer)
 
@@ -6845,7 +6840,7 @@ class AddressBookListPage(BasePage):
 
         # send the page out for processing
         # and close the file
-        self.XHTMLWriter(addressbooklistpage, of, sio, None)
+        self.XHTMLWriter(addressbooklistpage, of, sio, 0)
 
 class AddressBookPage(BasePage):
     def __init__(self, report, title, person_handle, has_add, has_res, has_url):
@@ -6889,7 +6884,7 @@ class AddressBookPage(BasePage):
 
         # send page out for processing
         # and close the file
-        self.XHTMLWriter(addressbookpage, of, sio, None)
+        self.XHTMLWriter(addressbookpage, of, sio, 0)
 
 class NavWebReport(Report):
 
@@ -7964,7 +7959,7 @@ class NavWebReport(Report):
             of.close()
         else:
             of.close()
-            if date is not None:
+            if date > 0:
                 os.utime(of.name, (date, date))
 
     def prepare_copy_media(self, photo):