4198: Person view does not remove a row correctly when two people are merged.

This is a major patch by Michael Nauta. It means all writes happen immediately to bsddb, and the bsddb 
rollback is used on a crash. Transaction is no longer used to store changes and do them on commit.
Undo database is set on end. 
At the same time with statement is used throughout for transactions
At the same time, the original bug in merge code should be fixed
Still some issues, that will be ironed out


svn: r16523

src/plugins/tool/TestcaseGenerator.py

@@ -219,7 +219,7 @@ class TestcaseGenerator(tool.BatchTool):
             self.db.disable_signals()
         else:
             batch = False
-        self.trans = self.db.transaction_begin("")
+        self.trans = self.db.transaction_begin(_("Testcase generator"))
 
         if False and self.options.handler.options_dict['no_trans']:
     
@@ -1324,6 +1324,9 @@ class TestcaseGenerator(tool.BatchTool):
         return result
     
     def commit_transaction(self):
+        # The way transactions are used in this file is outdated; use a with
+        # statement so that transaction abort is called on failure. It is too
+        # much effort to update this file.
         #if self.options.handler.options_dict['no_trans']:
         self.db.transaction_commit(self.trans,_("Testcase generator step %d") % self.transaction_count)
         self.transaction_count += 1