Cyclone-Team/gramps
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use built-in functions to replace for loops:

Browse Source 
Old code:

for x in y:
  f(x)

New Code:

map(f, y)

Also use defaultdict instead of simple dict when advantageous and use list comprehensions
instead of for loops where map() could be used but requires lambdas.


svn: r14135
This commit is contained in:
Gerald Britton
2010-01-25 17:45:21 +00:00
parent fbb8fa2a52
commit 8f0582df8a
49 changed files with 125 additions and 188 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/gui/views/listview.py
View File

@ -207,8 +207,7 @@ class ListView(NavigationView):
callback=self.filter_toggle_action)
def build_columns(self):
for column in self.columns:
self.list.remove_column(column)
map(self.list.remove_column, self.columns)
self.columns = []
@ -669,8 +668,7 @@ class ListView(NavigationView):
if self.active or \
(not self.dirty and not self._dirty_on_change_inactive):
cput = time.clock()
for handle in handle_list:
self.model.add_row_by_handle(handle)
map(self.model.add_row_by_handle, handle_list)
_LOG.debug(' ' + self.__class__.__name__ + ' row_add ' +
str(time.clock() - cput) + ' sec')
if self.active:
@ -689,8 +687,7 @@ class ListView(NavigationView):
if self.active or \
(not self.dirty and not self._dirty_on_change_inactive):
cput = time.clock()
for handle in handle_list:
self.model.update_row_by_handle(handle)
map(self.model.update_row_by_handle, handle_list)
_LOG.debug(' ' + self.__class__.__name__ + ' row_update ' +
str(time.clock() - cput) + ' sec')
# Ensure row is still selected after a change of postion in tree.