From 9747d1deeabcae714680d4f08b51b15c0b1ede91 Mon Sep 17 00:00:00 2001
From: Nick Hall <nick-h@gramps-project.org>
Date: Sat, 13 Jun 2015 18:43:50 +0100
Subject: [PATCH] Validate place name language

---
 gramps/gui/editors/editplacename.py  | 44 ++++++++++++++++++++++++++++
 gramps/gui/glade/editplacename.glade | 28 ++++++++----------
 2 files changed, 57 insertions(+), 15 deletions(-)

diff --git a/gramps/gui/editors/editplacename.py b/gramps/gui/editors/editplacename.py
index 0c184192c..70468c7b0 100644
--- a/gramps/gui/editors/editplacename.py
+++ b/gramps/gui/editors/editplacename.py
@@ -35,9 +35,46 @@ from .editsecondary import EditSecondary
 from ..glade import Glade
 from ..widgets import MonitoredDate, MonitoredEntry
 from ..dialog import ErrorDialog
+from gramps.gen.errors import ValidationError
 from gramps.gen.const import GRAMPS_LOCALE as glocale
 _ = glocale.translation.gettext
 
+#-------------------------------------------------------------------------
+#
+# Constants
+#
+#-------------------------------------------------------------------------
+ISO_CODES = (
+'aa', 'ab', 'ae', 'af', 'ak', 'am', 'an', 'ar', 'as', 'av', 'ay', 'az',
+'ba', 'be', 'bg', 'bh', 'bi', 'bm', 'bn', 'bo', 'br', 'bs',
+'ca', 'ce', 'ch', 'co', 'cr', 'cs', 'cu', 'cv', 'cy',
+'da', 'de', 'dv', 'dz',
+'ee', 'el', 'en', 'eo', 'es', 'et', 'eu',
+'fa', 'ff', 'fi', 'fj', 'fo', 'fr', 'fy',
+'ga', 'gd', 'gl', 'gn', 'gu', 'gv',
+'ha', 'he', 'hi', 'ho', 'hr', 'ht', 'hu', 'hy', 'hz',
+'ia', 'id', 'ie', 'ig', 'ii', 'ik', 'io', 'is', 'it', 'iu',
+'ja', 'jv',
+'ka', 'kg', 'ki', 'kj', 'kk', 'kl', 'km', 'kn', 'ko', 'kr', 'ks', 'ku', 'kv',
+'kw', 'ky',
+'la', 'lb', 'lg', 'li', 'ln', 'lo', 'lt', 'lu', 'lv',
+'mg', 'mh', 'mi', 'mk', 'ml', 'mn', 'mr', 'ms', 'mt', 'my',
+'na', 'nb', 'nd', 'ne', 'ng', 'nl', 'nn', 'no', 'nr', 'nv', 'ny',
+'oc', 'oj', 'om', 'or', 'os',
+'pa', 'pi', 'pl', 'ps', 'pt',
+'qu',
+'rm', 'rn', 'ro', 'ru', 'rw',
+'sa', 'sc', 'sd', 'se', 'sg', 'si', 'sk', 'sl', 'sm', 'sn', 'so', 'sq', 'sr',
+'ss', 'st', 'su', 'sv', 'sw',
+'ta', 'te', 'tg', 'th', 'ti', 'tk', 'tl', 'tn', 'to', 'tr', 'ts', 'tt', 'tw',
+'ty',
+'ug', 'uk', 'ur', 'uz',
+'ve', 'vi', 'vo',
+'wa', 'wo',
+'xh',
+'yi', 'yo',
+'za', 'zh', 'zu')
+
 #-------------------------------------------------------------------------
 #
 # EditPlaceName class
@@ -75,6 +112,13 @@ class EditPlaceName(EditSecondary):
         self.language = MonitoredEntry(
             self.top.get_object("language"), self.obj.set_language,
             self.obj.get_language, self.db.readonly)
+        self.language.connect("validate", self._validate_iso_code)
+        #force validation now with initial entry
+        self.top.get_object("language").validate(force=True)
+
+    def _validate_iso_code(self, widget, text):
+        if text not in ISO_CODES:
+            return ValidationError(_("Invalid ISO code"))
 
     def _connect_signals(self):
         self.define_help_button(self.top.get_object('help'))
diff --git a/gramps/gui/glade/editplacename.glade b/gramps/gui/glade/editplacename.glade
index bf2e9e996..8b012d0b3 100644
--- a/gramps/gui/glade/editplacename.glade
+++ b/gramps/gui/glade/editplacename.glade
@@ -108,26 +108,12 @@
                     <property name="label" translatable="yes">Language:</property>
                     <property name="use_underline">True</property>
                     <property name="justify">center</property>
-                    <property name="mnemonic_widget">language</property>
                   </object>
                   <packing>
                     <property name="left_attach">0</property>
                     <property name="top_attach">2</property>
                   </packing>
                 </child>
-                <child>
-                  <object class="UndoableEntry" id="language">
-                    <property name="visible">True</property>
-                    <property name="can_focus">True</property>
-                    <property name="tooltip_text" translatable="yes">Language in which the name is written.</property>
-                    <property name="hexpand">True</property>
-                    <property name="invisible_char">●</property>
-                  </object>
-                  <packing>
-                    <property name="left_attach">1</property>
-                    <property name="top_attach">2</property>
-                  </packing>
-                </child>
                 <child>
                   <object class="GtkButton" id="date_stat">
                     <property name="visible">True</property>
@@ -197,13 +183,25 @@
                     <property name="label" translatable="yes">Name:</property>
                     <property name="use_underline">True</property>
                     <property name="justify">center</property>
-                    <property name="mnemonic_widget">language</property>
                   </object>
                   <packing>
                     <property name="left_attach">0</property>
                     <property name="top_attach">0</property>
                   </packing>
                 </child>
+                <child>
+                  <object class="ValidatableMaskedEntry" id="language">
+                    <property name="visible">True</property>
+                    <property name="can_focus">True</property>
+                    <property name="tooltip_text" translatable="yes">Language in which the name is written. Valid values are two character ISO codes. For example:  en, fr, de, nl ...</property>
+                    <property name="hexpand">True</property>
+                    <property name="invisible_char">●</property>
+                  </object>
+                  <packing>
+                    <property name="left_attach">1</property>
+                    <property name="top_attach">2</property>
+                  </packing>
+                </child>
                 <child>
                   <placeholder/>
                 </child>