Added title attribute to all media objects for better readability by screen readers and braille writers, Jaws(c) by http://www.freedomscientific.com/, for example.

svn: r15268
This commit is contained in:
Rob G. Healey 2010-04-22 13:56:16 +00:00
parent f3a661920a
commit ea23f135bd

View File

@ -1170,7 +1170,8 @@ class BasePage(object):
img_attr = '' img_attr = ''
if height: if height:
img_attr += 'height = "%d"' % height img_attr += 'height = "%d"' % height
img_attr += ' src = "%s" alt = "%s"' % (newpath, obj.get_description()) img_attr += ' src = "%s" alt = "%s" title = "%s"' % (newpath, obj.get_description(),
obj.get_description() )
# add image attributes to image # add image attributes to image
image.attr = img_attr image.attr = img_attr
@ -1703,7 +1704,8 @@ class BasePage(object):
# 2. insert thumbnail if there is one, otherwise insert class = "noThumb" # 2. insert thumbnail if there is one, otherwise insert class = "noThumb"
if thumbnailUrl: if thumbnailUrl:
hyper += (Html("span", class_ = "thumbnail") + hyper += (Html("span", class_ = "thumbnail") +
Html("img", src = thumbnailUrl, alt = "Image of " + person_name) Html("img", src = thumbnailUrl, alt = "Image of " + person_name,
title = "Image of " + person_name)
) )
else: else:
hyper.attr += ' class= "noThumb"' hyper.attr += ' class= "noThumb"'
@ -1751,7 +1753,7 @@ class BasePage(object):
thumbnail += hyper thumbnail += hyper
url = self.report.build_url_image("document.png", "images", up) url = self.report.build_url_image("document.png", "images", up)
hyper += Html("img", src = url, alt = html_escape(name)) hyper += Html("img", src = url, alt = html_escape(name), title = html_escape(name))
if usedescr: if usedescr:
hyper += Html("p", html_escape(name), inline = True) hyper += Html("p", html_escape(name), inline = True)
@ -2786,7 +2788,7 @@ class MediaPage(BasePage):
mediadisplay += Html("a", href = url) + ( mediadisplay += Html("a", href = url) + (
Html("img", width = new_width, Html("img", width = new_width,
height = new_height, src = url, height = new_height, src = url,
alt=html_escape(self.page_title)) alt = html_escape(self.page_title), title = html_escape(self.page_title))
) )
else: else:
dirname = tempfile.mkdtemp() dirname = tempfile.mkdtemp()
@ -2813,7 +2815,7 @@ class MediaPage(BasePage):
if target_exists: if target_exists:
# TODO. Convert disk path to URL # TODO. Convert disk path to URL
url = self.report.build_url_fname(newpath, None, self.up) url = self.report.build_url_fname(newpath, None, self.up)
hyper = Html("a", href = url) + ( hyper = Html("a", href = url, title = html_escape(self.page_title)) + (
Html("img", src = img_url, alt = html_escape(self.page_title)) Html("img", src = img_url, alt = html_escape(self.page_title))
) )
mediadisplay += hyper mediadisplay += hyper
@ -2823,7 +2825,8 @@ class MediaPage(BasePage):
with Html("div", id = "GalleryDisplay") as mediadisplay: with Html("div", id = "GalleryDisplay") as mediadisplay:
summaryarea += mediadisplay summaryarea += mediadisplay
url = self.report.build_url_image("document.png", "images", self.up) url = self.report.build_url_image("document.png", "images", self.up)
mediadisplay += Html("img", src = url, alt = html_escape(self.page_title)) mediadisplay += Html("img", src = url, alt = html_escape(self.page_title),
title = html_escape(self.page_title))
# media title # media title
title = Html("h3", html_escape(self.page_title.strip()), inline = True) title = Html("h3", html_escape(self.page_title.strip()), inline = True)