Tidy up some comments

svn: r18497
This commit is contained in:
Tim G L Lyons 2011-11-24 14:54:29 +00:00
parent 14954cdd91
commit f0bb1205f3
14 changed files with 20 additions and 11 deletions

View File

@ -3,6 +3,7 @@
#
# Copyright (C) 2007 B. Malengier
# Copyright (C) 2008 Brian G. Matherly
# Copyright (C) 2011 Tim G Lyons
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by

View File

@ -2,6 +2,7 @@
# Gramps - a GTK+/GNOME based genealogy program
#
# Copyright (C) 2000-2007 Donald N. Allingham
# Copyright (C) 2011 Tim G Lyons
#
# This program is free software; you can redistribute it and/or modiy
# it under the terms of the GNU General Public License as published by
@ -142,15 +143,6 @@ def obj2target(target):
}
return d[target] if target in d else None
# FIXME: CITATION: Dropping a citation onto an embedded tab should open
# CitationEdit. However, note should behave similarly, and although there is
# code to call EditNote, EditNote does not appear to be called. I don't
# understand how to get the editor called.
# FIXME: CITATION: It should be possible to drop a source onto an embedded tab,
# with CitationEdit being opened, However, It is not possible to do the drop,
# and as described above I do not understand how to get the editor called.
def model_contains(model, data):
"""
Returns True if data is a row in model.

View File

@ -3,6 +3,7 @@
#
# Copyright (C) 2007 Donald N. Allingham
# Copyright (C) 2010 Jakim Friant
# Copyright (C) 2011 Tim G Lyons
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by

View File

@ -3,6 +3,7 @@
#
# Copyright (C) 2008 Donald N. Allingham
# Copyright (C) 2009 Douglas S. Blank
# Copyright (C) 2011 Tim G Lyons
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by

View File

@ -89,7 +89,7 @@ class MediaRef(SecondaryObject, PrivacyBase, CitationBase, NoteBase, RefBase,
:returns: Returns the list of child objects that may carry textual data.
:rtype: list
"""
return self.attribute_list # + self.source_list
return self.attribute_list
def get_citation_child_list(self):
"""

View File

@ -3,6 +3,7 @@
#
# Copyright (C) 2008 Brian G. Matherly
# Copyright (C) 2010 Jakim Friant
# Copyright (C) 2011 Tim G Lyons
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by

View File

@ -2,6 +2,7 @@
# Gramps - a GTK+/GNOME based genealogy program
#
# Copyright (C) 2009 Benny Malengier
# Copyright (C) 2011 Tim G Lyons
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by

View File

@ -381,6 +381,9 @@ class EditCitation(EditPrimary):
def save(self, *obj):
"""Save the data."""
self.ok_button.set_sensitive(False)
# FIXME: CITATION: It should be possible to save a citation even when
# there is no data in it. On the other hand, it should not be possible
# to save a source that has no data.
if self.object_is_empty():
ErrorDialog(_("Cannot save citation"),
_("No data exists for this citation. Please "
@ -388,6 +391,8 @@ class EditCitation(EditPrimary):
self.ok_button.set_sensitive(True)
return
# FIXME: CITATION: Not only citations, but also sources should be
# checked for duplicate Gramps IDs.
(uses_dupe_id, gramps_id) = self._uses_duplicate_id()
if uses_dupe_id:
prim_object = self.get_from_gramps_id(gramps_id)
@ -439,7 +444,8 @@ class EditCitation(EditPrimary):
entered date when importing from a XML file, so we can get an
incorrect fail.
"""
# FIXME: CITATION: This should check whether either the citation data or
# the source data has changed.
if self.db.readonly:
return False
elif self.obj.handle:

View File

@ -7,6 +7,7 @@
# Copyright (C) 2008 Robert Cheramy <robert@cheramy.net>
# Copyright (C) 2010 Jakim Friant
# Copyright (C) 2010 Nick Hall
# Copyright (C) 2011 Tim G Lyons
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by

View File

@ -1,6 +1,7 @@
# Gramps - a GTK+/GNOME based genealogy program
#
# Copyright (C) 2007-2009 Douglas S. Blank <doug.blank@gmail.com>
# Copyright (C) 2011 Tim G Lyons
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by

View File

@ -2,6 +2,7 @@
# Gramps - a GTK+/GNOME based genealogy program
#
# Copyright (C) 2000-2006 Donald N. Allingham
# Copyright (C) 2011 Tim G Lyons
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by

View File

@ -3,6 +3,7 @@
#
# Copyright (C) 2000-2007 Donald N. Allingham
# Copyright (C) 2007-2008 Brian G. Matherly
# Copyright (C) 2011 Tim G Lyons
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by

View File

@ -2,6 +2,7 @@
# Gramps - a GTK+/GNOME based genealogy program
#
# Copyright (C) 2009 Benny Malengier
# Copyright (C) 2011 Tim G Lyons
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by

View File

@ -4,6 +4,7 @@
# Copyright (C) 2000-2007 Donald N. Allingham
# Copyright (C) 2008 Brian G. Matherly
# Copyright (C) 2010 Jakim Friant
# Copyright (C) 2011 Tim G Lyons
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by