From f1f1f7cbbe9253732b283c304843b9a3a4e87693 Mon Sep 17 00:00:00 2001 From: Benny Malengier Date: Tue, 11 Sep 2012 09:28:55 +0000 Subject: [PATCH] 5992: Crash when using a not allowed string as regex in Person with name filter svn: r20364 --- src/Filters/Rules/Person/_HasNameOf.py | 56 +++++++++++++------------ src/Filters/Rules/Person/_RegExpName.py | 3 +- 2 files changed, 32 insertions(+), 27 deletions(-) diff --git a/src/Filters/Rules/Person/_HasNameOf.py b/src/Filters/Rules/Person/_HasNameOf.py index 5d0917203..c1ee02bbb 100644 --- a/src/Filters/Rules/Person/_HasNameOf.py +++ b/src/Filters/Rules/Person/_HasNameOf.py @@ -95,32 +95,36 @@ class HasNameOf(Rule): if not self.patr: valpatr = 1 if self.regular_expression: - if self.firstn and not re.match(self.firstn, name.get_first_name(), re.I|re.U|re.L): - val = 0 - elif self.lastn and not re.match(self.lastn, name.get_surname(), re.I|re.U|re.L): - val = 0 - elif self.suffix and not re.match(self.suffix, name.get_suffix(), re.I|re.U|re.L): - val = 0 - elif self.title and not re.match(self.title, name.get_title(), re.I|re.U|re.L): - val = 0 - elif self.calln and not re.match(self.calln, name.get_call_name(), re.I|re.U|re.L): - val = 0 - elif self.nick and not re.match(self.nick, name.get_nick_name(), re.I|re.U|re.L): - val = 0 - elif self.famnick and not re.match(self.famnick, name.get_family_nick_name(), re.I|re.U|re.L): - val = 0 - else: - #obtain surnames - for surn in name.get_surname_list(): - if self.prefix and re.match(self.prefix, surn.get_prefix(), re.I|re.U|re.L): - valpref = 1 - if self.surn and re.match(self.surn, surn.get_surname(), re.I|re.U|re.L): - valsurn = 1 - if self.con and re.match(self.con, surn.get_connector(), re.I|re.U|re.L): - valcon = 1 - if self.patr and surn.get_origintype().value == NameOriginType.PATRONYMIC \ - and re.match(self.patr, surn.get_surname(), re.I|re.U|re.L): - valpatr = 1 + try: + if self.firstn and not re.match(self.firstn, name.get_first_name(), re.I|re.U|re.L): + val = 0 + elif self.lastn and not re.match(self.lastn, name.get_surname(), re.I|re.U|re.L): + val = 0 + elif self.suffix and not re.match(self.suffix, name.get_suffix(), re.I|re.U|re.L): + val = 0 + elif self.title and not re.match(self.title, name.get_title(), re.I|re.U|re.L): + val = 0 + elif self.calln and not re.match(self.calln, name.get_call_name(), re.I|re.U|re.L): + val = 0 + elif self.nick and not re.match(self.nick, name.get_nick_name(), re.I|re.U|re.L): + val = 0 + elif self.famnick and not re.match(self.famnick, name.get_family_nick_name(), re.I|re.U|re.L): + val = 0 + else: + #obtain surnames + for surn in name.get_surname_list(): + if self.prefix and re.match(self.prefix, surn.get_prefix(), re.I|re.U|re.L): + valpref = 1 + if self.surn and re.match(self.surn, surn.get_surname(), re.I|re.U|re.L): + valsurn = 1 + if self.con and re.match(self.con, surn.get_connector(), re.I|re.U|re.L): + valcon = 1 + if self.patr and surn.get_origintype().value == NameOriginType.PATRONYMIC \ + and re.match(self.patr, surn.get_surname(), re.I|re.U|re.L): + valpatr = 1 + except re.error: + #indicate error in the pattern by matching everyone + return True else: if self.firstn and name.get_first_name().upper().find(self.firstn) == -1: val = 0 diff --git a/src/Filters/Rules/Person/_RegExpName.py b/src/Filters/Rules/Person/_RegExpName.py index 226c61e5b..e750e4070 100644 --- a/src/Filters/Rules/Person/_RegExpName.py +++ b/src/Filters/Rules/Person/_RegExpName.py @@ -54,7 +54,8 @@ class RegExpName(Rule): try: self.match = re.compile(list[0],re.I|re.U|re.L) - except: + except re.error: + #indicate error by matching everyone self.match = re.compile('') def apply(self,db,person):