Cyclone-Team/gramps
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix the Preferences 'Age display precision' value getting lost (#940)

Browse Source 
Fixes #11384

It turns out the changes was actually changing the wrong config setting...

I had to look this one up. Using a lambda like this is called a 'closure' by some; what is happening is that the value 'constant' is being evaluated at the time the lambda is called, not when it is assigned. So in this particular bit of code the preference setting was actually changing 'preferences.family-relation-type' (the value of the variable 'constant' set a bit after the lambda definition.

I reverted this particular bit of code, as I think this kind of Python knowledge is pretty obscure (I could have just used a different unique name for the 'constant' variable).
This commit is contained in:
Paul Culley 2019-10-29 17:17:06 -05:00 committed by Sam Manzi
parent 06cca96ad0
commit fb29a77f83
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gramps/gui/configure.py
View File

@ -1256,14 +1256,15 @@ class GrampsPreferences(ConfigureDialog):
_("Years, Months, Days")] _("Years, Months, Days")]
list(map(obox.append_text, age_precision)) list(map(obox.append_text, age_precision))
# Combo_box active index is from 0 to 2, we need values from 1 to 3 # Combo_box active index is from 0 to 2, we need values from 1 to 3
constant = 'preferences.age-display-precision' active = config.get('preferences.age-display-precision') - 1
active = config.get(constant) - 1
if active >= 0 and active <= 2: if active >= 0 and active <= 2:
obox.set_active(active) obox.set_active(active)
else: else:
obox.set_active(0) obox.set_active(0)
obox.connect('changed', obox.connect(
lambda obj: config.set(constant, obj.get_active() + 1)) 'changed',
lambda obj: config.set('preferences.age-display-precision',
obj.get_active() + 1))
lwidget = BasicLabel(_("%s: ") lwidget = BasicLabel(_("%s: ")
% _('Age display precision (requires restart)')) % _('Age display precision (requires restart)'))
grid.attach(lwidget, 0, row, 1, 1) grid.attach(lwidget, 0, row, 1, 1)
@ -1300,10 +1301,10 @@ class GrampsPreferences(ConfigureDialog):
obox = Gtk.ComboBoxText() obox = Gtk.ComboBoxText()
formats = FamilyRelType().get_standard_names() formats = FamilyRelType().get_standard_names()
list(map(obox.append_text, formats)) list(map(obox.append_text, formats))
constant = 'preferences.family-relation-type' obox.set_active(config.get('preferences.family-relation-type'))
obox.set_active(config.get(constant))
obox.connect('changed', obox.connect('changed',
lambda obj: config.set(constant, obj.get_active())) lambda obj: config.set('preferences.family-relation-type',
obj.get_active()))
lwidget = BasicLabel(_("%s: ") % _('Default family relationship')) lwidget = BasicLabel(_("%s: ") % _('Default family relationship'))
grid.attach(lwidget, 0, row, 1, 1) grid.attach(lwidget, 0, row, 1, 1)
grid.attach(obox, 1, row, 2, 1) grid.attach(obox, 1, row, 2, 1)