Cyclone-Team/gramps
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

8555: Database repair tool always modify all source objects

Browse Source
This commit is contained in:
romjerome 2016-11-26 12:54:08 +01:00
parent 4af6dd88c2
commit fe18eab251
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gramps/plugins/tool/check.py
View File

@ -1897,6 +1897,7 @@ class CheckIntegrity(object):
source = Source() source = Source()
source.unserialize(info) source.unserialize(info)
new_media_ref_list = [] new_media_ref_list = []
citation_changed = False
for media_ref in source.get_media_list(): for media_ref in source.get_media_list():
citation_list = media_ref.get_citation_list() citation_list = media_ref.get_citation_list()
new_citation_list = [] new_citation_list = []
@ -1919,6 +1920,7 @@ class CheckIntegrity(object):
citation_handle = create_id() citation_handle = create_id()
new_citation.set_handle(citation_handle) new_citation.set_handle(citation_handle)
self.replaced_sourceref.append(handle) self.replaced_sourceref.append(handle)
citation_changed = True
logging.warning(' FAIL: the source "%s" has a media ' logging.warning(' FAIL: the source "%s" has a media '
'reference with a source citation ' 'reference with a source citation '
'which is invalid' % (source.gramps_id)) 'which is invalid' % (source.gramps_id))
@ -1928,9 +1930,10 @@ class CheckIntegrity(object):
media_ref.set_citation_list(new_citation_list) media_ref.set_citation_list(new_citation_list)
new_media_ref_list.append(media_ref) new_media_ref_list.append(media_ref)
source.set_media_list(new_media_ref_list) if citation_changed:
self.db.commit_source(source, self.trans) source.set_media_list(new_media_ref_list)
self.db.commit_source(source, self.trans)
if len(self.replaced_sourceref) > 0: if len(self.replaced_sourceref) > 0:
logging.info(' OK: no broken source citations on mediarefs found') logging.info(' OK: no broken source citations on mediarefs found')