ElyBy-Mirror/accounts-frontend
1
0
Fork 0
mirror of https://github.com/elyby/accounts-frontend.git synced 2024-12-28 07:50:32 +05:30
Code Issues Packages Projects Releases Wiki Activity

#22: fix set state warnings in Form.js

Browse Source
This commit is contained in:
SleepWalker 2018-05-07 22:23:26 +03:00
parent c454c58d5c
commit 64cb197756
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/components/ui/form/Form.js
View File

@ -38,10 +38,14 @@ export default class Form extends Component<Props, State> {
formEl: ?HTMLFormElement; formEl: ?HTMLFormElement;
componentWillMount() { mounted = false;
componentDidMount() {
if (this.props.form) { if (this.props.form) {
this.props.form.addLoadingListener(this.onLoading); this.props.form.addLoadingListener(this.onLoading);
} }
this.mounted = true;
} }
componentWillReceiveProps(nextProps: Props) { componentWillReceiveProps(nextProps: Props) {
@ -73,6 +77,8 @@ export default class Form extends Component<Props, State> {
if (this.props.form) { if (this.props.form) {
this.props.form.removeLoadingListener(this.onLoading); this.props.form.removeLoadingListener(this.onLoading);
} }
this.mounted = false;
} }
render() { render() {
@ -119,7 +125,9 @@ export default class Form extends Component<Props, State> {
result.catch((errors: {[key: string]: string}) => { result.catch((errors: {[key: string]: string}) => {
this.setErrors(errors); this.setErrors(errors);
}).finally(() => this.setState({isLoading: false})); }).finally(() =>
this.mounted && this.setState({isLoading: false})
);
} }
} else { } else {
const invalidEls = form.querySelectorAll(':invalid'); const invalidEls = form.querySelectorAll(':invalid');