ElyBy-Mirror/accounts-frontend
1
0
Fork 0
mirror of https://github.com/elyby/accounts-frontend.git synced 2024-12-28 07:50:32 +05:30
Code Issues Packages Projects Releases Wiki Activity

#389: fix react warning about setState on unmounted component

Browse Source
This commit is contained in:
SleepWalker 2018-02-12 22:20:53 +02:00
parent bd31aa1ebf
commit e91bb09c33
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/components/auth/PanelTransition.js
View File

@ -109,6 +109,8 @@ class PanelTransition extends Component {
panelId: this.props.Body && this.props.Body.type.panelId panelId: this.props.Body && this.props.Body.type.panelId
}; };
timerIds = []; // this is a list of a probably running timeouts to clean on unmount
getChildContext() { getChildContext() {
return { return {
auth: this.props.auth, auth: this.props.auth,
@ -121,7 +123,9 @@ class PanelTransition extends Component {
this.setState({isHeightDirty: false}); this.setState({isHeightDirty: false});
// wait till transition end // wait till transition end
setTimeout(resolve, 200); this.timerIds.push(
setTimeout(resolve, 200)
);
} }
) )
), ),
@ -148,13 +152,20 @@ class PanelTransition extends Component {
}); });
if (forceHeight) { if (forceHeight) {
setTimeout(() => { this.timerIds.push(
this.setState({forceHeight: 0}); setTimeout(() => {
}, 100); this.setState({forceHeight: 0});
}, 100)
);
} }
} }
} }
componentWillUnmount() {
this.timerIds.forEach((id) => clearTimeout(id));
this.timerIds = [];
}
render() { render() {
const {contextHeight, forceHeight} = this.state; const {contextHeight, forceHeight} = this.state;