ElyBy-Mirror/accounts
1
0
Fork 0
mirror of https://github.com/elyby/accounts.git synced 2025-05-31 14:11:46 +05:30
Code Issues Packages Projects Releases Wiki Activity

Upgrade project to PHP 8.3, add PHPStan, upgrade almost every dependency (#36)

Browse Source 
* start updating to PHP 8.3

* taking off!

Co-authored-by: ErickSkrauch <erickskrauch@yandex.ru>
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>

* dropped this

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>

* migrate to symfonymailer

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>

* this is so stupid 😭

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>

* ah, free, at last.

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>

* oh, Gabriel.

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>

* now dawns thy reckoning.

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>

* and thy gore shall GLISTEN before the temples of man.

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>

* creature of steel.

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>

* my gratitude upon thee for my freedom.

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>

* but the crimes thy kind has committed against humanity

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>

* Upgrade PHP-CS-Fixer and do fix the codebase

* First review round (maybe I have broken something)

* are NOT forgotten.

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>

* Enable parallel PHP-CS-Fixer runner

* PHPStan level 1

* PHPStan level 2

* PHPStan level 3

* PHPStan level 4

* PHPStan level 5

* Levels 6 and 7 takes too much effort. Generate a baseline and fix them eventually

* Resolve TODO's related to the php-mock

* Drastically reduce baseline size with the Rector

* More code modernization with help of the Rector

* Update GitLab CI

---------

Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
Co-authored-by: ErickSkrauch <erickskrauch@yandex.ru>
This commit is contained in:
Octol1ttle
2024-12-02 15:10:55 +05:00
committed by GitHub
parent 625250b367
commit 57d492da8a
356 changed files with 10531 additions and 4761 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
common/validators/UsernameValidator.php
View File

@@ -1,6 +1,7 @@
<?php
namespace common\validators;
use Closure;
use common\helpers\Error as E;
use common\helpers\StringHelper;
use common\models\Account;
@@ -12,15 +13,15 @@ use yii\validators\Validator;
class UsernameValidator extends Validator {
/**
* @var \Closure the function must return the account id for which the current validation is being performed.
* @phpstan-var \Closure(): int the function must return the account id for which the current validation is being performed.
* Allows you to skip the username check for the current account.
*/
public $accountCallback;
public ?Closure $accountCallback = null;
public $skipOnEmpty = false;
public function validateAttribute($model, $attribute) {
$filter = new validators\FilterValidator(['filter' => [StringHelper::class, 'trim']]);
public function validateAttribute($model, $attribute): ?array {
$filter = new validators\FilterValidator(['filter' => StringHelper::trim(...)]);
$required = new validators\RequiredValidator();
$required->message = E::USERNAME_REQUIRED;
@@ -39,16 +40,18 @@ class UsernameValidator extends Validator {
$unique->targetClass = Account::class;
$unique->targetAttribute = 'username';
if ($this->accountCallback !== null) {
$unique->filter = function(QueryInterface $query) {
$unique->filter = function(QueryInterface $query): void {
$query->andWhere(['NOT', ['id' => ($this->accountCallback)()]]);
};
}
$this->executeValidation($filter, $model, $attribute) &&
$this->executeValidation($required, $model, $attribute) &&
$this->executeValidation($length, $model, $attribute) &&
$this->executeValidation($pattern, $model, $attribute) &&
$this->executeValidation($unique, $model, $attribute);
$this->executeValidation($filter, $model, $attribute)
&& $this->executeValidation($required, $model, $attribute)
&& $this->executeValidation($length, $model, $attribute)
&& $this->executeValidation($pattern, $model, $attribute)
&& $this->executeValidation($unique, $model, $attribute);
return null;
}
protected function executeValidation(Validator $validator, Model $model, string $attribute) {