From 75a08114881a5d51350e31bec52628038d97cc95 Mon Sep 17 00:00:00 2001
From: SleepWalker <mybox@udf.su>
Date: Mon, 2 May 2016 13:11:10 +0300
Subject: [PATCH] Do not request password till newPassword and newRePassword
 are valid

---
 api/models/ChangePasswordForm.php                   |  2 +-
 .../api/unit/models/ChangePasswordFormTest.php      | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/api/models/ChangePasswordForm.php b/api/models/ChangePasswordForm.php
index df5ad81..e34a9e5 100644
--- a/api/models/ChangePasswordForm.php
+++ b/api/models/ChangePasswordForm.php
@@ -34,7 +34,7 @@ class ChangePasswordForm extends PasswordProtectedForm {
     }
 
     public function validatePasswordAndRePasswordMatch($attribute) {
-        if (!$this->hasErrors()) {
+        if (!$this->hasErrors($attribute)) {
             if ($this->newPassword !== $this->newRePassword) {
                 $this->addError($attribute, 'error.newRePassword_does_not_match');
             }
diff --git a/tests/codeception/api/unit/models/ChangePasswordFormTest.php b/tests/codeception/api/unit/models/ChangePasswordFormTest.php
index e957f94..dedb750 100644
--- a/tests/codeception/api/unit/models/ChangePasswordFormTest.php
+++ b/tests/codeception/api/unit/models/ChangePasswordFormTest.php
@@ -47,6 +47,19 @@ class ChangePasswordFormTest extends DbTestCase {
             $model->validatePasswordAndRePasswordMatch('newRePassword');
             expect($model->getErrors('newRePassword'))->isEmpty();
         });
+
+        $this->specify('error.newRePassword_does_not_match expected even if there are errors on other attributes', function() {
+            // this is very important, because password change flow may be combined of two steps
+            // therefore we need to validate password sameness before we will validate current account password
+            $account = new Account();
+            $account->setPassword('12345678');
+            $model = new ChangePasswordForm($account, [
+                'newPassword' => 'my-new-password',
+                'newRePassword' => 'another-password',
+            ]);
+            $model->validate();
+            expect($model->getErrors('newRePassword'))->equals(['error.newRePassword_does_not_match']);
+        });
     }
 
     public function testChangePassword() {