ElyBy-Mirror/accounts
1
0
Fork 0
mirror of https://github.com/elyby/accounts.git synced 2025-05-31 14:11:46 +05:30
Code Issues Packages Projects Releases Wiki Activity

Get rid of ThisShouldNotHappenException

Browse Source
This commit is contained in:
ErickSkrauch
2019-12-13 20:48:13 +03:00
parent 26f7d6213f
commit 830a17612b
18 changed files with 36 additions and 101 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
api/modules/oauth/models/OauthClientForm.php
View File

@@ -3,10 +3,10 @@ declare(strict_types=1);
namespace api\modules\oauth\models;
use api\exceptions\ThisShouldNotHappenException;
use api\modules\oauth\exceptions\InvalidOauthClientState;
use common\models\OauthClient;
use common\tasks\ClearOauthSessions;
use Webmozart\Assert\Assert;
use Yii;
use yii\helpers\Inflector;
@@ -48,9 +48,7 @@ class OauthClientForm {
$client->generateSecret();
}
if (!$client->save()) {
throw new ThisShouldNotHappenException('Cannot save oauth client');
}
Assert::true($client->save(), 'Cannot save oauth client');
return true;
}
@@ -60,9 +58,7 @@ class OauthClientForm {
$client = $this->client;
$client->is_deleted = true;
if (!$client->save()) {
throw new ThisShouldNotHappenException('Cannot update oauth client');
}
Assert::true($client->save(), 'Cannot update oauth client');
Yii::$app->queue->push(ClearOauthSessions::createFromOauthClient($client));
@@ -77,9 +73,7 @@ class OauthClientForm {
$client = $this->client;
if ($regenerateSecret) {
$client->generateSecret();
if (!$client->save()) {
throw new ThisShouldNotHappenException('Cannot update oauth client');
}
Assert::true($client->save(), 'Cannot update oauth client');
}
Yii::$app->queue->push(ClearOauthSessions::createFromOauthClient($client, time()));