Образован trait AccountFinder для поиска пользователя по его нику\мылу

Модель EmailActivation теперь умеет автоматически создавать своих правильных потомков по соответствующему типу
Добавлена форма восстановления пароля и её обработчик (без контроллера)

api/controllers/SignupController.php

@@ -61,10 +61,10 @@ class SignupController extends Controller {
             ];
 
             if ($response['errors']['email'] === 'error.recently_sent_message') {
-                $activeActivation = $model->getActiveActivation();
+                $activation = $model->getActivation();
                 $response['data'] = [
-                    'canRepeatIn' => $activeActivation->created_at - time() + RepeatAccountActivationForm::REPEAT_FREQUENCY,
-                    'repeatFrequency' => RepeatAccountActivationForm::REPEAT_FREQUENCY,
+                    'canRepeatIn' => $activation->canRepeatIn(),
+                    'repeatFrequency' => $activation->repeatTimeout,
                 ];
             }
 

api/mails/forgot-password-html.php

@@ -0,0 +1,11 @@
+<?php
+/**
+ * @var string $key
+ */
+?>
+
+<p>
+    Вы забыли пароль и воспользовались формой по его восстановлению, не так ли? Введите этот код в форму и вы сможете
+    сменить свой пароль на новый
+</p>
+<p>Код: <?= $key ?></p>

api/mails/forgot-password-text.php

@@ -0,0 +1,10 @@
+<?php
+/**
+ * @var string $key
+ */
+?>
+
+Вы забыли пароль и воспользовались формой по его восстановлению, не так ли? Введите этот код в форму и вы сможете
+сменить свой пароль на новый
+
+Код активации <?= $key ?>

api/models/ForgotPasswordForm.php

@@ -0,0 +1,122 @@
+<?php
+namespace api\models;
+
+use api\models\base\ApiForm;
+use api\traits\AccountFinder;
+use common\components\UserFriendlyRandomKey;
+use common\models\Account;
+use common\models\confirmations\RecoverPassword;
+use common\models\EmailActivation;
+use Yii;
+use yii\base\ErrorException;
+use yii\base\InvalidConfigException;
+
+class ForgotPasswordForm extends ApiForm {
+    use AccountFinder;
+
+    public $login;
+
+    public function rules() {
+        return [
+            ['login', 'required', 'message' => 'error.login_required'],
+            ['login', 'validateLogin'],
+            ['login', 'validateActivity'],
+            ['login', 'validateFrequency'],
+        ];
+    }
+
+    public function validateLogin($attribute) {
+        if (!$this->hasErrors()) {
+            if ($this->getAccount() === null) {
+                $this->addError($attribute, 'error.' . $attribute . '_not_exist');
+            }
+        }
+    }
+
+    public function validateActivity($attribute) {
+        if (!$this->hasErrors()) {
+            $account = $this->getAccount();
+            if ($account->status !== Account::STATUS_ACTIVE) {
+                $this->addError($attribute, 'error.account_not_activated');
+            }
+        }
+    }
+
+    public function validateFrequency($attribute) {
+        if (!$this->hasErrors()) {
+            $emailConfirmation = $this->getEmailActivation();
+            if ($emailConfirmation !== null && !$emailConfirmation->canRepeat()) {
+                $this->addError($attribute, 'error.email_frequency');
+            }
+        }
+    }
+
+    public function forgotPassword() {
+        if (!$this->validate()) {
+            return false;
+        }
+
+        $account = $this->getAccount();
+        $emailActivation = $this->getEmailActivation();
+        if ($emailActivation === null) {
+            $emailActivation = new RecoverPassword();
+            $emailActivation->account_id = $account->id;
+        } else {
+            $emailActivation->created_at = time();
+        }
+
+        $emailActivation->key = UserFriendlyRandomKey::make();
+        if (!$emailActivation->save()) {
+            throw new ErrorException('Cannot create email activation for forgot password form');
+        }
+
+        $this->sendMail($emailActivation);
+
+        return true;
+    }
+
+    public function sendMail(EmailActivation $emailActivation) {
+        /** @var \yii\swiftmailer\Mailer $mailer */
+        $mailer = Yii::$app->mailer;
+        $fromEmail = Yii::$app->params['fromEmail'];
+        if (!$fromEmail) {
+            throw new InvalidConfigException('Please specify fromEmail app in app params');
+        }
+
+        $acceptor = $emailActivation->account;
+        /** @var \yii\swiftmailer\Message $message */
+        $message = $mailer->compose([
+            'html' => '@app/mails/forgot-password-html',
+            'text' => '@app/mails/forgot-password-text',
+        ], [
+            'key' => $emailActivation->key,
+        ])
+            ->setTo([$acceptor->email => $acceptor->username])
+            ->setFrom([$fromEmail => 'Ely.by Accounts'])
+            ->setSubject('Ely.by Account forgot password');
+
+        if (!$message->send()) {
+            throw new ErrorException('Unable send email with activation code.');
+        }
+    }
+
+    public function getLogin() {
+        return $this->login;
+    }
+
+    /**
+     * @return EmailActivation|null
+     * @throws ErrorException
+     */
+    public function getEmailActivation() {
+        $account = $this->getAccount();
+        if ($account === null) {
+            throw new ErrorException('Account not founded');
+        }
+
+        return $account->getEmailActivations()
+            ->andWhere(['type' => EmailActivation::TYPE_FORGOT_PASSWORD_KEY])
+            ->one();
+    }
+
+}

api/models/LoginForm.php

@@ -2,17 +2,17 @@
 namespace api\models;
 
 use api\models\base\ApiForm;
+use api\traits\AccountFinder;
 use common\models\Account;
 use Yii;
 
 class LoginForm extends ApiForm {
+    use AccountFinder;
 
     public $login;
     public $password;
     public $rememberMe = true;
 
-    private $_account;
-
     public function rules() {
         return [
             ['login', 'required', 'message' => 'error.login_required'],
@@ -55,6 +55,10 @@ class LoginForm extends ApiForm {
         }
     }
 
+    public function getLogin() {
+        return $this->login;
+    }
+
     /**
      * @return bool|string JWT с информацией об аккаунте
      */
@@ -66,19 +70,4 @@ class LoginForm extends ApiForm {
         return $this->getAccount()->getJWT();
     }
 
-    /**
-     * @return Account|null
-     */
-    public function getAccount() {
-        if ($this->_account === NULL) {
-            $this->_account = Account::findOne([$this->getLoginAttribute() => $this->login]);
-        }
-
-        return $this->_account;
-    }
-
-    public function getLoginAttribute() {
-        return strpos($this->login, '@') ? 'email' : 'username';
-    }
-
 }

api/models/RegistrationForm.php

@@ -5,6 +5,7 @@ use api\components\ReCaptcha\Validator as ReCaptchaValidator;
 use api\models\base\ApiForm;
 use common\components\UserFriendlyRandomKey;
 use common\models\Account;
+use common\models\confirmations\RegistrationConfirmation;
 use common\models\EmailActivation;
 use Ramsey\Uuid\Uuid;
 use Yii;
@@ -78,9 +79,8 @@ class RegistrationForm extends ApiForm {
                 throw new ErrorException('Account not created.');
             }
 
-            $emailActivation = new EmailActivation();
+            $emailActivation = new RegistrationConfirmation();
             $emailActivation->account_id = $account->id;
-            $emailActivation->type = EmailActivation::TYPE_REGISTRATION_EMAIL_CONFIRMATION;
             $emailActivation->key = UserFriendlyRandomKey::make();
 
             if (!$emailActivation->save()) {

api/models/RepeatAccountActivationForm.php

@@ -4,17 +4,17 @@ namespace api\models;
 use api\models\base\ApiForm;
 use common\components\UserFriendlyRandomKey;
 use common\models\Account;
+use common\models\confirmations\RegistrationConfirmation;
 use common\models\EmailActivation;
 use Yii;
 use yii\base\ErrorException;
 
 class RepeatAccountActivationForm extends ApiForm {
 
-    // Частота повтора отправки нового письма
-    const REPEAT_FREQUENCY = 5 * 60;
-
     public $email;
 
+    private $emailActivation;
+
     public function rules() {
         return [
             ['email', 'filter', 'filter' => 'trim'],
@@ -40,7 +40,8 @@ class RepeatAccountActivationForm extends ApiForm {
 
     public function validateExistsActivation($attribute) {
         if (!$this->hasErrors($attribute)) {
-            if ($this->getActiveActivation() !== null) {
+            $activation = $this->getActivation();
+            if ($activation !== null && !$activation->canRepeat()) {
                 $this->addError($attribute, 'error.recently_sent_message');
             }
         }
@@ -59,9 +60,8 @@ class RepeatAccountActivationForm extends ApiForm {
                 'type' => EmailActivation::TYPE_REGISTRATION_EMAIL_CONFIRMATION,
             ]);
 
-            $activation = new EmailActivation();
+            $activation = new RegistrationConfirmation();
             $activation->account_id = $account->id;
-            $activation->type = EmailActivation::TYPE_REGISTRATION_EMAIL_CONFIRMATION;
             $activation->key = UserFriendlyRandomKey::make();
             if (!$activation->save()) {
                 throw new ErrorException('Unable save email-activation model.');
@@ -91,12 +91,15 @@ class RepeatAccountActivationForm extends ApiForm {
     /**
      * @return EmailActivation|null
      */
-    public function getActiveActivation() {
-        return $this->getAccount()
+    public function getActivation() {
+        if ($this->emailActivation === null) {
+            $this->emailActivation = $this->getAccount()
                 ->getEmailActivations()
                 ->andWhere(['type' => EmailActivation::TYPE_REGISTRATION_EMAIL_CONFIRMATION])
-            ->andWhere(['>=', 'created_at', time() - self::REPEAT_FREQUENCY])
                 ->one();
         }
 
+        return $this->emailActivation;
+    }
+
 }

api/traits/AccountFinder.php

@@ -0,0 +1,27 @@
+<?php
+namespace api\traits;
+
+use common\models\Account;
+
+trait AccountFinder {
+
+    private $account;
+
+    public abstract function getLogin();
+
+    /**
+     * @return Account|null
+     */
+    public function getAccount() {
+        if ($this->account === null) {
+            $this->account = Account::findOne([$this->getLoginAttribute() => $this->getLogin()]);
+        }
+
+        return $this->account;
+    }
+
+    public function getLoginAttribute() {
+        return strpos($this->getLogin(), '@') ? 'email' : 'username';
+    }
+
+}

common/behaviors/EmailActivationExpirationBehavior.php

@@ -0,0 +1,85 @@
+<?php
+namespace common\behaviors;
+
+use yii\base\Behavior;
+
+/**
+ * @property \common\models\EmailActivation $owner
+ */
+class EmailActivationExpirationBehavior extends Behavior {
+
+    /**
+     * @var int количество секунд, прежде чем можно будет повторить отправку кода
+     * @see EmailActivation::canRepeat()
+     */
+    public $repeatTimeout;
+
+    /**
+     * @var int количество секунд, прежде чем это подтверждение истечёт
+     * @see EmailActivation::isExpired()
+     */
+    public $expirationTimeout;
+
+    /**
+     * Можно ли повторить отправку письма текущего типа?
+     * Для проверки используется значение EmailActivation::$repeatTimeout и интерпретируется как:
+     * - <0 запретит повторную отправку этого кода
+     * - =0 позволит отправлять сообщения в любой момент
+     * - >0 будет проверять, сколько секунд прошло с момента создания модели
+     *
+     * @see EmailActivation::compareTime()
+     * @return bool
+     */
+    public function canRepeat() : bool {
+        return $this->compareTime($this->repeatTimeout);
+    }
+
+    /**
+     * Истёк ли срок кода?
+     * Для проверки используется значение EmailActivation::$expirationTimeout и интерпретируется как:
+     * - <0 означает, что код никогда не истечёт
+     * - =0 всегда будет говорить, что код истёк
+     * - >0 будет проверять, сколько секунд прошло с момента создания модели
+     *
+     * @see EmailActivation::compareTime()
+     * @return bool
+     */
+    public function isExpired() : bool {
+        return $this->compareTime($this->expirationTimeout);
+    }
+
+    /**
+     * Вычисляет, во сколько можно будет выполнить повторную отправку кода
+     *
+     * @return int
+     */
+    public function canRepeatIn() : int {
+        return $this->calculateTime($this->repeatTimeout);
+    }
+
+    /**
+     * Вычисляет, во сколько код истечёт
+     *
+     * @return int
+     */
+    public function expireIn() : int {
+        return $this->calculateTime($this->expirationTimeout);
+    }
+
+    protected function compareTime(int $value) : bool {
+        if ($value < 0) {
+            return false;
+        }
+
+        if ($value === 0) {
+            return true;
+        }
+
+        return time() > $this->calculateTime($value);
+    }
+
+    protected function calculateTime(int $value) : int {
+        return $this->owner->created_at + $value;
+    }
+
+}

common/models/EmailActivation.php

@@ -1,8 +1,12 @@
 <?php
 namespace common\models;
 
+use common\behaviors\EmailActivationExpirationBehavior;
 use Yii;
+use yii\base\InvalidConfigException;
 use yii\behaviors\TimestampBehavior;
+use yii\db\ActiveRecord;
+use yii\helpers\ArrayHelper;
 
 /**
  * Поля модели:
@@ -16,14 +20,16 @@ use yii\behaviors\TimestampBehavior;
  *
  * Поведения:
  * @mixin TimestampBehavior
+ * @mixin EmailActivationExpirationBehavior
  *
  * TODO: у модели могут быть проблемы с уникальностью, т.к. key является первичным и не автоинкрементом
  * TODO: мб стоит ловить beforeCreate и именно там генерировать уникальный ключ для модели.
  * Но опять же нужно продумать, а как пробросить формат и обеспечить преемлемую уникальность.
  */
-class EmailActivation extends \yii\db\ActiveRecord {
+class EmailActivation extends ActiveRecord {
 
     const TYPE_REGISTRATION_EMAIL_CONFIRMATION = 0;
+    const TYPE_FORGOT_PASSWORD_KEY = 1;
 
     public static function tableName() {
         return '{{%email_activations}}';
@@ -35,15 +41,40 @@ class EmailActivation extends \yii\db\ActiveRecord {
                 'class' => TimestampBehavior::class,
                 'updatedAtAttribute' => false,
             ],
+            'expirationBehavior' => [
+                'class' => EmailActivationExpirationBehavior::class,
+                'repeatTimeout' => 5 * 60,
+                'expirationTimeout' => -1,
+            ],
         ];
     }
 
-    public function rules() {
-        return [];
-    }
-
     public function getAccount() {
         return $this->hasOne(Account::class, ['id' => 'account_id']);
     }
 
+    /**
+     * @inheritdoc
+     */
+    public static function instantiate($row) {
+        $type = ArrayHelper::getValue($row, 'type');
+        if ($type === null) {
+            return new static;
+        }
+
+        $classMap = self::getClassMap();
+        if (!isset($classMap[$type])) {
+            throw new InvalidConfigException('Unexpected type');
+        }
+
+        return new $classMap[$type];
+    }
+
+    public static function getClassMap() {
+        return [
+            self::TYPE_REGISTRATION_EMAIL_CONFIRMATION => confirmations\RegistrationConfirmation::class,
+            self::TYPE_FORGOT_PASSWORD_KEY => confirmations\RecoverPassword::class,
+        ];
+    }
+
 }

common/models/confirmations/RecoverPassword.php

@@ -0,0 +1,23 @@
+<?php
+namespace common\models\confirmations;
+
+use common\models\EmailActivation;
+use yii\helpers\ArrayHelper;
+
+class RecoverPassword extends EmailActivation {
+
+    public function behaviors() {
+        return ArrayHelper::merge(parent::behaviors(), [
+            'expirationBehavior' => [
+                'repeatTimeout' => 30 * 60,
+                'expirationTimeout' => 1 * 60 * 60,
+            ],
+        ]);
+    }
+
+    public function init() {
+        parent::init();
+        $this->type = EmailActivation::TYPE_FORGOT_PASSWORD_KEY;
+    }
+
+}

common/models/confirmations/RegistrationConfirmation.php

@@ -0,0 +1,13 @@
+<?php
+namespace common\models\confirmations;
+
+use common\models\EmailActivation;
+
+class RegistrationConfirmation extends EmailActivation {
+
+    public function init() {
+        parent::init();
+        $this->type = EmailActivation::TYPE_REGISTRATION_EMAIL_CONFIRMATION;
+    }
+
+}

tests/codeception/api/unit/models/ConfirmEmailFormTest.php

@@ -31,7 +31,7 @@ class ConfirmEmailFormTest extends DbTestCase {
     }
 
     public function testConfirm() {
-        $fixture = $this->emailActivations[0];
+        $fixture = $this->emailActivations['freshRegistrationConfirmation'];
         $model = $this->createModel($fixture['key']);
         $this->specify('expect true result', function() use ($model, $fixture) {
             expect('model return successful result', $model->confirm())->notEquals(false);

tests/codeception/api/unit/models/ForgotPasswordFormTest.php

@@ -0,0 +1,149 @@
+<?php
+namespace codeception\api\unit\models;
+
+use api\models\ForgotPasswordForm;
+use Codeception\Specify;
+use common\models\EmailActivation;
+use tests\codeception\api\unit\DbTestCase;
+use tests\codeception\common\fixtures\AccountFixture;
+use tests\codeception\common\fixtures\EmailActivationFixture;
+use Yii;
+
+/**
+ * @property array $accounts
+ * @property array $emailActivations
+ */
+class ForgotPasswordFormTest extends DbTestCase {
+    use Specify;
+
+    protected function setUp() {
+        parent::setUp();
+        /** @var \yii\swiftmailer\Mailer $mailer */
+        $mailer = Yii::$app->mailer;
+        $mailer->fileTransportCallback = function () {
+            return 'testing_message.eml';
+        };
+    }
+
+    protected function tearDown() {
+        if (file_exists($this->getMessageFile())) {
+            unlink($this->getMessageFile());
+        }
+
+        parent::tearDown();
+    }
+
+    public function fixtures() {
+        return [
+            'accounts' => [
+                'class' => AccountFixture::class,
+                'dataFile' => '@tests/codeception/common/fixtures/data/accounts.php',
+            ],
+            'emailActivations' => [
+                'class' => EmailActivationFixture::class,
+                'dataFile' => '@tests/codeception/common/fixtures/data/email-activations.php',
+            ],
+        ];
+    }
+
+    public function testValidateAccount() {
+        $this->specify('error.login_not_exist if login is invalid', function() {
+            $model = new ForgotPasswordForm(['login' => 'unexist']);
+            $model->validateLogin('login');
+            expect($model->getErrors('login'))->equals(['error.login_not_exist']);
+        });
+
+        $this->specify('empty errors if login is exists', function() {
+            $model = new ForgotPasswordForm(['login' => $this->accounts['admin']['username']]);
+            $model->validateLogin('login');
+            expect($model->getErrors('login'))->isEmpty();
+        });
+    }
+
+    public function testValidateActivity() {
+        $this->specify('error.account_not_activated if account is not confirmed', function() {
+            $model = new ForgotPasswordForm(['login' => $this->accounts['not-activated-account']['username']]);
+            $model->validateActivity('login');
+            expect($model->getErrors('login'))->equals(['error.account_not_activated']);
+        });
+
+        $this->specify('empty errors if login is exists', function() {
+            $model = new ForgotPasswordForm(['login' => $this->accounts['admin']['username']]);
+            $model->validateLogin('login');
+            expect($model->getErrors('login'))->isEmpty();
+        });
+    }
+
+    public function testValidateFrequency() {
+        $this->specify('error.account_not_activated if recently was message', function() {
+            $model = new DummyForgotPasswordForm([
+                'login' => $this->accounts['admin']['username'],
+                'key' => $this->emailActivations['freshPasswordRecovery']['key'],
+            ]);
+
+            $model->validateFrequency('login');
+            expect($model->getErrors('login'))->equals(['error.email_frequency']);
+        });
+
+        $this->specify('empty errors if email was sent a long time ago', function() {
+            $model = new DummyForgotPasswordForm([
+                'login' => $this->accounts['admin']['username'],
+                'key' => $this->emailActivations['oldPasswordRecovery']['key'],
+            ]);
+
+            $model->validateFrequency('login');
+            expect($model->getErrors('login'))->isEmpty();
+        });
+
+        $this->specify('empty errors if previous confirmation model not founded', function() {
+            $model = new DummyForgotPasswordForm([
+                'login' => $this->accounts['admin']['username'],
+                'key' => 'invalid-key',
+            ]);
+
+            $model->validateFrequency('login');
+            expect($model->getErrors('login'))->isEmpty();
+        });
+    }
+
+    public function testForgotPassword() {
+        $this->specify('successfully send message with restore password key', function() {
+            $model = new ForgotPasswordForm(['login' => $this->accounts['admin']['username']]);
+            expect($model->forgotPassword())->true();
+            expect($model->getEmailActivation())->notNull();
+            expect_file($this->getMessageFile())->exists();
+        });
+    }
+
+    public function testForgotPasswordResend() {
+        $this->specify('successfully renew and send message with restore password key', function() {
+            $model = new ForgotPasswordForm([
+                'login' => $this->accounts['account-with-expired-forgot-password-message']['username'],
+            ]);
+            $callTime = time();
+            expect($model->forgotPassword())->true();
+            $emailActivation = $model->getEmailActivation();
+            expect($emailActivation)->notNull();
+            expect($emailActivation->created_at)->greaterOrEquals($callTime);
+            expect_file($this->getMessageFile())->exists();
+        });
+    }
+
+    private function getMessageFile() {
+        /** @var \yii\swiftmailer\Mailer $mailer */
+        $mailer = Yii::$app->mailer;
+
+        return Yii::getAlias($mailer->fileTransportPath) . '/testing_message.eml';
+    }
+
+}
+
+class DummyForgotPasswordForm extends ForgotPasswordForm {
+
+    public $key;
+
+    public function getEmailActivation() {
+        return EmailActivation::findOne($this->key);
+    }
+
+}

tests/codeception/api/unit/models/LoginFormTest.php

@@ -84,18 +84,6 @@ class LoginFormTest extends DbTestCase {
         });
     }
 
-    public function testGetLoginAttribute() {
-        $this->specify('email if login look like email value', function() {
-            $model = new DummyLoginForm(['login' => 'erickskrauch@ely.by']);
-            expect($model->getLoginAttribute())->equals('email');
-        });
-
-        $this->specify('username in any other case', function() {
-            $model = new DummyLoginForm(['login' => 'erickskrauch']);
-            expect($model->getLoginAttribute())->equals('username');
-        });
-    }
-
 }
 
 class DummyLoginForm extends LoginForm {

tests/codeception/api/unit/models/RepeatAccountActivationFormTest.php

@@ -3,6 +3,7 @@ namespace tests\codeception\api\models;
 
 use api\models\RepeatAccountActivationForm;
 use Codeception\Specify;
+use common\models\EmailActivation;
 use tests\codeception\api\unit\DbTestCase;
 use tests\codeception\common\fixtures\AccountFixture;
 use tests\codeception\common\fixtures\EmailActivationFixture;
@@ -67,14 +68,17 @@ class RepeatAccountActivationFormTest extends DbTestCase {
 
     public function testValidateExistsActivation() {
         $this->specify('error.recently_sent_message if passed email has recently sent message', function() {
-            $model = new RepeatAccountActivationForm(['email' => $this->accounts['not-activated-account']['email']]);
+            $model = new DummyRepeatAccountActivationForm([
+                'emailKey' => $this->activations['freshRegistrationConfirmation']['key'],
+            ]);
             $model->validateExistsActivation('email');
             expect($model->getErrors('email'))->equals(['error.recently_sent_message']);
         });
 
         $this->specify('no errors if passed email has expired activation message', function() {
-            $email = $this->accounts['not-activated-account-with-expired-message']['email'];
-            $model = new RepeatAccountActivationForm(['email' => $email]);
+            $model = new DummyRepeatAccountActivationForm([
+                'emailKey' => $this->activations['oldRegistrationConfirmation']['key'],
+            ]);
             $model->validateExistsActivation('email');
             expect($model->getErrors('email'))->isEmpty();
         });
@@ -91,7 +95,7 @@ class RepeatAccountActivationFormTest extends DbTestCase {
             $email = $this->accounts['not-activated-account-with-expired-message']['email'];
             $model = new RepeatAccountActivationForm(['email' => $email]);
             expect($model->sendRepeatMessage())->true();
-            expect($model->getActiveActivation())->notNull();
+            expect($model->getActivation())->notNull();
             expect_file($this->getMessageFile())->exists();
         });
     }
@@ -104,3 +108,13 @@ class RepeatAccountActivationFormTest extends DbTestCase {
     }
 
 }
+
+class DummyRepeatAccountActivationForm extends RepeatAccountActivationForm {
+
+    public $emailKey;
+
+    public function getActivation() {
+        return EmailActivation::findOne($this->emailKey);
+    }
+
+}

tests/codeception/api/unit/models/base/KeyConfirmationFormTest.php

@@ -53,7 +53,7 @@ class KeyConfirmationFormTest extends DbTestCase {
     }
 
     public function testCorrectKey() {
-        $model = $this->createModel($this->emailActivations[0]['key']);
+        $model = $this->createModel($this->emailActivations['freshRegistrationConfirmation']['key']);
         $this->specify('no errors if key exists', function () use ($model) {
             expect('model should pass validation', $model->validate())->true();
         });

tests/codeception/api/unit/traits/AccountFinderTest.php

@@ -0,0 +1,67 @@
+<?php
+namespace tests\codeception\api\traits;
+
+use api\traits\AccountFinder;
+use Codeception\Specify;
+use common\models\Account;
+use tests\codeception\api\unit\DbTestCase;
+use tests\codeception\common\fixtures\AccountFixture;
+
+/**
+ * @property \tests\codeception\api\UnitTester $actor
+ * @property array $accounts
+ */
+class AccountFinderTest extends DbTestCase {
+    use Specify;
+
+    public function fixtures() {
+        return [
+            'accounts' => [
+                'class' => AccountFixture::class,
+                'dataFile' => '@tests/codeception/common/fixtures/data/accounts.php',
+            ],
+        ];
+    }
+
+    public function testGetAccount() {
+        $this->specify('founded account for passed login data', function() {
+            $model = new AccountFinderTestTestClass();
+            $model->login = $this->accounts['admin']['email'];
+            $account = $model->getAccount();
+            expect($account)->isInstanceOf(Account::class);
+            expect($account->id)->equals($this->accounts['admin']['id']);
+        });
+
+        $this->specify('null, if account not founded', function() {
+            $model = new AccountFinderTestTestClass();
+            $model->login = 'unexpected';
+            expect($account = $model->getAccount())->null();
+        });
+    }
+
+    public function testGetLoginAttribute() {
+        $this->specify('if login look like email value, then \'email\'', function() {
+            $model = new AccountFinderTestTestClass();
+            $model->login = 'erickskrauch@ely.by';
+            expect($model->getLoginAttribute())->equals('email');
+        });
+
+        $this->specify('username in any other case', function() {
+            $model = new AccountFinderTestTestClass();
+            $model->login = 'erickskrauch';
+            expect($model->getLoginAttribute())->equals('username');
+        });
+    }
+
+}
+
+class AccountFinderTestTestClass {
+    use AccountFinder;
+
+    public $login;
+
+    public function getLogin() {
+        return $this->login;
+    }
+
+}

tests/codeception/common/fixtures/data/accounts.php

@@ -51,4 +51,28 @@ return [
         'created_at' => 1457890086,
         'updated_at' => 1457890086,
     ],
+    'account-with-fresh-forgot-password-message' => [
+        'id' => 5,
+        'uuid' => '4aaf4f00-3b5b-4d36-9252-9e8ee0c86679',
+        'username' => 'Notch',
+        'email' => 'notch@mojang.com',
+        'password_hash' => '$2y$13$2rYkap5T6jG8z/mMK8a3Ou6aZxJcmAaTha6FEuujvHEmybSHRzW5e', # password_0
+        'password_hash_strategy' => \common\models\Account::PASS_HASH_STRATEGY_YII2,
+        'password_reset_token' => null,
+        'status' => \common\models\Account::STATUS_ACTIVE,
+        'created_at' => 1462891432,
+        'updated_at' => 1462891432,
+    ],
+    'account-with-expired-forgot-password-message' => [
+        'id' => 6,
+        'uuid' => '26187ae7-bc96-421f-9766-6517f8ee52b7',
+        'username' => '23derevo',
+        'email' => '23derevo@gmail.com',
+        'password_hash' => '$2y$13$2rYkap5T6jG8z/mMK8a3Ou6aZxJcmAaTha6FEuujvHEmybSHRzW5e', # password_0
+        'password_hash_strategy' => \common\models\Account::PASS_HASH_STRATEGY_YII2,
+        'password_reset_token' => null,
+        'status' => \common\models\Account::STATUS_ACTIVE,
+        'created_at' => 1462891612,
+        'updated_at' => 1462891612,
+    ],
 ];

tests/codeception/common/fixtures/data/email-activations.php

@@ -1,15 +1,27 @@
 <?php
 return [
-    [
+    'freshRegistrationConfirmation' => [
         'key' => 'HABGCABHJ1234HBHVD',
         'account_id' => 3,
         'type' => \common\models\EmailActivation::TYPE_REGISTRATION_EMAIL_CONFIRMATION,
         'created_at' => time(),
     ],
-    [
+    'oldRegistrationConfirmation' => [
         'key' => 'H23HBDCHHAG2HGHGHS',
         'account_id' => 4,
         'type' => \common\models\EmailActivation::TYPE_REGISTRATION_EMAIL_CONFIRMATION,
-        'created_at' => time() - \api\models\RepeatAccountActivationForm::REPEAT_FREQUENCY - 10,
+        'created_at' => time() - (new \common\models\confirmations\RegistrationConfirmation())->repeatTimeout - 10,
+    ],
+    'freshPasswordRecovery' => [
+        'key' => 'H24HBDCHHAG2HGHGHS',
+        'account_id' => 5,
+        'type' => \common\models\EmailActivation::TYPE_FORGOT_PASSWORD_KEY,
+        'created_at' => time(),
+    ],
+    'oldPasswordRecovery' => [
+        'key' => 'H25HBDCHHAG2HGHGHS',
+        'account_id' => 6,
+        'type' => \common\models\EmailActivation::TYPE_FORGOT_PASSWORD_KEY,
+        'created_at' => time() - (new \common\models\confirmations\RecoverPassword())->repeatTimeout - 10,
     ],
 ];

tests/codeception/common/unit/models/EmailActivationTest.php

@@ -0,0 +1,34 @@
+<?php
+namespace codeception\common\unit\models;
+
+use Codeception\Specify;
+use common\models\confirmations\RecoverPassword;
+use common\models\confirmations\RegistrationConfirmation;
+use common\models\EmailActivation;
+use tests\codeception\common\fixtures\EmailActivationFixture;
+use tests\codeception\console\unit\DbTestCase;
+
+class EmailActivationTest extends DbTestCase {
+    use Specify;
+
+    public function fixtures() {
+        return [
+            'emailActivations' => [
+                'class' => EmailActivationFixture::class,
+                'dataFile' => '@tests/codeception/common/fixtures/data/email-activations.php',
+            ],
+        ];
+    }
+
+    public function testInstantiate() {
+        $this->specify('return valid model type', function() {
+            expect(EmailActivation::findOne([
+                'type' => EmailActivation::TYPE_REGISTRATION_EMAIL_CONFIRMATION,
+            ]))->isInstanceOf(RegistrationConfirmation::class);
+            expect(EmailActivation::findOne([
+                'type' => EmailActivation::TYPE_FORGOT_PASSWORD_KEY,
+            ]))->isInstanceOf(RecoverPassword::class);
+        });
+    }
+
+}