Rework tests structure. Upgrade codeception to 2.5.3. Merge params configuration into app configuration.

common/tests/unit/models/AccountSessionTest.php

@@ -0,0 +1,27 @@
+<?php
+namespace common\tests\unit\models;
+
+use common\models\AccountSession;
+use common\tests\unit\TestCase;
+
+class AccountSessionTest extends TestCase {
+
+    public function testGenerateRefreshToken() {
+        $model = new AccountSession();
+        $model->generateRefreshToken();
+        $this->assertNotNull($model->refresh_token, 'method call will set refresh_token value');
+    }
+
+    public function testSetIp() {
+        $model = new AccountSession();
+        $model->setIp('127.0.0.1');
+        $this->assertEquals(2130706433, $model->last_used_ip, 'method should convert passed ip string to long');
+    }
+
+    public function testGetReadableIp() {
+        $model = new AccountSession();
+        $model->last_used_ip = 2130706433;
+        $this->assertEquals('127.0.0.1', $model->getReadableIp(), 'method should convert stored long into readable ip');
+    }
+
+}

common/tests/unit/models/AccountTest.php

@@ -0,0 +1,161 @@
+<?php
+declare(strict_types=1);
+
+namespace common\tests\unit\models;
+
+use Codeception\Specify;
+use common\components\UserPass;
+use common\models\Account;
+use common\tasks\CreateWebHooksDeliveries;
+use common\tests\fixtures\MojangUsernameFixture;
+use common\tests\unit\TestCase;
+use Yii;
+use const common\LATEST_RULES_VERSION;
+
+/**
+ * @covers \common\models\Account
+ */
+class AccountTest extends TestCase {
+    use Specify;
+
+    public function testSetPassword() {
+        $model = new Account();
+        $model->setPassword('12345678');
+        $this->assertNotEmpty($model->password_hash, 'hash should be set');
+        $this->assertTrue($model->validatePassword('12345678'), 'validation should be passed');
+        $this->assertEquals(Account::PASS_HASH_STRATEGY_YII2, $model->password_hash_strategy, 'latest password hash should be used');
+    }
+
+    public function testValidatePassword() {
+        $this->specify('old Ely password should work', function() {
+            $model = new Account([
+                'email' => 'erick@skrauch.net',
+                'password_hash' => UserPass::make('erick@skrauch.net', '12345678'),
+            ]);
+            expect('valid password should pass', $model->validatePassword('12345678', Account::PASS_HASH_STRATEGY_OLD_ELY))->true();
+            expect('invalid password should fail', $model->validatePassword('87654321', Account::PASS_HASH_STRATEGY_OLD_ELY))->false();
+        });
+
+        $this->specify('modern hash algorithm should work', function() {
+            $model = new Account([
+                'password_hash' => Yii::$app->security->generatePasswordHash('12345678'),
+            ]);
+            expect('valid password should pass', $model->validatePassword('12345678', Account::PASS_HASH_STRATEGY_YII2))->true();
+            expect('invalid password should fail', $model->validatePassword('87654321', Account::PASS_HASH_STRATEGY_YII2))->false();
+        });
+
+        $this->specify('if second argument is not pass model value should be used', function() {
+            $model = new Account([
+                'email' => 'erick@skrauch.net',
+                'password_hash_strategy' => Account::PASS_HASH_STRATEGY_OLD_ELY,
+                'password_hash' => UserPass::make('erick@skrauch.net', '12345678'),
+            ]);
+            expect('valid password should pass', $model->validatePassword('12345678'))->true();
+            expect('invalid password should fail', $model->validatePassword('87654321'))->false();
+
+            $model = new Account([
+                'password_hash_strategy' => Account::PASS_HASH_STRATEGY_YII2,
+                'password_hash' => Yii::$app->security->generatePasswordHash('12345678'),
+            ]);
+            expect('valid password should pass', $model->validatePassword('12345678'))->true();
+            expect('invalid password should fail', $model->validatePassword('87654321'))->false();
+        });
+    }
+
+    public function testHasMojangUsernameCollision() {
+        $this->tester->haveFixtures([
+            'mojangUsernames' => MojangUsernameFixture::class,
+        ]);
+
+        $this->specify('Expect true if collision with current username', function() {
+            $model = new Account();
+            $model->username = 'ErickSkrauch';
+            expect($model->hasMojangUsernameCollision())->true();
+        });
+
+        $this->specify('Expect false if some rare username without any collision on Mojang', function() {
+            $model = new Account();
+            $model->username = 'rare-username';
+            expect($model->hasMojangUsernameCollision())->false();
+        });
+    }
+
+    public function testGetProfileLink() {
+        $model = new Account();
+        $model->id = '123';
+        $this->assertEquals('http://ely.by/u123', $model->getProfileLink());
+    }
+
+    public function testIsAgreedWithActualRules() {
+        $this->specify('get false, if rules field set in null', function() {
+            $model = new Account();
+            expect($model->isAgreedWithActualRules())->false();
+        });
+
+        $this->specify('get false, if rules field have version less, then actual', function() {
+            $model = new Account();
+            $model->rules_agreement_version = 0;
+            expect($model->isAgreedWithActualRules())->false();
+        });
+
+        $this->specify('get true, if rules field have equals rules version', function() {
+            $model = new Account();
+            $model->rules_agreement_version = LATEST_RULES_VERSION;
+            expect($model->isAgreedWithActualRules())->true();
+        });
+    }
+
+    public function testSetRegistrationIp() {
+        $account = new Account();
+        $account->setRegistrationIp('42.72.205.204');
+        $this->assertEquals('42.72.205.204', inet_ntop($account->registration_ip));
+        $account->setRegistrationIp('2001:1620:28:1:b6f:8bca:93:a116');
+        $this->assertEquals('2001:1620:28:1:b6f:8bca:93:a116', inet_ntop($account->registration_ip));
+        $account->setRegistrationIp(null);
+        $this->assertNull($account->registration_ip);
+    }
+
+    public function testGetRegistrationIp() {
+        $account = new Account();
+        $account->setRegistrationIp('42.72.205.204');
+        $this->assertEquals('42.72.205.204', $account->getRegistrationIp());
+        $account->setRegistrationIp('2001:1620:28:1:b6f:8bca:93:a116');
+        $this->assertEquals('2001:1620:28:1:b6f:8bca:93:a116', $account->getRegistrationIp());
+        $account->setRegistrationIp(null);
+        $this->assertNull($account->getRegistrationIp());
+    }
+
+    public function testAfterSaveInsertEvent() {
+        $account = new Account();
+        $account->afterSave(true, [
+            'username' => 'old-username',
+        ]);
+        $this->assertNull($this->tester->grabLastQueuedJob());
+    }
+
+    public function testAfterSaveNotMeaningfulAttributes() {
+        $account = new Account();
+        $account->afterSave(false, [
+            'updatedAt' => time(),
+        ]);
+        $this->assertNull($this->tester->grabLastQueuedJob());
+    }
+
+    public function testAfterSavePushEvent() {
+        $changedAttributes = [
+            'username' => 'old-username',
+            'email' => 'old-email@ely.by',
+            'uuid' => 'c3cc0121-fa87-4818-9c0e-4acb7f9a28c5',
+            'status' => 10,
+            'lang' => 'en',
+        ];
+
+        $account = new Account();
+        $account->afterSave(false, $changedAttributes);
+        /** @var CreateWebHooksDeliveries $job */
+        $job = $this->tester->grabLastQueuedJob();
+        $this->assertInstanceOf(CreateWebHooksDeliveries::class, $job);
+        $this->assertSame($job->payloads['changedAttributes'], $changedAttributes);
+    }
+
+}

common/tests/unit/models/EmailActivationTest.php

@@ -0,0 +1,35 @@
+<?php
+namespace common\tests\unit\models;
+
+use common\models\confirmations;
+use common\models\EmailActivation;
+use common\tests\fixtures\EmailActivationFixture;
+use common\tests\unit\TestCase;
+
+class EmailActivationTest extends TestCase {
+
+    public function _fixtures() {
+        return [
+            'emailActivations' => EmailActivationFixture::class,
+        ];
+    }
+
+    public function testInstantiate() {
+        $this->assertInstanceOf(confirmations\RegistrationConfirmation::class, EmailActivation::findOne([
+            'type' => EmailActivation::TYPE_REGISTRATION_EMAIL_CONFIRMATION,
+        ]));
+
+        $this->assertInstanceOf(confirmations\ForgotPassword::class, EmailActivation::findOne([
+            'type' => EmailActivation::TYPE_FORGOT_PASSWORD_KEY,
+        ]));
+
+        $this->assertInstanceOf(confirmations\CurrentEmailConfirmation::class, EmailActivation::findOne([
+            'type' => EmailActivation::TYPE_CURRENT_EMAIL_CONFIRMATION,
+        ]));
+
+        $this->assertInstanceOf(confirmations\NewEmailConfirmation::class, EmailActivation::findOne([
+            'type' => EmailActivation::TYPE_NEW_EMAIL_CONFIRMATION,
+        ]));
+    }
+
+}

common/tests/unit/models/OauthClientQueryTest.php

@@ -0,0 +1,42 @@
+<?php
+namespace common\tests\unit\models;
+
+use common\models\OauthClient;
+use common\tests\fixtures\OauthClientFixture;
+use common\tests\unit\TestCase;
+
+class OauthClientQueryTest extends TestCase {
+
+    public function _fixtures() {
+        return [
+            'oauthClients' => OauthClientFixture::class,
+        ];
+    }
+
+    public function testDefaultHideDeletedEntries() {
+        /** @var OauthClient[] $clients */
+        $clients = OauthClient::find()->all();
+        $this->assertEmpty(array_filter($clients, function(OauthClient $client) {
+            return (bool)$client->is_deleted === true;
+        }));
+        $this->assertNull(OauthClient::findOne('deleted-oauth-client'));
+    }
+
+    public function testAllowFindDeletedEntries() {
+        /** @var OauthClient[] $clients */
+        $clients = OauthClient::find()->includeDeleted()->all();
+        $this->assertNotEmpty(array_filter($clients, function(OauthClient $client) {
+            return (bool)$client->is_deleted === true;
+        }));
+        $client = OauthClient::find()
+            ->includeDeleted()
+            ->andWhere(['id' => 'deleted-oauth-client'])
+            ->one();
+        $this->assertInstanceOf(OauthClient::class, $client);
+        $deletedClients = OauthClient::find()->onlyDeleted()->all();
+        $this->assertEmpty(array_filter($deletedClients, function(OauthClient $client) {
+            return (bool)$client->is_deleted === false;
+        }));
+    }
+
+}