Rework tests structure. Upgrade codeception to 2.5.3. Merge params configuration into app configuration.

common/tests/unit/validators/EmailValidatorTest.php

@@ -0,0 +1,140 @@
+<?php
+namespace common\tests\unit\validators;
+
+use common\validators\EmailValidator;
+use common\tests\fixtures\AccountFixture;
+use common\tests\helpers\Mock;
+use common\tests\unit\TestCase;
+use yii\base\Model;
+use yii\validators\EmailValidator as YiiEmailValidator;
+
+class EmailValidatorTest extends TestCase {
+
+    /**
+     * @var EmailValidator
+     */
+    private $validator;
+
+    public function _before() {
+        parent::_before();
+        $this->validator = new EmailValidator();
+    }
+
+    public function testValidateTrimming() {
+        // Prevent it to access to db
+        Mock::func(YiiEmailValidator::class, 'checkdnsrr')->andReturn(false);
+
+        $model = $this->createModel("testemail@ely.by\u{feff}"); // Zero width no-break space (U+FEFF)
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertEquals(['error.email_invalid'], $model->getErrors('field'));
+        $this->assertEquals('testemail@ely.by', $model->field);
+    }
+
+    public function testValidateAttributeRequired() {
+        $model = $this->createModel('');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertEquals(['error.email_required'], $model->getErrors('field'));
+
+        $model = $this->createModel('email');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertNotEquals(['error.email_required'], $model->getErrors('field'));
+    }
+
+    public function testValidateAttributeLength() {
+        Mock::func(YiiEmailValidator::class, 'checkdnsrr')->andReturnTrue();
+        $model = $this->createModel(
+            'emailemailemailemailemailemailemailemailemailemailemailemailemailemailemailemailemail' .
+            'emailemailemailemailemailemailemailemailemailemailemailemailemailemailemailemailemail' .
+            'emailemailemailemailemailemailemailemailemailemailemailemailemailemailemailemailemail' .
+            '@gmail.com' // = 256 symbols
+        );
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertEquals(['error.email_too_long'], $model->getErrors('field'));
+
+        $model = $this->createModel('some-email@gmail.com');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertNotEquals(['error.email_too_long'], $model->getErrors('field'));
+    }
+
+    public function testValidateAttributeEmail() {
+        Mock::func(YiiEmailValidator::class, 'checkdnsrr')->times(3)->andReturnValues([false, false, true]);
+
+        $model = $this->createModel('non-email');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertEquals(['error.email_invalid'], $model->getErrors('field'));
+
+        $model = $this->createModel('non-email@etot-domen-ne-suschestrvyet.de');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertEquals(['error.email_invalid'], $model->getErrors('field'));
+
+        $model = $this->createModel('valid-email@gmail.com');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertNotEquals(['error.email_invalid'], $model->getErrors('field'));
+    }
+
+    public function testValidateAttributeTempmail() {
+        Mock::func(YiiEmailValidator::class, 'checkdnsrr')->times(2)->andReturnTrue();
+
+        $model = $this->createModel('ibrpycwyjdnt@dropmail.me');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertEquals(['error.email_is_tempmail'], $model->getErrors('field'));
+
+        $model = $this->createModel('valid-email@gmail.com');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertNotEquals(['error.email_is_tempmail'], $model->getErrors('field'));
+    }
+
+    public function testValidateAttributeIdna() {
+        Mock::func(YiiEmailValidator::class, 'checkdnsrr')->times(2)->andReturnTrue();
+
+        $model = $this->createModel('qdushyantasunassm@❕.gq');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertSame('qdushyantasunassm@xn--bei.gq', $model->field);
+
+        $model = $this->createModel('valid-email@gmail.com');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertSame('valid-email@gmail.com', $model->field);
+    }
+
+    public function testValidateAttributeUnique() {
+        Mock::func(YiiEmailValidator::class, 'checkdnsrr')->times(3)->andReturnTrue();
+
+        $this->tester->haveFixtures([
+            'accounts' => AccountFixture::class,
+        ]);
+
+        /** @var \common\models\Account $accountFixture */
+        $accountFixture = $this->tester->grabFixture('accounts', 'admin');
+
+        $model = $this->createModel($accountFixture->email);
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertEquals(['error.email_not_available'], $model->getErrors('field'));
+
+        $model = $this->createModel($accountFixture->email);
+        $this->validator->accountCallback = function() use ($accountFixture) {
+            return $accountFixture->id;
+        };
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertNotEquals(['error.email_not_available'], $model->getErrors('field'));
+        $this->validator->accountCallback = null;
+
+        $model = $this->createModel('some-unique-email@gmail.com');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertNotEquals(['error.email_not_available'], $model->getErrors('field'));
+    }
+
+    /**
+     * @param string $fieldValue
+     * @return Model
+     */
+    private function createModel(string $fieldValue): Model {
+        $class = new class extends Model {
+            public $field;
+        };
+
+        $class->field = $fieldValue;
+
+        return $class;
+    }
+
+}

common/tests/unit/validators/LanguageValidatorTest.php

@@ -0,0 +1,50 @@
+<?php
+declare(strict_types=1);
+
+namespace common\tests\unit\validators;
+
+use common\validators\LanguageValidator;
+use common\tests\unit\TestCase;
+
+/**
+ * @covers \common\validators\LanguageValidator
+ */
+class LanguageValidatorTest extends TestCase {
+
+    /**
+     * @param string $locale
+     * @param bool $shouldBeValid
+     *
+     * @dataProvider getTestCases
+     */
+    public function testValidate(string $locale, bool $shouldBeValid): void {
+        $validator = new LanguageValidator();
+        $result = $validator->validate($locale, $error);
+        $this->assertSame($shouldBeValid, $result, $locale);
+        if (!$shouldBeValid) {
+            $this->assertSame($validator->message, $error);
+        }
+    }
+
+    public function getTestCases(): array {
+        return [
+            // valid
+            ['de', true],
+            ['de_DE', true],
+            ['deu', true],
+            ['en', true],
+            ['en_US', true],
+            ['fil', true],
+            ['fil_PH', true],
+            ['zh', true],
+            ['zh_Hans_CN', true],
+            ['zh_Hant_HK', true],
+            // invalid
+            ['de_FR', false],
+            ['fr_US', false],
+            ['foo_bar', false],
+            ['foo_bar_baz', false],
+        ];
+    }
+
+}

common/tests/unit/validators/MinecraftServerAddressValidatorTest.php

@@ -0,0 +1,33 @@
+<?php
+namespace common\tests\unit\validators;
+
+use common\validators\MinecraftServerAddressValidator;
+use common\tests\unit\TestCase;
+
+class MinecraftServerAddressValidatorTest extends TestCase {
+
+    /**
+     * @dataProvider domainNames
+     */
+    public function testValidate($address, $shouldBeValid) {
+        $validator = new MinecraftServerAddressValidator();
+        $validator->validate($address, $errors);
+        $this->assertEquals($shouldBeValid, $errors === null);
+    }
+
+    public function domainNames() {
+        return [
+            ['localhost',            true ],
+            ['localhost:25565',      true ],
+            ['mc.hypixel.net',       true ],
+            ['mc.hypixel.net:25565', true ],
+            ['136.243.88.97',        true ],
+            ['136.243.88.97:25565',  true ],
+            ['http://ely.by',        false],
+            ['http://ely.by:80',     false],
+            ['ely.by/abcd',          false],
+            ['ely.by?abcd',          false],
+        ];
+    }
+
+}

common/tests/unit/validators/UsernameValidatorTest.php

@@ -0,0 +1,114 @@
+<?php
+namespace common\tests\unit\validators;
+
+use common\validators\UsernameValidator;
+use common\tests\fixtures\AccountFixture;
+use common\tests\unit\TestCase;
+use yii\base\Model;
+
+class UsernameValidatorTest extends TestCase {
+
+    /**
+     * @var UsernameValidator
+     */
+    private $validator;
+
+    public function _before() {
+        parent::_before();
+        $this->validator = new UsernameValidator();
+    }
+
+    public function testValidateTrimming() {
+        $model = $this->createModel("HereIsJohnny#\u{feff}"); // Zero width no-break space (U+FEFF)
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertEquals(['error.username_invalid'], $model->getErrors('field'));
+        $this->assertEquals('HereIsJohnny#', $model->field);
+    }
+
+    public function testValidateAttributeRequired() {
+        $model = $this->createModel('');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertEquals(['error.username_required'], $model->getErrors('field'));
+
+        $model = $this->createModel('username');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertNotEquals(['error.username_required'], $model->getErrors('field'));
+    }
+
+    public function testValidateAttributeLength() {
+        $model = $this->createModel('at');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertEquals(['error.username_too_short'], $model->getErrors('field'));
+
+        $model = $this->createModel('erickskrauch_erickskrauch');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertEquals(['error.username_too_long'], $model->getErrors('field'));
+
+        $model = $this->createModel('username');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertNotEquals(['error.username_too_short'], $model->getErrors('field'));
+        $this->assertNotEquals(['error.username_too_long'], $model->getErrors('field'));
+    }
+
+    // TODO: rewrite this test with @provider usage
+    public function testValidateAttributePattern() {
+        $shouldBeValid = [
+            'русский_ник', 'русский_ник_на_грани!', 'numbers1132', '*__*-Stars-*__*', '1-_.!$%^&*()[]',
+            '[ESP]Эрик', 'Свят_помидор;', 'зроблена_ў_беларусі:)',
+        ];
+        foreach ($shouldBeValid as $nickname) {
+            $model = $this->createModel($nickname);
+            $this->validator->validateAttribute($model, 'field');
+            $this->assertNotEquals(['error.username_invalid'], $model->getErrors('field'));
+        }
+
+        $shouldBeInvalid = [
+            'nick@name', 'spaced nick', 'im#hashed', 'quest?ion',
+        ];
+        foreach ($shouldBeInvalid as $nickname) {
+            $model = $this->createModel($nickname);
+            $this->validator->validateAttribute($model, 'field');
+            $this->assertEquals(['error.username_invalid'], $model->getErrors('field'));
+        }
+    }
+
+    public function testValidateAttributeUnique() {
+        $this->tester->haveFixtures([
+            'accounts' => AccountFixture::class,
+        ]);
+
+        /** @var \common\models\Account $accountFixture */
+        $accountFixture = $this->tester->grabFixture('accounts', 'admin');
+
+        $model = $this->createModel($accountFixture->username);
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertEquals(['error.username_not_available'], $model->getErrors('field'));
+
+        $model = $this->createModel($accountFixture->username);
+        $this->validator->accountCallback = function() use ($accountFixture) {
+            return $accountFixture->id;
+        };
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertNotEquals(['error.username_not_available'], $model->getErrors('field'));
+        $this->validator->accountCallback = null;
+
+        $model = $this->createModel('some-unique-username');
+        $this->validator->validateAttribute($model, 'field');
+        $this->assertNotEquals(['error.username_not_available'], $model->getErrors('field'));
+    }
+
+    /**
+     * @param string $fieldValue
+     * @return Model
+     */
+    private function createModel(string $fieldValue): Model {
+        $class = new class extends Model {
+            public $field;
+        };
+
+        $class->field = $fieldValue;
+
+        return $class;
+    }
+
+}

common/tests/unit/validators/UuidValidatorTest.php

@@ -0,0 +1,77 @@
+<?php
+namespace common\tests\unit\validators;
+
+use Codeception\Specify;
+use common\validators\UuidValidator;
+use Faker\Provider\Uuid;
+use common\tests\unit\TestCase;
+use yii\base\Model;
+
+class UuidValidatorTest extends TestCase {
+    use Specify;
+
+    public function testValidateAttribute() {
+        $this->specify('expected error if passed empty value', function() {
+            $validator = new UuidValidator();
+            $model = $this->createModel();
+            $validator->validateAttribute($model, 'attribute');
+            $this->assertTrue($model->hasErrors());
+            $this->assertEquals(['Attribute must be valid uuid'], $model->getErrors('attribute'));
+        });
+
+        $this->specify('expected error if passed invalid string', function() {
+            $validator = new UuidValidator();
+            $model = $this->createModel();
+            $model->attribute = '123456789';
+            $validator->validateAttribute($model, 'attribute');
+            $this->assertTrue($model->hasErrors());
+            $this->assertEquals(['Attribute must be valid uuid'], $model->getErrors('attribute'));
+        });
+
+        $this->specify('no errors if passed nil uuid and allowNil is set to true', function() {
+            $validator = new UuidValidator();
+            $model = $this->createModel();
+            $model->attribute = '00000000-0000-0000-0000-000000000000';
+            $validator->validateAttribute($model, 'attribute');
+            $this->assertFalse($model->hasErrors());
+        });
+
+        $this->specify('no errors if passed nil uuid and allowNil is set to false', function() {
+            $validator = new UuidValidator();
+            $validator->allowNil = false;
+            $model = $this->createModel();
+            $model->attribute = '00000000-0000-0000-0000-000000000000';
+            $validator->validateAttribute($model, 'attribute');
+            $this->assertTrue($model->hasErrors());
+            $this->assertEquals(['Attribute must be valid uuid'], $model->getErrors('attribute'));
+        });
+
+        $this->specify('no errors if passed valid uuid', function() {
+            $validator = new UuidValidator();
+            $model = $this->createModel();
+            $model->attribute = Uuid::uuid();
+            $validator->validateAttribute($model, 'attribute');
+            $this->assertFalse($model->hasErrors());
+        });
+
+        $this->specify('no errors if passed uuid string without dashes and converted to standart value', function() {
+            $validator = new UuidValidator();
+            $model = $this->createModel();
+            $originalUuid = Uuid::uuid();
+            $model->attribute = str_replace('-', '', $originalUuid);
+            $validator->validateAttribute($model, 'attribute');
+            $this->assertFalse($model->hasErrors());
+            $this->assertEquals($originalUuid, $model->attribute);
+        });
+    }
+
+    /**
+     * @return Model
+     */
+    public function createModel() {
+        return new class extends Model {
+            public $attribute;
+        };
+    }
+
+}