From a0d940f8cdb354d439943e07c848f4bc8c5011eb Mon Sep 17 00:00:00 2001 From: ErickSkrauch Date: Fri, 26 Aug 2016 22:08:53 +0300 Subject: [PATCH 1/5] =?UTF-8?q?=D0=9F=D0=BE=D0=BF=D1=8B=D1=82=D0=BA=D0=B0?= =?UTF-8?q?=20=D0=B2=D0=BD=D0=B5=D0=B4=D1=80=D0=B8=D1=82=D1=8C=20statsd?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- data/statsd/.gitignore | 2 ++ docker-compose.base.yml | 5 +++++ docker-compose.dev.yml | 8 ++++++++ lib/routes/Textures.go | 1 + lib/services/services.go | 3 +++ minecraft-skinsystem.go | 14 ++++++++++++++ 6 files changed, 33 insertions(+) create mode 100644 data/statsd/.gitignore diff --git a/data/statsd/.gitignore b/data/statsd/.gitignore new file mode 100644 index 0000000..d6b7ef3 --- /dev/null +++ b/data/statsd/.gitignore @@ -0,0 +1,2 @@ +* +!.gitignore diff --git a/docker-compose.base.yml b/docker-compose.base.yml index d8df429..1ffb478 100644 --- a/docker-compose.base.yml +++ b/docker-compose.base.yml @@ -11,3 +11,8 @@ services: RABBITMQ_DEFAULT_USER: "ely-skinsystem-app" RABBITMQ_DEFAULT_PASS: "ely-skinsystem-app-password" RABBITMQ_DEFAULT_VHOST: "/ely" + + statsd: + image: hopsoft/graphite-statsd + volumes: + - ./data/statsd:/opt/graphite/storage diff --git a/docker-compose.dev.yml b/docker-compose.dev.yml index db6d8c0..c5e919d 100644 --- a/docker-compose.dev.yml +++ b/docker-compose.dev.yml @@ -11,6 +11,7 @@ services: links: - redis - rabbitmq + - statsd redis: extends: @@ -21,3 +22,10 @@ services: extends: file: docker-compose.base.yml service: rabbitmq + + statsd: + extends: + file: docker-compose.base.yml + service: statsd + ports: + - "8123:80" diff --git a/lib/routes/Textures.go b/lib/routes/Textures.go index b1cd1ae..e0c10fc 100644 --- a/lib/routes/Textures.go +++ b/lib/routes/Textures.go @@ -13,6 +13,7 @@ import ( ) func Textures(w http.ResponseWriter, r *http.Request) { + services.Stats.Incr("textures-requests", 1) username := tools.ParseUsername(mux.Vars(r)["username"]) log.Println("request textures for username " + username) diff --git a/lib/services/services.go b/lib/services/services.go index e4ce93d..c1906d6 100644 --- a/lib/services/services.go +++ b/lib/services/services.go @@ -4,6 +4,7 @@ import ( "github.com/mediocregopher/radix.v2/pool" "github.com/streadway/amqp" "github.com/gorilla/mux" + "github.com/quipo/statsd" ) var Router *mux.Router @@ -13,3 +14,5 @@ var RedisPool *pool.Pool var RabbitMQChannel *amqp.Channel var RootFolder string + +var Stats *statsd.StatsdBuffer diff --git a/minecraft-skinsystem.go b/minecraft-skinsystem.go index 9f90837..a125015 100644 --- a/minecraft-skinsystem.go +++ b/minecraft-skinsystem.go @@ -11,6 +11,8 @@ import ( "github.com/gorilla/mux" "github.com/streadway/amqp" "github.com/mediocregopher/radix.v2/pool" + "github.com/quipo/statsd" + //"github.com/mediocregopher/radix.v2/redis" "elyby/minecraft-skinsystem/lib/routes" "elyby/minecraft-skinsystem/lib/services" @@ -56,6 +58,17 @@ func main() { } log.Println("Connected to rabbitmq channel") + // init + statsClient := statsd.NewStatsdClient(statsString, "skinsystem.") + statsErr := statsClient.CreateSocket() + if statsErr != nil { + log.Fatal(statsErr) + } + + interval := 2 * time.Second // aggregate stats and flush every 2 seconds + stats := statsd.NewStatsdBuffer(interval, statsClient) + defer stats.Close() + router := mux.NewRouter().StrictSlash(true) router.HandleFunc("/skins/{username}", routes.Skin).Methods("GET").Name("skins") router.HandleFunc("/cloaks/{username}", routes.Cape).Methods("GET").Name("cloaks") @@ -75,6 +88,7 @@ func main() { services.Router = router services.RedisPool = redisPool services.RabbitMQChannel = rabbitChannel + services.Stats = stats _, file, _, _ := runtime.Caller(0) services.RootFolder = filepath.Dir(file) From 66c61dc3cd091812c8c7ac1b871d4f1338b5758c Mon Sep 17 00:00:00 2001 From: ErickSkrauch Date: Sat, 3 Dec 2016 01:57:55 +0300 Subject: [PATCH 2/5] =?UTF-8?q?=D0=94=D0=BE=D0=B1=D0=B0=D0=B2=D0=BB=D0=B5?= =?UTF-8?q?=D0=BD=D0=BE=20=D0=BB=D0=BE=D0=B3=D0=B3=D0=B8=D1=80=D0=BE=D0=B2?= =?UTF-8?q?=D0=B0=D0=BD=D0=B8=D0=B5=20=D0=BC=D0=B5=D1=82=D1=80=D0=B8=D0=BA?= =?UTF-8?q?=20=D0=B4=D0=BB=D1=8F=20=D1=81=D0=B8=D1=81=D1=82=D0=B5=D0=BC?= =?UTF-8?q?=D1=8B=20=D1=81=D0=BA=D0=B8=D0=BD=D0=BE=D0=B2?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- lib/data/SkinItem.go | 3 +++ lib/routes/Cape.go | 9 +++++++-- lib/routes/Face.go | 2 -- lib/routes/MinecraftPHP.go | 14 ++++++++++---- lib/routes/Skin.go | 9 +++++++-- lib/routes/Textures.go | 3 +-- lib/services/services.go | 4 ++-- lib/worker/handlers.go | 10 +++++++--- minecraft-skinsystem.go | 33 ++++++++++++++++++++++----------- 9 files changed, 59 insertions(+), 28 deletions(-) diff --git a/lib/data/SkinItem.go b/lib/data/SkinItem.go index 8ad55d7..6e0eabb 100644 --- a/lib/data/SkinItem.go +++ b/lib/data/SkinItem.go @@ -62,13 +62,16 @@ func (s *SkinItem) Delete() { func FindSkinByUsername(username string) (SkinItem, error) { var record SkinItem; + services.Logger.IncCounter("skins.storage.query", 1) response := services.RedisPool.Cmd("GET", tools.BuildKey(username)); if (response.IsType(redis.Nil)) { + services.Logger.IncCounter("skins.storage.not_found", 1) return record, SkinNotFound{username} } result, err := response.Str() if (err == nil) { + services.Logger.IncCounter("skins.storage.found", 1) decodeErr := json.Unmarshal([]byte(result), &record) if (decodeErr != nil) { log.Println("Cannot decode record data") diff --git a/lib/routes/Cape.go b/lib/routes/Cape.go index 9d87832..ade4d55 100644 --- a/lib/routes/Cape.go +++ b/lib/routes/Cape.go @@ -2,18 +2,21 @@ package routes import ( "io" - "log" "net/http" "github.com/gorilla/mux" "elyby/minecraft-skinsystem/lib/tools" "elyby/minecraft-skinsystem/lib/data" + "elyby/minecraft-skinsystem/lib/services" ) func Cape(response http.ResponseWriter, request *http.Request) { + if (mux.Vars(request)["converted"] == "") { + services.Logger.IncCounter("capes.request", 1) + } + username := tools.ParseUsername(mux.Vars(request)["username"]) - log.Println("request cape for username " + username) rec, err := data.FindCapeByUsername(username) if (err != nil) { http.Redirect(response, request, "http://skins.minecraft.net/MinecraftCloaks/" + username + ".png", 301) @@ -24,6 +27,7 @@ func Cape(response http.ResponseWriter, request *http.Request) { } func CapeGET(w http.ResponseWriter, r *http.Request) { + services.Logger.IncCounter("capes.get-request", 1) username := r.URL.Query().Get("name") if username == "" { w.WriteHeader(http.StatusBadRequest) @@ -31,5 +35,6 @@ func CapeGET(w http.ResponseWriter, r *http.Request) { } mux.Vars(r)["username"] = username + mux.Vars(r)["converted"] = "1" Cape(w, r) } diff --git a/lib/routes/Face.go b/lib/routes/Face.go index 574d1e4..24a662d 100644 --- a/lib/routes/Face.go +++ b/lib/routes/Face.go @@ -1,7 +1,6 @@ package routes import ( - "log" "net/http" "github.com/gorilla/mux" @@ -14,7 +13,6 @@ const defaultHash = "default" func Face(w http.ResponseWriter, r *http.Request) { username := tools.ParseUsername(mux.Vars(r)["username"]) - log.Println("request skin for username " + username); rec, err := data.FindSkinByUsername(username) var hash string if (err != nil || rec.SkinId == 0) { diff --git a/lib/routes/MinecraftPHP.go b/lib/routes/MinecraftPHP.go index 3457662..dc237df 100644 --- a/lib/routes/MinecraftPHP.go +++ b/lib/routes/MinecraftPHP.go @@ -4,6 +4,8 @@ import ( "net/http" "github.com/gorilla/mux" + + "elyby/minecraft-skinsystem/lib/services" ) // Метод-наследие от первой версии системы скинов. @@ -18,11 +20,15 @@ func MinecraftPHP(w http.ResponseWriter, r *http.Request) { } mux.Vars(r)["username"] = username + mux.Vars(r)["converted"] = "1" switch required { - case "skin": Skin(w, r) - case "cloack": Cape(w, r) - default: { + case "skin": + services.Logger.IncCounter("skins.minecraft-php-request", 1) + Skin(w, r) + case "cloack": + services.Logger.IncCounter("capes.minecraft-php-request", 1) + Cape(w, r) + default: w.WriteHeader(http.StatusNotFound) } - } } diff --git a/lib/routes/Skin.go b/lib/routes/Skin.go index 97a1e5c..5eab058 100644 --- a/lib/routes/Skin.go +++ b/lib/routes/Skin.go @@ -1,18 +1,21 @@ package routes import ( - "log" "net/http" "github.com/gorilla/mux" "elyby/minecraft-skinsystem/lib/tools" "elyby/minecraft-skinsystem/lib/data" + "elyby/minecraft-skinsystem/lib/services" ) func Skin(w http.ResponseWriter, r *http.Request) { + if (mux.Vars(r)["converted"] == "") { + services.Logger.IncCounter("skins.request", 1) + } + username := tools.ParseUsername(mux.Vars(r)["username"]) - log.Println("request skin for username " + username); rec, err := data.FindSkinByUsername(username) if (err != nil) { http.Redirect(w, r, "http://skins.minecraft.net/MinecraftSkins/" + username + ".png", 301) @@ -23,6 +26,7 @@ func Skin(w http.ResponseWriter, r *http.Request) { } func SkinGET(w http.ResponseWriter, r *http.Request) { + services.Logger.IncCounter("skins.get-request", 1) username := r.URL.Query().Get("name") if username == "" { w.WriteHeader(http.StatusBadRequest) @@ -30,5 +34,6 @@ func SkinGET(w http.ResponseWriter, r *http.Request) { } mux.Vars(r)["username"] = username + mux.Vars(r)["converted"] = "1" Skin(w, r) } diff --git a/lib/routes/Textures.go b/lib/routes/Textures.go index e0c10fc..7d324fb 100644 --- a/lib/routes/Textures.go +++ b/lib/routes/Textures.go @@ -13,9 +13,8 @@ import ( ) func Textures(w http.ResponseWriter, r *http.Request) { - services.Stats.Incr("textures-requests", 1) + services.Logger.IncCounter("textures.request", 1) username := tools.ParseUsername(mux.Vars(r)["username"]) - log.Println("request textures for username " + username) rec, err := data.FindSkinByUsername(username) if (err != nil || rec.SkinId == 0) { diff --git a/lib/services/services.go b/lib/services/services.go index c1906d6..07e8c70 100644 --- a/lib/services/services.go +++ b/lib/services/services.go @@ -4,7 +4,7 @@ import ( "github.com/mediocregopher/radix.v2/pool" "github.com/streadway/amqp" "github.com/gorilla/mux" - "github.com/quipo/statsd" + "github.com/mono83/slf/wd" ) var Router *mux.Router @@ -15,4 +15,4 @@ var RabbitMQChannel *amqp.Channel var RootFolder string -var Stats *statsd.StatsdBuffer +var Logger wd.Watchdog diff --git a/lib/worker/handlers.go b/lib/worker/handlers.go index 36186f8..3b0abaf 100644 --- a/lib/worker/handlers.go +++ b/lib/worker/handlers.go @@ -2,11 +2,12 @@ package worker import ( "elyby/minecraft-skinsystem/lib/data" - "log" + "elyby/minecraft-skinsystem/lib/services" ) func handleChangeUsername(model usernameChanged) (bool) { if (model.OldUsername == "") { + services.Logger.IncCounter("worker.change_username.empty_old_username") record := data.SkinItem{ UserId: model.AccountId, Username: model.NewUsername, @@ -19,7 +20,7 @@ func handleChangeUsername(model usernameChanged) (bool) { record, err := data.FindSkinByUsername(model.OldUsername) if (err != nil) { - log.Println("Exit by not found record") + services.Logger.IncCounter("worker.change_username.username_not_found") // TODO: я не уверен, что это валидное поведение // Суть в том, что здесь может возникнуть ошибка в том случае, если записи в базе нету // а значит его нужно, как минимум, зарегистрировать @@ -29,7 +30,7 @@ func handleChangeUsername(model usernameChanged) (bool) { record.Username = model.NewUsername record.Save() - log.Println("all saved!") + services.Logger.IncCounter("worker.change_username.processed") return true } @@ -37,6 +38,7 @@ func handleChangeUsername(model usernameChanged) (bool) { func handleSkinChanged(model skinChanged) (bool) { record, err := data.FindSkinById(model.AccountId) if (err != nil) { + services.Logger.IncCounter("worker.skin_changed.id_not_found") return true } @@ -48,5 +50,7 @@ func handleSkinChanged(model skinChanged) (bool) { record.Save() + services.Logger.IncCounter("worker.skin_changed.processed") + return true } diff --git a/minecraft-skinsystem.go b/minecraft-skinsystem.go index a125015..7ee7e7a 100644 --- a/minecraft-skinsystem.go +++ b/minecraft-skinsystem.go @@ -11,8 +11,10 @@ import ( "github.com/gorilla/mux" "github.com/streadway/amqp" "github.com/mediocregopher/radix.v2/pool" - "github.com/quipo/statsd" - //"github.com/mediocregopher/radix.v2/redis" + "github.com/mono83/slf/wd" + "github.com/mono83/slf/rays" + "github.com/mono83/slf/recievers/ansi" + "github.com/mono83/slf/recievers/statsd" "elyby/minecraft-skinsystem/lib/routes" "elyby/minecraft-skinsystem/lib/services" @@ -58,16 +60,25 @@ func main() { } log.Println("Connected to rabbitmq channel") - // init - statsClient := statsd.NewStatsdClient(statsString, "skinsystem.") - statsErr := statsClient.CreateSocket() - if statsErr != nil { - log.Fatal(statsErr) + // statsd + var statsdString = os.Getenv("STATSD_ADDR") + if (statsdString != "") { + hostname, _ := os.Hostname() + statsdReceiver, err := statsd.NewReceiver(statsd.Config{ + Address: statsdString, + Prefix: "ely.skinsystem." + hostname + ".", + FlushEvery: 2, + }) + if (err != nil) { + log.Fatal("statsd connection error") + } + + wd.AddReceiver(statsdReceiver) + } else { + wd.AddReceiver(ansi.New(true, true, false)) } - interval := 2 * time.Second // aggregate stats and flush every 2 seconds - stats := statsd.NewStatsdBuffer(interval, statsClient) - defer stats.Close() + logger := wd.New("", "").WithParams(rays.Host) router := mux.NewRouter().StrictSlash(true) router.HandleFunc("/skins/{username}", routes.Skin).Methods("GET").Name("skins") @@ -88,7 +99,7 @@ func main() { services.Router = router services.RedisPool = redisPool services.RabbitMQChannel = rabbitChannel - services.Stats = stats + services.Logger = logger _, file, _, _ := runtime.Caller(0) services.RootFolder = filepath.Dir(file) From 201a257d69e83c34e95b355d61c58df50ce29f1b Mon Sep 17 00:00:00 2001 From: ErickSkrauch Date: Sat, 25 Mar 2017 15:54:17 +0300 Subject: [PATCH 3/5] =?UTF-8?q?=D0=98=D1=81=D0=BF=D1=80=D0=B0=D0=B2=D0=BB?= =?UTF-8?q?=D0=B5=D0=BD=D1=8B=20=D0=B2=D1=8B=D0=B7=D0=BE=D0=B2=D1=8B=20Inc?= =?UTF-8?q?Counter=20=D0=B4=D0=BB=D1=8F=20=D0=BE=D0=B1=D1=80=D0=B0=D0=B1?= =?UTF-8?q?=D0=BE=D1=82=D1=87=D0=B8=D0=BA=D0=BE=D0=B2=20=D0=B7=D0=B0=D0=B4?= =?UTF-8?q?=D0=B0=D1=87=20=D0=B8=D0=B7=20amqp?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- lib/worker/handlers.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/worker/handlers.go b/lib/worker/handlers.go index 3b0abaf..b573275 100644 --- a/lib/worker/handlers.go +++ b/lib/worker/handlers.go @@ -7,7 +7,7 @@ import ( func handleChangeUsername(model usernameChanged) (bool) { if (model.OldUsername == "") { - services.Logger.IncCounter("worker.change_username.empty_old_username") + services.Logger.IncCounter("worker.change_username.empty_old_username", 1) record := data.SkinItem{ UserId: model.AccountId, Username: model.NewUsername, @@ -20,7 +20,7 @@ func handleChangeUsername(model usernameChanged) (bool) { record, err := data.FindSkinByUsername(model.OldUsername) if (err != nil) { - services.Logger.IncCounter("worker.change_username.username_not_found") + services.Logger.IncCounter("worker.change_username.username_not_found", 1) // TODO: я не уверен, что это валидное поведение // Суть в том, что здесь может возникнуть ошибка в том случае, если записи в базе нету // а значит его нужно, как минимум, зарегистрировать @@ -30,7 +30,7 @@ func handleChangeUsername(model usernameChanged) (bool) { record.Username = model.NewUsername record.Save() - services.Logger.IncCounter("worker.change_username.processed") + services.Logger.IncCounter("worker.change_username.processed", 1) return true } @@ -38,7 +38,7 @@ func handleChangeUsername(model usernameChanged) (bool) { func handleSkinChanged(model skinChanged) (bool) { record, err := data.FindSkinById(model.AccountId) if (err != nil) { - services.Logger.IncCounter("worker.skin_changed.id_not_found") + services.Logger.IncCounter("worker.skin_changed.id_not_found", 1) return true } @@ -50,7 +50,7 @@ func handleSkinChanged(model skinChanged) (bool) { record.Save() - services.Logger.IncCounter("worker.skin_changed.processed") + services.Logger.IncCounter("worker.skin_changed.processed", 1) return true } From 6a881a62e3e4f06610116820cceee1952d100f75 Mon Sep 17 00:00:00 2001 From: ErickSkrauch Date: Sat, 25 Mar 2017 15:55:57 +0300 Subject: [PATCH 4/5] =?UTF-8?q?=D0=94=D0=BE=D1=80=D0=B0=D0=B1=D0=BE=D1=82?= =?UTF-8?q?=D0=B0=D0=BD=D0=B0=20=D0=BA=D0=BE=D0=BD=D1=84=D0=B8=D0=B3=D1=83?= =?UTF-8?q?=D1=80=D0=B0=D1=86=D0=B8=D1=8F=20=D0=B2=D0=B7=D0=B0=D0=B8=D0=BC?= =?UTF-8?q?=D0=BE=D0=B4=D0=B5=D0=B9=D1=81=D1=82=D0=B2=D0=B8=D1=8F=20=D1=81?= =?UTF-8?q?=D0=BE=20statsd?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- minecraft-skinsystem.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/minecraft-skinsystem.go b/minecraft-skinsystem.go index 7ee7e7a..989f7a8 100644 --- a/minecraft-skinsystem.go +++ b/minecraft-skinsystem.go @@ -63,11 +63,12 @@ func main() { // statsd var statsdString = os.Getenv("STATSD_ADDR") if (statsdString != "") { + log.Println("Connecting to statsd") hostname, _ := os.Hostname() statsdReceiver, err := statsd.NewReceiver(statsd.Config{ Address: statsdString, - Prefix: "ely.skinsystem." + hostname + ".", - FlushEvery: 2, + Prefix: "ely.skinsystem." + hostname + ".app.", + FlushEvery: 1, }) if (err != nil) { log.Fatal("statsd connection error") From c74151c5588945f2902c51073b8d3fc1edaafb7f Mon Sep 17 00:00:00 2001 From: ErickSkrauch Date: Sat, 25 Mar 2017 16:36:37 +0300 Subject: [PATCH 5/5] =?UTF-8?q?=D0=9F=D0=B5=D1=80=D0=B5=D0=B8=D0=BC=D0=B5?= =?UTF-8?q?=D0=BD=D0=BE=D0=B2=D0=B0=D0=BD=D1=8B=20=D0=BD=D0=B5=D0=BA=D0=BE?= =?UTF-8?q?=D1=82=D0=BE=D1=80=D1=8B=D0=B5=20=D0=BF=D0=B0=D1=80=D0=B0=D0=BC?= =?UTF-8?q?=D0=B5=D1=82=D1=80=D1=8B=20=D0=B4=D0=BB=D1=8F=20statsd?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- lib/data/SkinItem.go | 6 +++--- lib/routes/Cape.go | 2 +- lib/routes/Skin.go | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/data/SkinItem.go b/lib/data/SkinItem.go index 6e0eabb..cc19253 100644 --- a/lib/data/SkinItem.go +++ b/lib/data/SkinItem.go @@ -62,16 +62,16 @@ func (s *SkinItem) Delete() { func FindSkinByUsername(username string) (SkinItem, error) { var record SkinItem; - services.Logger.IncCounter("skins.storage.query", 1) + services.Logger.IncCounter("storage.query", 1) response := services.RedisPool.Cmd("GET", tools.BuildKey(username)); if (response.IsType(redis.Nil)) { - services.Logger.IncCounter("skins.storage.not_found", 1) + services.Logger.IncCounter("storage.not_found", 1) return record, SkinNotFound{username} } result, err := response.Str() if (err == nil) { - services.Logger.IncCounter("skins.storage.found", 1) + services.Logger.IncCounter("storage.found", 1) decodeErr := json.Unmarshal([]byte(result), &record) if (decodeErr != nil) { log.Println("Cannot decode record data") diff --git a/lib/routes/Cape.go b/lib/routes/Cape.go index ade4d55..d0560ca 100644 --- a/lib/routes/Cape.go +++ b/lib/routes/Cape.go @@ -27,7 +27,7 @@ func Cape(response http.ResponseWriter, request *http.Request) { } func CapeGET(w http.ResponseWriter, r *http.Request) { - services.Logger.IncCounter("capes.get-request", 1) + services.Logger.IncCounter("capes.get_request", 1) username := r.URL.Query().Get("name") if username == "" { w.WriteHeader(http.StatusBadRequest) diff --git a/lib/routes/Skin.go b/lib/routes/Skin.go index 5eab058..49f3a31 100644 --- a/lib/routes/Skin.go +++ b/lib/routes/Skin.go @@ -26,7 +26,7 @@ func Skin(w http.ResponseWriter, r *http.Request) { } func SkinGET(w http.ResponseWriter, r *http.Request) { - services.Logger.IncCounter("skins.get-request", 1) + services.Logger.IncCounter("skins.get_request", 1) username := r.URL.Query().Get("name") if username == "" { w.WriteHeader(http.StatusBadRequest)