ElyBy-Mirror/oauth2-server
1
0
Fork 0
mirror of https://github.com/elyby/oauth2-server.git synced 2024-12-28 16:00:24 +05:30
Code Issues Packages Projects Releases Wiki Activity

Validate codeVerifier and codeChallenge correctly.

Browse Source
This commit is contained in:
Erick Torres 2017-06-16 12:02:48 -05:00 committed by Erick Torres
parent 2482630221
commit 2167edf1d9
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/Grant/AuthCodeGrant.php
View File

@ -134,6 +134,17 @@ class AuthCodeGrant extends AbstractAuthorizeGrant
throw OAuthServerException::invalidRequest('code_verifier'); throw OAuthServerException::invalidRequest('code_verifier');
} }
// Validate code_verifier according to RFC-7636
// @see: https://tools.ietf.org/html/rfc7636#section-4.1
$isValidCodeVerifier = (bool) preg_match('#[A-Za-z0-9\-|\.|\_|\~]{43,128}#', $codeVerifier);
if ($isValidCodeVerifier === false) {
throw OAuthServerException::invalidRequest(
'code_verifier',
'Code Verifier must follow the specifications of RFC-7636.'
);
}
switch ($authCodePayload->code_challenge_method) { switch ($authCodePayload->code_challenge_method) {
case 'plain': case 'plain':
if (hash_equals($codeVerifier, $authCodePayload->code_challenge) === false) { if (hash_equals($codeVerifier, $authCodePayload->code_challenge) === false) {
@ -272,6 +283,17 @@ class AuthCodeGrant extends AbstractAuthorizeGrant
); );
} }
// Validate code_challenge according to RFC-7636
// @see: https://tools.ietf.org/html/rfc7636#section-4.2
$isValidCodeChallenge = (bool) preg_match('#[A-Za-z0-9\-|\.|\_|\~]{43}#', $codeChallenge);
if ($isValidCodeChallenge === false) {
throw OAuthServerException::invalidRequest(
'code_challenged',
'Code challenge must follow the specifications of RFC-7636.'
);
}
$authorizationRequest->setCodeChallenge($codeChallenge); $authorizationRequest->setCodeChallenge($codeChallenge);
$authorizationRequest->setCodeChallengeMethod($codeChallengeMethod); $authorizationRequest->setCodeChallengeMethod($codeChallengeMethod);
} }