ProjectSegfault/invidious-experimenting
4
0
Fork 0
forked from midou/invidious
Code Pull Requests Activity

Merge pull request #3116 from DoodlesEpic/fix-reddit-comments-nojs-ytkids

Browse Source 
Fix document is empty error on yt kids video when reddit comments are enabled
This commit is contained in:
Samantaz Fox 2022-06-09 00:33:09 +02:00
commit 23cd04fe88
No known key found for this signature in database
GPG Key ID: F42821059186176E
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/invidious/comments.cr
View File

@ -500,6 +500,12 @@ def template_reddit_comments(root, locale)
end end
def replace_links(html) def replace_links(html)
# Check if the document is empty
# Prevents edge-case bug with Reddit comments, see issue #3115
if html.nil? || html.empty?
return html
end
html = XML.parse_html(html) html = XML.parse_html(html)
html.xpath_nodes(%q(//a)).each do |anchor| html.xpath_nodes(%q(//a)).each do |anchor|
@ -541,6 +547,12 @@ def replace_links(html)
end end
def fill_links(html, scheme, host) def fill_links(html, scheme, host)
# Check if the document is empty
# Prevents edge-case bug with Reddit comments, see issue #3115
if html.nil? || html.empty?
return html
end
html = XML.parse_html(html) html = XML.parse_html(html)
html.xpath_nodes("//a").each do |match| html.xpath_nodes("//a").each do |match|