emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

modprobe-small: fix "modprobe non-existing-module" exitcode (should be 1)

Browse Source 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2017-04-06 13:45:00 +02:00
parent 803c85a207
commit 0d6e3ad663
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
modutils/modprobe-small.c
View File

@ -765,9 +765,12 @@ static int process_module(char *name, const char *cmdline_options)
if (!infovec) { if (!infovec) {
/* both dirscan and find_alias found nothing */ /* both dirscan and find_alias found nothing */
if (!is_remove && !is_depmod) /* it wasn't rmmod or depmod */ if (!is_remove && !is_depmod) { /* it wasn't rmmod or depmod */
bb_error_msg("module '%s' not found", name); bb_error_msg("module '%s' not found", name);
//TODO: _and_die()? or should we continue (un)loading modules listed on cmdline? //TODO: _and_die()? or should we continue (un)loading modules listed on cmdline?
/* "modprobe non-existing-module; echo $?" must print 1 */
exitcode = EXIT_FAILURE;
}
goto ret; goto ret;
} }