emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tls: covert i/o loop from using select() to poll()

Browse Source 
function                                             old     new   delta
tls_run_copy_loop                                    377     282     -95

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2017-02-16 16:27:39 +01:00
parent c39ee04705
commit 0ec4d08ea3
1 changed files with 11 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
networking/tls.c
View File

@ -1740,26 +1740,23 @@ static void tls_xwrite(tls_state_t *tls, int len)
void FAST_FUNC tls_run_copy_loop(tls_state_t *tls) void FAST_FUNC tls_run_copy_loop(tls_state_t *tls)
{ {
fd_set readfds;
int inbuf_size; int inbuf_size;
const int INBUF_STEP = 4 * 1024; const int INBUF_STEP = 4 * 1024;
struct pollfd pfds[2];
//TODO: convert to poll pfds[0].fd = STDIN_FILENO;
/* Select loop copying stdin to ofd, and ifd to stdout */ pfds[0].events = POLLIN;
FD_ZERO(&readfds); pfds[1].fd = tls->ifd;
FD_SET(tls->ifd, &readfds); pfds[1].events = POLLIN;
FD_SET(STDIN_FILENO, &readfds);
inbuf_size = INBUF_STEP; inbuf_size = INBUF_STEP;
for (;;) { for (;;) {
fd_set testfds;
int nread; int nread;
testfds = readfds; if (safe_poll(pfds, 2, -1) < 0)
if (select(tls->ifd + 1, &testfds, NULL, NULL, NULL) < 0) bb_perror_msg_and_die("poll");
bb_perror_msg_and_die("select");
if (FD_ISSET(STDIN_FILENO, &testfds)) { if (pfds[0].revents) {
void *buf; void *buf;
dbg("STDIN HAS DATA\n"); dbg("STDIN HAS DATA\n");
@ -1774,7 +1771,7 @@ void FAST_FUNC tls_run_copy_loop(tls_state_t *tls)
/* But TLS has no way to encode this, /* But TLS has no way to encode this,
* doubt it's ok to do it "raw" * doubt it's ok to do it "raw"
*/ */
FD_CLR(STDIN_FILENO, &readfds); pfds[0].fd = -1;
tls_free_outbuf(tls); /* mem usage optimization */ tls_free_outbuf(tls); /* mem usage optimization */
} else { } else {
if (nread == inbuf_size) { if (nread == inbuf_size) {
@ -1788,7 +1785,7 @@ void FAST_FUNC tls_run_copy_loop(tls_state_t *tls)
tls_xwrite(tls, nread); tls_xwrite(tls, nread);
} }
} }
if (FD_ISSET(tls->ifd, &testfds)) { if (pfds[1].revents) {
dbg("NETWORK HAS DATA\n"); dbg("NETWORK HAS DATA\n");
read_record: read_record:
nread = tls_xread_record(tls); nread = tls_xread_record(tls);
@ -1796,7 +1793,7 @@ void FAST_FUNC tls_run_copy_loop(tls_state_t *tls)
/* TLS protocol has no real concept of one-sided shutdowns: /* TLS protocol has no real concept of one-sided shutdowns:
* if we get "TLS EOF" from the peer, writes will fail too * if we get "TLS EOF" from the peer, writes will fail too
*/ */
//FD_CLR(tls->ifd, &readfds); //pfds[1].fd = -1;
//close(STDOUT_FILENO); //close(STDOUT_FILENO);
//tls_free_inbuf(tls); /* mem usage optimization */ //tls_free_inbuf(tls); /* mem usage optimization */
//continue; //continue;