emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pstree: fix theoretically unsafe code

Browse Source 
In practice, p->comm is never long enough to trigger the bug, but still.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2013-06-28 01:59:25 +02:00
parent 26a7e2ecbf
commit 173aa78bcf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
procps/pstree.c
View File

@ -349,7 +349,7 @@ static void dump_by_user(PROC *current, uid_t uid)
static void handle_thread(const char *comm, pid_t pid, pid_t ppid, uid_t uid) static void handle_thread(const char *comm, pid_t pid, pid_t ppid, uid_t uid)
{ {
char threadname[COMM_DISP_LEN + 1]; char threadname[COMM_DISP_LEN + 1];
sprintf(threadname, "{%.*s}", (int)sizeof(threadname) - 1, comm); sprintf(threadname, "{%.*s}", (int)sizeof(threadname) - 3, comm);
add_proc(threadname, pid, ppid, uid/*, 1*/); add_proc(threadname, pid, ppid, uid/*, 1*/);
} }
#endif #endif