emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tail: sizeof(buf) is sizeof(char*)! must be BUFSIZ

Browse Source
This commit is contained in:
Denis Vlasenko 2007-10-05 19:17:16 +00:00
parent d21f596ddb
commit 226002ea74
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
coreutils/tail.c
View File

@ -57,7 +57,7 @@ static ssize_t tail_read(int fd, char *buf, size_t count)
if (sbuf.st_size < current) if (sbuf.st_size < current)
lseek(fd, 0, SEEK_SET); lseek(fd, 0, SEEK_SET);
r = safe_read(fd, buf, count); r = full_read(fd, buf, count);
if (r < 0) { if (r < 0) {
bb_perror_msg(bb_msg_read_error); bb_perror_msg(bb_msg_read_error);
G.status = EXIT_FAILURE; G.status = EXIT_FAILURE;
@ -271,7 +271,7 @@ int tail_main(int argc, char **argv)
if (nfiles > header_threshhold) { if (nfiles > header_threshhold) {
fmt = header_fmt; fmt = header_fmt;
} }
while ((nread = tail_read(fds[i], buf, sizeof(buf))) > 0) { while ((nread = tail_read(fds[i], buf, BUFSIZ)) > 0) {
if (fmt) { if (fmt) {
tail_xprint_header(fmt, argv[i]); tail_xprint_header(fmt, argv[i]);
fmt = NULL; fmt = NULL;