emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove some dead assignments, add a TODO comment

Browse Source 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2010-07-04 04:26:55 +02:00
parent fd744519d1
commit 243d1757d7
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
archival/libunarchive/data_extract_all.c
View File

@ -127,6 +127,7 @@ void FAST_FUNC data_extract_all(archive_handle_t *archive_handle)
break; break;
case S_IFLNK: case S_IFLNK:
/* Symlink */ /* Symlink */
//TODO: what if file_header->link_target == NULL (say, corrupted tarball?)
res = symlink(file_header->link_target, file_header->name); res = symlink(file_header->link_target, file_header->name);
if ((res == -1) if ((res == -1)
&& !(archive_handle->ah_flags & ARCHIVE_EXTRACT_QUIET) && !(archive_handle->ah_flags & ARCHIVE_EXTRACT_QUIET)

1
editors/vi.c
View File

@ -2385,7 +2385,6 @@ static int file_write(char *fn, char *first, char *last)
status_line_bold("No current filename"); status_line_bold("No current filename");
return -2; return -2;
} }
charcnt = 0;
/* By popular request we do not open file with O_TRUNC, /* By popular request we do not open file with O_TRUNC,
* but instead ftruncate() it _after_ successful write. * but instead ftruncate() it _after_ successful write.
* Might reduce amount of data lost on power fail etc. * Might reduce amount of data lost on power fail etc.

3
networking/udhcp/dhcprelay.c
View File

@ -175,7 +175,6 @@ static void pass_to_server(struct dhcp_packet *p, int packet_len, int client, in
struct sockaddr_in *client_addr, struct sockaddr_in *server_addr) struct sockaddr_in *client_addr, struct sockaddr_in *server_addr)
{ {
int res, type; int res, type;
struct xid_item *item;
/* check packet_type */ /* check packet_type */
type = get_dhcp_packet_type(p); type = get_dhcp_packet_type(p);
@ -187,7 +186,7 @@ static void pass_to_server(struct dhcp_packet *p, int packet_len, int client, in
} }
/* create new xid entry */ /* create new xid entry */
item = xid_add(p->xid, client_addr, client); xid_add(p->xid, client_addr, client);
/* forward request to LAN (server) */ /* forward request to LAN (server) */
errno = 0; errno = 0;