emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libbb: dump: do not use uninitialized memory. close bug 4364.

Browse Source
This commit is contained in:
Denis Vlasenko 2008-07-29 00:00:14 +00:00
parent 043d15da31
commit 2f86d13dff
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libbb/dump.c
View File

@ -376,17 +376,16 @@ static unsigned char *get(priv_dumper_t *dumper)
{ {
int n; int n;
int need, nread; int need, nread;
unsigned char *tmpp;
int blocksize = dumper->blocksize; int blocksize = dumper->blocksize;
if (!dumper->get__curp) { if (!dumper->get__curp) {
dumper->address = (off_t)0; /*DBU:[dave@cray.com] initialize,initialize..*/ dumper->address = (off_t)0; /*DBU:[dave@cray.com] initialize,initialize..*/
dumper->get__curp = xmalloc(blocksize); dumper->get__curp = xmalloc(blocksize);
dumper->get__savp = xmalloc(blocksize); dumper->get__savp = xzalloc(blocksize); /* need to be initialized */
} else { } else {
tmpp = dumper->get__curp; unsigned char *tmp = dumper->get__curp;
dumper->get__curp = dumper->get__savp; dumper->get__curp = dumper->get__savp;
dumper->get__savp = tmpp; dumper->get__savp = tmp;
dumper->savaddress += blocksize; dumper->savaddress += blocksize;
dumper->address = dumper->savaddress; dumper->address = dumper->savaddress;
} }