emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PID should be stored in pid_t, not int or long.

Browse Source 
find_pid_by_name() was returning 0 or -1 in last array element,
but -1 was never checked. We can use just 0 intead.
This commit is contained in:
Denis Vlasenko
2006-11-01 09:16:49 +00:00
parent d3ada32285
commit 35fb512728
8 changed files with 76 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
procps/ps.c
View File

@ -58,7 +58,7 @@ int ps_main(int argc, char **argv)
len = sizeof(sbuf);
if (is_selinux_enabled()) {
if (getpidcon(p->pid,&sid) < 0)
if (getpidcon(p->pid, &sid) < 0)
sid = NULL;
}
@ -71,14 +71,14 @@ int ps_main(int argc, char **argv)
} else {
safe_strncpy(sbuf, "unknown", 7);
}
len = printf("%5d %-32s %s ", p->pid, sbuf, p->state);
len = printf("%5u %-32s %s ", (unsigned)p->pid, sbuf, p->state);
}
else
#endif
if (p->rss == 0)
len = printf("%5d %-8s %s ", p->pid, p->user, p->state);
len = printf("%5u %-8s %s ", (unsigned)p->pid, p->user, p->state);
else
len = printf("%5d %-8s %6ld %s ", p->pid, p->user, p->rss, p->state);
len = printf("%5u %-8s %6ld %s ", (unsigned)p->pid, p->user, p->rss, p->state);
i = terminal_width-len;