emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix read_cmdline API and a small buglet where "[comm]" may be too narrow

Browse Source 
function                                             old     new   delta
func_args                                             25      26      +1
read_cmdline                                         119     114      -5
display_process_list                                1462    1447     -15
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/2 up/down: 1/-20)             Total: -19 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko
2009-09-12 00:15:34 +02:00
parent ae357bd713
commit 3a0f6f2328
4 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
libbb/procps.c
View File

@@ -464,18 +464,19 @@ procps_status_t* FAST_FUNC procps_scan(procps_status_t* sp, int flags)
void FAST_FUNC read_cmdline(char *buf, int col, unsigned pid, const char *comm)
{
ssize_t sz;
int sz;
char filename[sizeof("/proc//cmdline") + sizeof(int)*3];
sprintf(filename, "/proc/%u/cmdline", pid);
sz = open_read_close(filename, buf, col);
sz = open_read_close(filename, buf, col - 1);
if (sz > 0) {
buf[sz] = '\0';
while (--sz >= 0 && buf[sz] == '\0')
continue;
while (--sz >= 0)
do {
if ((unsigned char)(buf[sz]) < ' ')
buf[sz] = ' ';
} while (--sz >= 0);
} else {
snprintf(buf, col, "[%s]", comm);
}