From 3a4cdf45f928de0af09088bbbb96f60d9ac44e87 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Wed, 21 Dec 2016 04:13:23 +0100 Subject: [PATCH] ash: error out if ASH_INTERNAL_GLOB is not selected on uClibc Signed-off-by: Denys Vlasenko --- shell/ash.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/shell/ash.c b/shell/ash.c index 8d8cc466b..7d45b2cd2 100644 --- a/shell/ash.c +++ b/shell/ash.c @@ -51,6 +51,14 @@ # define ENABLE_ASH_INTERNAL_GLOB 1 #endif +#if !ENABLE_ASH_INTERNAL_GLOB && defined(__UCLIBC__) +# error uClibc glob() is buggy, use ASH_INTERNAL_GLOB. +# error The bug is: for "$PWD"/ ash will escape e.g. dashes in "$PWD" +# error with backslash, even ones which do not need to be: "/a-b" -> "/a\-b" +# error glob() should unbackslash them and match. uClibc does not unbackslash, +# error fails to match dirname, subsequently not expanding in it. +#endif + #if !ENABLE_ASH_INTERNAL_GLOB # include #endif