emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bb_strtoXXX: close bug 4174 (potential use of buf[-1])

Browse Source
This commit is contained in:
Denis Vlasenko 2008-07-17 08:48:13 +00:00
parent 627052e75d
commit 416914fc61
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
libbb/bb_strtonum.c
View File

@ -30,12 +30,6 @@ static unsigned long long handle_errors(unsigned long long v, char **endp, char
{
if (endp) *endp = endptr;
/* Check for the weird "feature":
* a "-" string is apparently a valid "number" for strto[u]l[l]!
* It returns zero and errno is 0! :( */
if (endptr[-1] == '-')
return ret_ERANGE();
/* errno is already set to ERANGE by strtoXXX if value overflowed */
if (endptr[0]) {
/* "1234abcg" or out-of-range? */
@ -44,6 +38,11 @@ static unsigned long long handle_errors(unsigned long long v, char **endp, char
/* good number, just suspicious terminator */
errno = EINVAL;
}
/* Check for the weird "feature":
* a "-" string is apparently a valid "number" for strto[u]l[l]!
* It returns zero and errno is 0! :( */
if (endptr[-1] == '-')
return ret_ERANGE();
return v;
}