emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ash: jobs: Don't attempt to access job table for job %0

Browse Source 
Upstream commit:

    jobs: Don't attempt to access job table for job %0

    If job %0 is (mistakenly) specified, an out-of-bounds access to the
    jobtab occurs in function getjob() if num = 0:

            jp = jobtab + 0 - 1

    Fix this by checking that the job number is larger than 0 before
    accessing the jobtab.

    Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko
2016-09-29 01:10:08 +02:00
parent 928e2a7ef4
commit 46a45ce02f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/ash.c
View File

@ -3654,7 +3654,7 @@ getjob(const char *name, int getctl)
if (is_number(p)) { if (is_number(p)) {
num = atoi(p); num = atoi(p);
if (num <= njobs) { if (num > 0 && num <= njobs) {
jp = jobtab + num - 1; jp = jobtab + num - 1;
if (jp->used) if (jp->used)
goto gotit; goto gotit;