emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

strncmp isn't automatically superior to strcmp. Especially when it isn't

Browse Source 
used right.
This commit is contained in:
Rob Landley 2005-12-18 20:34:41 +00:00
parent 9bdd742dd2
commit 553d83d427
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
loginutils/vlock.c
View File

@ -101,7 +101,7 @@ extern int vlock_main(int argc, char **argv)
} }
if (argc == 2) { if (argc == 2) {
if (strncmp(argv[1], "-a", 2)) { if (strcmp(argv[1], "-a")) {
bb_show_usage(); bb_show_usage();
} else { } else {
o_lock_all = 1; o_lock_all = 1;
@ -199,7 +199,7 @@ extern int vlock_main(int argc, char **argv)
} }
crypt_pass = pw_encrypt(pass, pw->pw_passwd); crypt_pass = pw_encrypt(pass, pw->pw_passwd);
if (strncmp(crypt_pass, pw->pw_passwd, sizeof(crypt_pass)) == 0) { if (strcmp(crypt_pass, pw->pw_passwd) == 0) {
memset(pass, 0, strlen(pass)); memset(pass, 0, strlen(pass));
memset(crypt_pass, 0, strlen(crypt_pass)); memset(crypt_pass, 0, strlen(crypt_pass));
restore_terminal(); restore_terminal();